From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72364 invoked by alias); 7 Aug 2017 22:28:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 72230 invoked by uid 89); 7 Aug 2017 22:28:29 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: =?ISO-8859-1?Q?No, score=-2.6 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:102, for=c2?= X-HELO: NAM03-DM3-obe.outbound.protection.outlook.com Received: from mail-dm3nam03on0054.outbound.protection.outlook.com (HELO NAM03-DM3-obe.outbound.protection.outlook.com) (104.47.41.54) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 07 Aug 2017 22:28:23 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Received: from sellcey-dt.caveonetworks.com (50.233.148.156) by DM5PR07MB3547.namprd07.prod.outlook.com (10.164.153.145) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1304.22; Mon, 7 Aug 2017 22:28:20 +0000 Message-ID: <1502144898.3962.102.camel@cavium.com> Subject: Re: [Patch] Testsuite fixes for failures caused by patch for PR 80925 - loop peeling and alignment From: Steve Ellcey Reply-To: sellcey@cavium.com To: Rainer Orth , Richard Biener Cc: gcc-patches , rdapp@linux.vnet.ibm.com Date: Mon, 07 Aug 2017 22:28:00 -0000 In-Reply-To: References: <1501193805.28549.115.camel@cavium.com> <1501266127.28549.118.camel@cavium.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: DM5PR13CA0049.namprd13.prod.outlook.com (10.175.103.139) To DM5PR07MB3547.namprd07.prod.outlook.com (10.164.153.145) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: d1de6135-c585-47c9-4c43-08d4dde39c07 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:DM5PR07MB3547; X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3547;3:RZe/9f1hnAMzJQp1wYAcVqjE9p8zfQZL1kaJ5k0+wmjg2q607c90kZGFRvKnX/CG9QWlEmzMBJSnkLOZxSkPm5QMs62SEn6ZcZOWeQpskho1PUSZRBYi/i2+HQyqjzuNYJkY6uZ2DeK+x08otIb7vChKB7WuV2ftGNHgfzm8VfcYdVsN7Qq2+3LNGevB6AuJrgLmpXR4kYyl6xRqgMtzT7T+zYYmtbeSPetUEVPRbX7li+/3vGURhjkOgvo5JQA+;25:J+o86nMykSE+xo0c0Ha+VYiiKM9bpE3GdX8azP5i7zdyA+TUP9MzChPH0Z/6hu06AeodFEQetaI1nU9U8yXC3Oug246e3mdAPKVDdNDc/iBOrAlWHMihq8ajxxVxRATUybDzcF4PoH5x01aozrtJCf7V6jJcqKjixBKgvsJP1XuEOYI0w610pLMuVwyEYucx7wq6CB4sYYyh/G5J19/711gF76zg1NU3hL7LEQnLmEQPj1WttYTvYFJTbOPoB1s7GJAVkurPuRG/HtbvGDm4sVieRzp2tno1cMXTHVJ4g0ILSHgxhuExYAXjg8dFC7EIoq4Ti1Wcl6NN3Dxr6rNOdQ==;31:xj0RWvv+SM5nZ1N1euSSPO3qRAqOpD7mEiKUoW8sQT+UdpyWKBMQE8Zp3J4Y+K3Vbr2oVZd/CH3IVESoUxcbdkKZ8odvAGUG6FwXCLzpfEVBZ/FNfBhb4lHwPQcxl6COYBVqp//86qMsdsEj7fPGbgLVn05xmwA2yrjIPj5zhXU0QGibPRxk1LNs8WVmLdHlYHcn00SZnCgSuepi69w7BErBQ+GjcVPRYEDWwFKA1ME= X-MS-TrafficTypeDiagnostic: DM5PR07MB3547: X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3547;20:Wmk6ujMxkJW0woY6Pij3hAujHyTQJMR92Ri34AS8W3kmx+7oP5l9br46WeicJ+aEjSthRHO12LEtubIPbP90J9wWfaKWlXf94uZHdJC1gOsffdWH/Ebnuhk5Fq3LR6ff50AbZ0X6sCQzCum9orxZKbdHqAgAxHoQKXSGO2Q0QtmyiXoU70RyFp2R2nI8EY8truw1zeuo0lKG7pUEPvo1xD9DTQXIXq8racQ2DDfpedzn8/DSHOe2h+rhbzGwUYm8VXxrnSKj6CuxznRa5pjs8MHWokPjJKLE1mO7nz6SZFUHO/tnmsLbfF/OkoBKkOd7endE0ZCjBq9/TWguvpqEI/WKEVTh2BAzYqCtfSln8CfvZbJIYIHNS0XrIlh6s9lnfElvnO/ZWYKvChpGtOH7Y7BbxvknvqUQdXIW/B0X8/tIlkcy0R/7MFybT44zsyAVR7DVuaEp9X4kfEQd2igkyGBMp+m40Yo9nil/kK7PdfhRoq9oG+Q1Ieg6oe4YZ0iL;4:gT80lIC/vJsCsVa0WegP0fttpqTbxP3fVe6jmdc+PHMEcAELzrDCZ8kkyesAQrS/i/sKvtBp8YUExeKJ4AnEEGZ/vbNlqtObSm/aQ2+O2mYadV0C8UOt925c1KYSxKixy/AucPFUiClmzE5Cp9tlAYQMQFe4wJ+2eyA2n3uEwdvW//yY38ypgZ2YCTjIw8S41oLaQiznFDOBvDqnc32TnG7GiqpJ07M31AjR4XbhoyeMWGAqfC5qPOZwp/8xpccL X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(601004)(2401047)(5005006)(8121501046)(93006095)(93001095)(10201501046)(3002001)(100000703101)(100105400095)(6041248)(20161123555025)(20161123564025)(20161123560025)(20161123562025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123558100)(6072148)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DM5PR07MB3547;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DM5PR07MB3547; X-Forefront-PRVS: 0392679D18 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(7370300001)(4630300001)(6009001)(39410400002)(39450400003)(39840400002)(39400400002)(39850400002)(377454003)(24454002)(377424004)(199003)(189002)(69596002)(3450700001)(6512007)(478600001)(38730400002)(53936002)(68736007)(7350300001)(2870700001)(36756003)(2906002)(25786009)(97736004)(50226002)(2950100002)(53546010)(189998001)(5660300001)(229853002)(101416001)(23676002)(76176999)(50986999)(5820100001)(4326008)(33646002)(6506006)(305945005)(72206003)(47776003)(106356001)(6246003)(7736002)(93886004)(50466002)(105586002)(3846002)(42186005)(6116002)(43066003)(103116003)(81166006)(81156014)(66066001)(6486002)(53416004)(8676002)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:DM5PR07MB3547;H:sellcey-dt.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;A:1;MX:1;LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtETTVQUjA3TUIzNTQ3OzIzOnRwYmMyMHpVOTlrNE9pbmlEL0ptc1QrZThX?= =?utf-8?B?a0NzR1VXVks4N3BIYU43TkZDS0xyZHh5TlRYeWw0NFpYeGpWV1Jkcjl2ckRt?= =?utf-8?B?OHZvRXR6QUxnYzI0enpWRGo2eEFtV0FTNDZLMGhWK0ZzOHIvTndmQ29sYy9G?= =?utf-8?B?YTBGMTdaVWNFQTZRSTl6ZnREVnNrQnJYWmV6azVUbW82VGVTSnN5N1c3QS84?= =?utf-8?B?TXhUTXNpU3lXck9XeWE3TkhFUDlYTE5lWnF5RmE0c0FOS1M4cHI4SFJ4cEVX?= =?utf-8?B?RHdIT0J4TVpBeksxdXZzckx0VzRxQVVObURwMnhDaDI5dW9NQ24vZ1U2eDE3?= =?utf-8?B?ZUNBSTNhNFdUb3d4RXRmWHBjMno0dkZocUJnVzZYQy9IVFlxcldlb2NlNUFa?= =?utf-8?B?V2hYQm5uank4NG1DY0JjQ3ZHdFMvMVJRR1ZxM2RNd2lWTmM2cFNxOW5DQXlw?= =?utf-8?B?NkpSaDVBUU8xcHFlQnFJeFhFK3pjdytZMUtEam9PcEpaZUFHYjdmRGo5dTMx?= =?utf-8?B?OWxoZ3NuL1ZscmxDYVdqdkw4d3JtbUpFQWVTeFU4Q0FNeFBEMm95QzF5aVI1?= =?utf-8?B?bFNYOTJvNXZOajArOThSdDFiUmJhQ09tRWlnOURMTHhpS1BScS9TSkhWRTRz?= =?utf-8?B?TkVjZjFlZjFwM3ErRFRsdzNqaXhiMjExbisydUdmZ0FoUWFmZEJIZzZiQVNv?= =?utf-8?B?dDY0VXpqMmFXcW5xNnJPNmd3SjJyY2VHNHZhSUQvUnVqK1o0UW9NOTM4Y2cw?= =?utf-8?B?V0ZFbGdleGVVTm9WNVNyZUdudGRHcG5nL0YwSUN0c1djcWErNHU2dVNjMzhC?= =?utf-8?B?NE9hdUxkTkJEUEMrYVI0ZUJmWElkZCs4ZGNhWmxXbG5aQzJVajhtei83RGFZ?= =?utf-8?B?R2NGTkhPL256Z2Y0KytWcFBmU2F4TmI5S0N4empyeU1DdDhhTjUzV2FSRDZV?= =?utf-8?B?QjI1ejhOREF5ZXlQbXdEOWhZNEFiSmI1TnBzNGZCRnE2ZXdDeGwrYzEyTURR?= =?utf-8?B?eGJrVVBUUTZvR0NQTGk1blJ5MmErZU5PSXg3aVA1VHlsK2JlMWkwcGNKYXN3?= =?utf-8?B?ODJjYys3MnNsN293VHhHT3J2QkIyWEdINEttSlVSSmgwcTRZQnB5VDREcitW?= =?utf-8?B?N3lsL3BKeUpNM1hLS3NSQmFWalRwcUNFRlc0by9IT3FFYjI0dWdTOVRlVCtT?= =?utf-8?B?akZLQnRmS3IybGtyRTF5SjdyN3d4TFk0c1JHbm1KSnJxM043cWVXZ0NIRldN?= =?utf-8?B?V2lFcnZjQXpNNlBjQklkNW5rcVVsRngvVFQ4Q3IzcDI2QWdiT2pVcDZjQkNP?= =?utf-8?B?eVR6cFgzbFdVN2xlRndES0Y0YlpMMFRNajR3VjUrWTFKZU5PKzhXWjZqQTN3?= =?utf-8?B?ak1wdkJTMmhiTEtTRXBvaEFiYSt0YW0xcFpVcDhkcnhxK1pXR3NHUytSck9h?= =?utf-8?B?NEowcGlsaHlXaXdXWUttOVNNMWlDSnVHcmhYeHZJaWdGK0VmaDZ0SVZYOHFh?= =?utf-8?B?OUswRHBoVlFXYUFaM1Rwb0tsbXpWLzJtTVpXRXRDZVVsNFlmZzBYRW5wa3FZ?= =?utf-8?B?Q3RlbVM1MlRqM3I2TEFITTVDd3pzd2ZaclpYK2Z2S3c0cHhSRzYyNzIwek5r?= =?utf-8?B?OXhDcC84T1RNbE56SnZmMEREWFM2SDZqb1RPSnNEYlVIWTBsV2diTVpFMUxr?= =?utf-8?B?UDVYbUZrQUVDekJVV3RaWFVsT0Y4ZWRoYmVLQ2NJS2p4L3RFMHoweXJIWE1k?= =?utf-8?B?L0FNdDVFV01HTXk0RnhqeUFaUkRqMXg5NmFlU0tBbHZhTXZXc01IR2FKcVBp?= =?utf-8?B?ZFpSSVhtZkpYWDd2M2x1a0ZKYml1VUpEMHNGYVN0bmZ4K09jOWdVMHVDL3ZB?= =?utf-8?B?d2w0amxKa3h6eEZ1cjZUWXZsT0ZTWHZHZXVnNVFFTU1Wa3E2MU9GeS8rQnBX?= =?utf-8?B?TDV2WU1BbzY5MDlzc3ZuTXJwL1loaXRVR21uTW1SWklDM3N6U0UxSFRyVWF4?= =?utf-8?B?bHJCbFFlNzRJZ2dBbkllSEJ6a2hNUWlTeVhzdz09?= X-Microsoft-Exchange-Diagnostics: 1;DM5PR07MB3547;6:JFWMQYVllYChOA2zIoHSWaK44N7856ZCEg1YdT4Kshimdt18Z/rbL2yFJI1uC0X718WT7u1wKGV0aXVQHcC9W/zOcmh+qsAZHdjTE/YoK+YVSFuZekZt5eQ+Wm9i2xVr45UD+dQYUZ5jtNcpoS4TgrZ0ouwB2QGOyqKU6CKHliv8OXJe0BeIaNTcP/3s8LaXlonAl5o1pXX5a1GaqsH8CLiPuYUAMLtTDPlNLg1LHG2mu8VrrzzqnVfLwa9tqqD5la45JWiPXlUH2tQrK/l6bpSpNT2ZEqQmCpfAcaCtck++PCMM6DD4MO6/uH1jWi4Tklx5XNBhDA1BNNgMmcTTTA==;5:eAXRZw2CXGHWhy9S9nwGtoWpZ8lOMieEP4vVUQBiOO5VURtdakRHikeIJzT7W3YVwTg0L9l+u6mlnFjJC0sLDsqDbRvANZwH22A5o7+BXazXp758qtneRIg650W27HDUlOvEOU9lPOmltvq4raE8fw==;24:ZTOjw0L36RC7DKXXncX3jFLRYocgbtDoUULOhzF0Jl8NeOtmA80BHX1mOnTRlp5gvU6pmjT2oSjUFWuvKapRwPT3MQWkb/5rwSgCAXRFePg=;7:HF//6LJYWBsG9DLBCq7emNL6cb8gAYZEFbFSx89LkkxFV3oCq+epxrlcUwI47FT2X1aFw6iqPAWwPG9vsMvS2iAqzMkoVcGJyd7dVTK2O6N/UPDS/VCuLDre4QXyxSyJagvUGWLqOk4eHCXGXPx1vYoFWCe3Uus2Kz1xtc5GjyGtNOmGrc2y1ynsqpX5ZSFsop/uMrf3MQXTCwhpmb2Dv07uWeSxJivn7ppO5qn/5gU= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 07 Aug 2017 22:28:20.7839 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR07MB3547 X-SW-Source: 2017-08/txt/msg00556.txt.bz2 I am not sure why this is failing on Solaris/SPARC, do you have the vector dump file from the test so we can see what it says about the loop it stopped vectorizing?  I don't have a Solaris/SPARC system here, I tried to build an 'initial' gcc for sparc-sun-solaris2.11 but I  could not reproduce the error using that.  I am not sure why. Steve Ellcey sellcey@cavium.com On Fri, 2017-08-04 at 16:27 +0200, Rainer Orth wrote: > Richard Biener writes: > > > > > On Fri, Jul 28, 2017 at 8:22 PM, Steve Ellcey > > wrote: > > > > > > On Fri, 2017-07-28 at 09:47 +0200, Richard Biener wrote: > > > > > > > > On Fri, Jul 28, 2017 at 12:16 AM, Steve Ellcey > > > com> wrote: > > > > > > > > > > > > > > > Any comments from the power and/or vectorizer folks? > > > > On one side I'm inclined to simplify the testsuite by adding > > > > --param vect-max-peeling-for-alignment=0 in addition to > > > > -fno-vect-cost-model we already pass and override that in the > > > > tests that specifically exercise peeling for alignment (do we > > > > have > > > > any?). > > > > OTOH that would remove quite some testing coverage of prologue > > > > peeling. > > > > > > > > So ideally testresults would be clean with both no such --param > > > > and that --param added... > > > > > > > > I think most of the testcases you needed to adjust have nothing > > > > to do with peeling for alignment thus adding this --param just > > > > for > > > > those (and simplifying their dump scanning accordingly) is > > > > another > > > > pragmatic option. > > > > > > > > Adding yet another target (vect_peel_align) is IMHO not good, > > > > especially as this one depends on cost tuning and not HW > > > > features, so it's impossible(?) to dynamically compute it > > > > with a test compile for example (we _do_ want a clean > > > > vect.exp with any vector HW / tuning switch you add). > > > How about something like the following.  I only fixed two of the > > > tests, > > > I can follow up with more if this approach seems reasonable.  I > > > tested > > > this on aarch64 and x86_64. > > Looks good to me. > > > > Richard. > > > > > > > > Steve Ellcey > > > sellcey@cavium.com > > > > > > > > > 2017-07-28  Steve Ellcey   > > > > > >         PR tree-optimization/80925 > > >         * gcc.dg/vect/no-section-anchors-vect-69.c: Add > > >         --param vect-max-peeling-for-alignment=0 option. > > >         Remove unaligned access and peeling checks. > > >         * gcc.dg/vect/section-anchors-vect-69.c: Ditto. > This broke the test on Solaris/SPARC: > > +FAIL: gcc.dg/vect/no-section-anchors-vect-69.c scan-tree-dump-times > vect "vectorized 4 loops" 1 > > both 32 and 64-bit.  The dump now has > > no-section-anchors-vect-69.c:39:5: note: vectorized 3 loops in > function. > > and (compared to the gcc-7 branch) > > no-section-anchors-vect-69.c:44:3: note: not vectorized: unsupported > unaligned store.tmp1[2].a.n[1][2][i_74] > > Rainer >