From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 112976 invoked by alias); 9 Aug 2017 14:40:10 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 112950 invoked by uid 89); 9 Aug 2017 14:40:09 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-26.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_0,GIT_PATCH_1,GIT_PATCH_2,GIT_PATCH_3,RCVD_IN_DNSWL_LOW,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 09 Aug 2017 14:40:07 +0000 Received: from pps.filterd (m0098416.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.21/8.16.0.21) with SMTP id v79Ecu38019585 for ; Wed, 9 Aug 2017 10:40:06 -0400 Received: from e15.ny.us.ibm.com (e15.ny.us.ibm.com [129.33.205.205]) by mx0b-001b2d01.pphosted.com with ESMTP id 2c83dkv7jg-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 09 Aug 2017 10:40:06 -0400 Received: from localhost by e15.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 9 Aug 2017 10:40:05 -0400 Received: from b01cxnp22035.gho.pok.ibm.com (9.57.198.25) by e15.ny.us.ibm.com (146.89.104.202) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Wed, 9 Aug 2017 10:40:02 -0400 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp22035.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id v79Ee2lM31981746; Wed, 9 Aug 2017 14:40:02 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 6F0AD112040; Wed, 9 Aug 2017 10:39:53 -0400 (EDT) Received: from [9.10.86.107] (unknown [9.10.86.107]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP id 2753A11205F; Wed, 9 Aug 2017 10:39:53 -0400 (EDT) Subject: Re: [PATCH, rs6000] enable early debug and disable switch for gimple folding From: Will Schmidt Reply-To: will_schmidt@vnet.ibm.com To: Segher Boessenkool Cc: GCC Patches , Richard Biener , Bill Schmidt , David Edelsohn In-Reply-To: <20170808223143.GM13471@gate.crashing.org> References: <1502226896.6577.12.camel@brimstone.rchland.ibm.com> <20170808223143.GM13471@gate.crashing.org> Content-Type: text/plain; charset="UTF-8" Date: Wed, 09 Aug 2017 14:40:00 -0000 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 17080914-0036-0000-0000-000002561EE2 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00007513; HX=3.00000241; KW=3.00000007; PH=3.00000004; SC=3.00000218; SDB=6.00899847; UDB=6.00450444; IPR=6.00680052; BA=6.00005520; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00016610; XFM=3.00000015; UTC=2017-08-09 14:40:03 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17080914-0037-0000-0000-00004161A26C Message-Id: <1502289600.6577.40.camel@brimstone.rchland.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-08-09_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1706020000 definitions=main-1708090228 X-IsSubscribed: yes X-SW-Source: 2017-08/txt/msg00667.txt.bz2 On Tue, 2017-08-08 at 17:31 -0500, Segher Boessenkool wrote: > Hi! > > On Tue, Aug 08, 2017 at 04:14:56PM -0500, Will Schmidt wrote: > > * config/rs6000/rs6000.c: rs6000_option_override_internal() Add blurb > > to indicate when early gimple folding has been disabled. > > * config/rs6000/rs6000.c (rs6000_option_override_internal): ... > > > > rs6000_gimple_fold_builtin(): Add debug content. > > (rs6000_gimple_fold_builtin): ... > > > @@ -16157,10 +16161,26 @@ rs6000_gimple_fold_builtin (gimple_stmt_iterator *gsi) > > gcc_checking_assert (fndecl && DECL_BUILT_IN_CLASS (fndecl) == BUILT_IN_MD); > > enum rs6000_builtins fn_code > > = (enum rs6000_builtins) DECL_FUNCTION_CODE (fndecl); > > tree arg0, arg1, lhs; > > > > + size_t uns_fncode = (size_t)fn_code; > > Space after cast. More of this in the rest of the patch. > > > + if (TARGET_DEBUG_BUILTIN) > > + { > > + fprintf (stderr, "rs6000_gimple_fold_builtin %d %s %s \n", > > + fn_code,fn_name1,fn_name2); > > No space before \n, space after commas. > > > + if (rs6000_gimple_folding_disable) > > + return false; > > One space indented too many there. > > > diff --git a/gcc/config/rs6000/rs6000.opt b/gcc/config/rs6000/rs6000.opt > > index e94aa07..4372b00 100644 > > --- a/gcc/config/rs6000/rs6000.opt > > +++ b/gcc/config/rs6000/rs6000.opt > > @@ -146,10 +146,14 @@ Generate AltiVec instructions using little-endian element order. > > > > maltivec=be > > Target Report RejectNegative Var(rs6000_altivec_element_order, 2) > > Generate AltiVec instructions using big-endian element order. > > > > +mgimple-folding=off > > +Target Report RejectNegative Var(rs6000_gimple_folding_disable, 1) > > +Disable early gimple folding of builtins. > > Please use -mgimple-folding instead, or better, -mfold-gimple, along > with its no- variant? So no RejectNegative. > > It's probably easier to read if the internal var is the positive > version, too? Thanks for the review. (v2) incoming momentarily. > > > Segher >