public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
* RE: [PATCH] Fix PR 81096 (ttest failures)
@ 2017-09-12 10:59 Wilco Dijkstra
  2017-09-12 16:39 ` Ian Lance Taylor via gcc-patches
  0 siblings, 1 reply; 6+ messages in thread
From: Wilco Dijkstra @ 2017-09-12 10:59 UTC (permalink / raw)
  To: Ellcey, Steve; +Cc: GCC Patches, nd

Steve Ellcey wrote:
> This patch fixes the ttest failures on aarch64 by adding AM_CFLAGS to
> the test options, like btest already does and as Wilco says works for
> him in Comment #4 of the bug report.

Thanks for picking this up, this looks OK.

> Tested by me on aarch64.  Ok to checkin?

This counts as an obvious fix, so you can commit it.

Wilco

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR 81096 (ttest failures)
  2017-09-12 10:59 [PATCH] Fix PR 81096 (ttest failures) Wilco Dijkstra
@ 2017-09-12 16:39 ` Ian Lance Taylor via gcc-patches
  2017-09-12 16:43   ` Steve Ellcey
  2017-09-12 16:50   ` Steve Ellcey
  0 siblings, 2 replies; 6+ messages in thread
From: Ian Lance Taylor via gcc-patches @ 2017-09-12 16:39 UTC (permalink / raw)
  To: Wilco Dijkstra; +Cc: Ellcey, Steve, GCC Patches, nd

On Tue, Sep 12, 2017 at 3:59 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.com> wrote:
> Steve Ellcey wrote:
>> This patch fixes the ttest failures on aarch64 by adding AM_CFLAGS to
>> the test options, like btest already does and as Wilco says works for
>> him in Comment #4 of the bug report.
>
> Thanks for picking this up, this looks OK.
>
>> Tested by me on aarch64.  Ok to checkin?
>
> This counts as an obvious fix, so you can commit it.

Wait, what?  This patch is at best incomplete.  Makefile.in is a
generated file.  You need to change Makefile.am and re-run automake.

Ian

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR 81096 (ttest failures)
  2017-09-12 16:39 ` Ian Lance Taylor via gcc-patches
@ 2017-09-12 16:43   ` Steve Ellcey
  2017-09-12 16:50   ` Steve Ellcey
  1 sibling, 0 replies; 6+ messages in thread
From: Steve Ellcey @ 2017-09-12 16:43 UTC (permalink / raw)
  To: Ian Lance Taylor, Wilco Dijkstra; +Cc: Ellcey, Steve, GCC Patches, nd

On Tue, 2017-09-12 at 09:39 -0700, Ian Lance Taylor wrote:
> On Tue, Sep 12, 2017 at 3:59 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.c
> om> wrote:
> > 
> > Steve Ellcey wrote:
> > > 
> > > This patch fixes the ttest failures on aarch64 by adding
> > > AM_CFLAGS to
> > > the test options, like btest already does and as Wilco says works
> > > for
> > > him in Comment #4 of the bug report.
> > Thanks for picking this up, this looks OK.
> > 
> > > 
> > > Tested by me on aarch64.  Ok to checkin?
> > This counts as an obvious fix, so you can commit it.
> Wait, what?  This patch is at best incomplete.  Makefile.in is a
> generated file.  You need to change Makefile.am and re-run automake.
> 
> Ian

Duh,  I completely missed the fact that there was a Makefile.am.  I
will create a new patch to fix that.

Steve Ellcey
sellcey@cavium.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR 81096 (ttest failures)
  2017-09-12 16:39 ` Ian Lance Taylor via gcc-patches
  2017-09-12 16:43   ` Steve Ellcey
@ 2017-09-12 16:50   ` Steve Ellcey
  2017-09-14  1:09     ` Ian Lance Taylor via gcc-patches
  1 sibling, 1 reply; 6+ messages in thread
From: Steve Ellcey @ 2017-09-12 16:50 UTC (permalink / raw)
  To: Ian Lance Taylor, Wilco Dijkstra; +Cc: Ellcey, Steve, GCC Patches, nd

On Tue, 2017-09-12 at 09:39 -0700, Ian Lance Taylor wrote:
> On Tue, Sep 12, 2017 at 3:59 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.c
> om> wrote:
> > 
> > Steve Ellcey wrote:
> > > 
> > > This patch fixes the ttest failures on aarch64 by adding
> > > AM_CFLAGS to
> > > the test options, like btest already does and as Wilco says works
> > > for
> > > him in Comment #4 of the bug report.
> > Thanks for picking this up, this looks OK.
> > 
> > > 
> > > Tested by me on aarch64.  Ok to checkin?
> > This counts as an obvious fix, so you can commit it.
> Wait, what?  This patch is at best incomplete.  Makefile.in is a
> generated file.  You need to change Makefile.am and re-run automake.
> 
> Ian

OK, here is the new patch that I will checkin.  I verified that after
running automake on Makefile.am, the Makefile.in I got was identical
to what I checked in earlier.

Steve Ellcey
sellcey@cavium.com


2017-09-12  Steve Ellcey  <sellcey@cavium.com>

        PR other/81096
        * Makefile.am (ttest_CFLAGS): Add $(AM_CFLAGS)
        * Makefile.in: Regenerate.

diff --git a/libbacktrace/Makefile.am b/libbacktrace/Makefile.am
index b91d6bc..120beb1 100644
--- a/libbacktrace/Makefile.am
+++ b/libbacktrace/Makefile.am
@@ -117,7 +117,7 @@ if HAVE_PTHREAD
 check_PROGRAMS += ttest
 
 ttest_SOURCES = ttest.c testlib.c
-ttest_CFLAGS = -pthread
+ttest_CFLAGS = $(AM_CFLAGS) -pthread
 ttest_LDADD = libbacktrace.la
 
 endif HAVE_PTHREAD

^ permalink raw reply	[flat|nested] 6+ messages in thread
* Re: [PATCH] Fix PR 81096 (ttest failures)
  2017-09-12 16:50   ` Steve Ellcey
@ 2017-09-14  1:09     ` Ian Lance Taylor via gcc-patches
  0 siblings, 0 replies; 6+ messages in thread
From: Ian Lance Taylor via gcc-patches @ 2017-09-14  1:09 UTC (permalink / raw)
  To: sellcey; +Cc: Wilco Dijkstra, Ellcey, Steve, GCC Patches, nd

On Tue, Sep 12, 2017 at 9:49 AM, Steve Ellcey <sellcey@cavium.com> wrote:
> On Tue, 2017-09-12 at 09:39 -0700, Ian Lance Taylor wrote:
>> On Tue, Sep 12, 2017 at 3:59 AM, Wilco Dijkstra <Wilco.Dijkstra@arm.c
>> om> wrote:
>> >
>> > Steve Ellcey wrote:
>> > >
>> > > This patch fixes the ttest failures on aarch64 by adding
>> > > AM_CFLAGS to
>> > > the test options, like btest already does and as Wilco says works
>> > > for
>> > > him in Comment #4 of the bug report.
>> > Thanks for picking this up, this looks OK.
>> >
>> > >
>> > > Tested by me on aarch64.  Ok to checkin?
>> > This counts as an obvious fix, so you can commit it.
>> Wait, what?  This patch is at best incomplete.  Makefile.in is a
>> generated file.  You need to change Makefile.am and re-run automake.
>>
>> Ian
>
> OK, here is the new patch that I will checkin.  I verified that after
> running automake on Makefile.am, the Makefile.in I got was identical
> to what I checked in earlier.

Thanks for taking care of that.

Ian

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [PATCH] Fix PR 81096 (ttest failures)
@ 2017-09-11 18:59 Steve Ellcey
  0 siblings, 0 replies; 6+ messages in thread
From: Steve Ellcey @ 2017-09-11 18:59 UTC (permalink / raw)
  To: gcc-patches

This patch fixes the ttest failures on aarch64 by adding AM_CFLAGS to
the test options, like btest already does and as Wilco says works for
him in Comment #4 of the bug report.

Tested by me on aarch64.  Ok to checkin?

Steve Ellcey
sellcey@cavium.com


2017-09-11  Steve Ellcey  <sellcey@cavium.com>

	PR other/81096
	* libbacktrace/Makefile.in
	(HAVE_PTHREAD_TRUE@@NATIVE_TRUE@ttest_CFLAGS): Add $(AM_CFLAGS)


diff --git a/libbacktrace/Makefile.in b/libbacktrace/Makefile.in
index 5b2159d..2d8c212 100644
--- a/libbacktrace/Makefile.in
+++ b/libbacktrace/Makefile.in
@@ -352,7 +352,7 @@ TESTS = $(check_PROGRAMS)
 @NATIVE_TRUE@edtest_SOURCES = edtest.c edtest2_build.c testlib.c
 @NATIVE_TRUE@edtest_LDADD = libbacktrace.la
 @HAVE_PTHREAD_TRUE@@NATIVE_TRUE@ttest_SOURCES = ttest.c testlib.c
-@HAVE_PTHREAD_TRUE@@NATIVE_TRUE@ttest_CFLAGS = -pthread
+@HAVE_PTHREAD_TRUE@@NATIVE_TRUE@ttest_CFLAGS = $(AM_CFLAGS) -pthread
 @HAVE_PTHREAD_TRUE@@NATIVE_TRUE@ttest_LDADD = libbacktrace.la
 
 # We can't use automake's automatic dependency tracking, because it

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-09-14  1:09 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-09-12 10:59 [PATCH] Fix PR 81096 (ttest failures) Wilco Dijkstra
2017-09-12 16:39 ` Ian Lance Taylor via gcc-patches
2017-09-12 16:43   ` Steve Ellcey
2017-09-12 16:50   ` Steve Ellcey
2017-09-14  1:09     ` Ian Lance Taylor via gcc-patches
  -- strict thread matches above, loose matches on Subject: below --
2017-09-11 18:59 Steve Ellcey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).