From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 88138 invoked by alias); 20 Sep 2017 23:36:52 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 87389 invoked by uid 89); 20 Sep 2017 23:36:51 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*M:127, her X-HELO: NAM01-SN1-obe.outbound.protection.outlook.com Received: from mail-sn1nam01on0072.outbound.protection.outlook.com (HELO NAM01-SN1-obe.outbound.protection.outlook.com) (104.47.32.72) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 20 Sep 2017 23:36:50 +0000 Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=Steve.Ellcey@cavium.com; Received: from sellcey-dt.caveonetworks.com (50.233.148.156) by MWHPR07MB3549.namprd07.prod.outlook.com (10.164.192.138) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.56.11; Wed, 20 Sep 2017 23:36:46 +0000 Message-ID: <1505950604.2286.127.camel@cavium.com> Subject: Re: [PATCH][aarch64] Fix error calls in aarch64 code so they can be tranlated From: Steve Ellcey Reply-To: sellcey@cavium.com To: Martin Sebor , =?ISO-8859-1?Q?Fr=E9d=E9ric?= Marchal Cc: gcc-patches , roland.illig@gmx.de Date: Wed, 20 Sep 2017 23:36:00 -0000 In-Reply-To: References: <1505759191.2286.72.camel@cavium.com> <8c5cbe12-4ed0-edb7-f126-cc0fb610c588@gmail.com> <2870639.NQtlXYLpcP@development> <1505836441.2286.93.camel@cavium.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: MWHPR08CA0016.namprd08.prod.outlook.com (10.174.103.157) To MWHPR07MB3549.namprd07.prod.outlook.com (10.164.192.138) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f77875c-bdfb-49ec-93cd-08d5008075ad X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(300000500095)(300135000095)(300000501095)(300135300095)(22001)(300000502095)(300135100095)(2017030254152)(300000503095)(300135400095)(2017052603199)(201703131423075)(201703031133081)(201702281549075)(300000504095)(300135200095)(300000505095)(300135600095)(300000506095)(300135500095);SRVR:MWHPR07MB3549; X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3549;3:myHFv/fnqANRy6mYHqWXQFMcRdmkzh0Gc6DqPg/IhAlUJOI/wnAF1L0VS2xDCIvWajz+50pM+eTJAysJYXgx61Or3Smx3+bP5c00P8GKbob0hIP5IDyjvlHs1jpUwLHOJMWWup/278vOcg40ra+fewoofHcrL7vvcJZOWfkzPtogfyxSVxMajqYLual13YM9kyZYa7oMSWn6X1iFep9qEkxg6xkAyJYM56qsfFEI1zJwZVl7XagnaLVZ0nankxYO;25:+03HIqI1DqfmCdh6+9N8c4Yj988YA70MrgKq+mM32WIw1UhenPeBES+a92YkMoNf7gzPfjeLH/2HcO8oXK3XLBuK1kqbRP+pSCscMhSynUdvmswllaHDpE57CU8FnHmys1BGWhV7o+naap/W8SJk63bSDworJ9vXCv1q2Jxrx2oQPN3b1wXN9lNMgempq/AX4gKs8io+t4jlj+udV4a8bWPtSbGANmiaPmm9/cedJuo5fXvxoYQn1VoO0YZlkWJuRoJeiU6HOsU7uGJE44di6EffBm0A4diM92rh1txvTNcPFApGttQy6zwJVZJ9ZpdHRjgC+c7d/DNKndam7BhqXA==;31:K2kxB0bqrUHytwd71IrpklTn9+pVSKXKXFBfdnSxmbFW5eMRzI6otBfqkgPhYEKwWEdvh5LgNGOIPv6bPoxM73NHnne5yQlnGym9JrNnR4vmCxx/TSVjuiPXUtaioAW6tVkcmc8bZn/uiogro3K/qnoHnr4knKVfbkjfr5nqyZ6jxOe8mVVLmCzsYvtbownfl4azDdg1q+pz0dFkh0y7tULaywFYp2ubZu6iDQmH3d0= X-MS-TrafficTypeDiagnostic: MWHPR07MB3549: X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3549;20:vCiqB5ijzdcY0Y5QCYmXQ37UU9V7sb10Rl3/jnmWvgMdxIlysgwCuD7ZgElvtX9/gCACuuNqO2gTa3izFh/yUQMSzgCW1sbnVSgBTpnTmR2YZdqfy6W11QIw0fSzkJTJnKCTJJFn0I3kIUKZWohR7hggmWN1xZ0stsUTY4ofbaGA8gLm7JbqSG2PL/WfRiB6RYeuwVeb2XaWCbWtZjBltpHrV+E+qjFp0gdBVnE6gir7aQI1MSe+yO+uy7e2H4EvO8+L4POzfGay50RexYczPSn1K+xMMr6utS5D5U8Wm7tup1+1rjtw+2TquoNA1sMHy0P+3Vk5SGNdM1hzZCfClIAqR8fSEKAgRKY4ne5KoYeSoqyUeTpbo1VAoc8bU790M5H7D/IaKFcC1BDMv+0NrS9J+RvPXrkSKqUAQiWKK1XAkYGPhq0JnSBmtHqLaBpyaw7bgiT7G/F8O/tKBFOaq3e2zlqDEFUjmleWw6uSbc/W1yooGqh4HPmHQKaNob+Z;4:xj25PkTSb6OqumcRUmenPBv2/jwLKMJMqvTaLKTU/gwLyK0ssiC5c6BsgQTlGLhnj44Ws9Ryur5xhYOSTGhPyT3bAomasekh3gW195pUK8Ahw77HN7gWk9QSsRhhlRFdIAkktd1KBsfLkwfKxQKUP+aHcruzFaxaeb03y8k6pY3sjvywAkIHhpY+S6PJEjxoDJvwORB8AOZSqWJapvEpg6V+y3TwTnKZV1oskxicATNcbE0vpeb/Cj+tupVdCdl+ X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(100000703101)(100105400095)(93006095)(93001095)(3002001)(10201501046)(6041248)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(20161123562025)(20161123564025)(20161123555025)(20161123558100)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:MWHPR07MB3549;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:MWHPR07MB3549; X-Forefront-PRVS: 04362AC73B X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6009001)(376002)(346002)(377454003)(24454002)(189002)(199003)(377424004)(6246003)(81156014)(4326008)(478600001)(105586002)(305945005)(3846002)(72206003)(43066003)(7736002)(6512007)(5660300001)(33646002)(47776003)(316002)(66066001)(6116002)(53936002)(53416004)(39060400002)(8666007)(189998001)(106356001)(110136005)(16526017)(93886005)(50466002)(2950100002)(68736007)(2906002)(25786009)(103116003)(50226002)(8936002)(3450700001)(76176999)(50986999)(2870700001)(101416001)(97736004)(229853002)(6506006)(81166006)(5820100001)(36756003)(53546010)(6486002)(69596002)(23676002)(8676002)(99106002);DIR:OUT;SFP:1101;SCL:1;SRVR:MWHPR07MB3549;H:sellcey-dt.caveonetworks.com;FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: cavium.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtNV0hQUjA3TUIzNTQ5OzIzOlExbEZJK21PRURQdUtieHcwOUJ1ZFBlMDA2?= =?utf-8?B?WUpjcW5teks0OGRqQmw5aWlTNkNOVUxOUUExeVkyRmdwVjYwcFhpcWg4WnBN?= =?utf-8?B?MUlmc2xNclhuNkM0WVpQdjFUQnNtTVJxU20yZjRxbFZ0bnY4VGE0QXpjLzZr?= =?utf-8?B?YUVBUGovWVZGamZOQlRrbktCNndrZlU3NXZIYTVRUVRaUWlnc2wxcGFLV1hT?= =?utf-8?B?ZTl5eFFXZFFGU3JDZDZoSzNkcXpFcUl0NjB3RmxoSW9vSG1NS0o2aDljbEkx?= =?utf-8?B?dmdMSkEvNmxja091aDdUM0VYbU5MWWhzNGpjLzNFSHJibldTVk9LMG1NcmlM?= =?utf-8?B?RGhraWlIT0lYUk0xU0JFT0MwZUtFQjlCT3hyMldFQzZGZ09NK3hqallFS2gr?= =?utf-8?B?cWdUZWpYWEx4RCtGbnNrejR6cThrN0NES0RuaHNDRDhPRmxYYUVrQm1HdWVo?= =?utf-8?B?aDJhOFNSR1Z2UFJmMnV0ZUpiNHdocURQUUV0RWF1RnI3eG1CR2x1Ykc1VVFQ?= =?utf-8?B?WDdqOWRIcUNTYm15dWRueTZyL1JvcU5jZEVUbXkrMDIzSHowNzY1dVJnWUJB?= =?utf-8?B?amhCc1Zwc1VXSWFyVmxFZ0ZMMGVrdnBPNGczSmtFYkJDbnJQTFdrOC9MTzQz?= =?utf-8?B?SmFVVE16VTcvMXJBVUxTQ3VrM1h6K2ZTMkZUcC9TbTRxZUZDbXdBbGs4ODZE?= =?utf-8?B?bUdHZzhzQzEreWMwV2RYMlhzVGQ4U3JzdFBGbzdaMVJFYkt0ci9RbXdGdkl4?= =?utf-8?B?MFdFV2Y3RnRvbjVkbFlOZVdPTVp1cmpMUjlibzE2d2xQZHhoVFZvTGY2a2w0?= =?utf-8?B?NnQ3SWx1c3B5ajNLZ0VvQ1dLR3pMV1lzNEJBS2JlODVyMFRJMThyOWRlZWYw?= =?utf-8?B?MjFma2ZQUC9PTEdHVjh0Y2Y2SDNyb2YvSUFUQU4xT0lSNjFZeW83UjNtNE5N?= =?utf-8?B?SlNnNkZJOVFCdWRNaDh5NStQeHh0SnJwaUYxV3NzYWU0eGhFbndmTEwxQUNB?= =?utf-8?B?QkVBNnFYZE1zcGZBUkJmZEVFL1JKd3VnZ002WnpHVTdwT2NuTno4bHZIL1ZL?= =?utf-8?B?K2tSNG5ObnI4VVhXejFCdCtwbkpJYnlJODZVZFBMenU3WTJIWUY5RGVRWm84?= =?utf-8?B?UlZNaFVqN1dDNmpJazI0bmVUY2JsMEFZREJxZGJJVW5qMVVhNUpXK3BDSkRm?= =?utf-8?B?M05hejlpSlFiTmhXYWliVDNybVhQbjVoaE1UMVA5dnNlMUdOeXpnRGRMYllY?= =?utf-8?B?c3NnWlBrY0JzUUQvOEtKTGJzVDhMQ2RvWmFHV3VmcXV5NU9rdVJSK01kWjNt?= =?utf-8?B?YUFoSlFDZGtiSVBPbFBjb0hBZFZYMGdDWXNXVzBBZFZzckRKWUJ0eWJxMlUw?= =?utf-8?B?dkZBOTRUMjQvNGlhN1kzMlZ2Nms1UUFncmQzUWhYUHhieVovSHRUdlpsekJx?= =?utf-8?B?QUIzRTg5UTNHa3ZRbGJaUG83QTRtWXRBUnFPOGR3MUsvWHprbE1iU0p2Nnlu?= =?utf-8?B?TUdwZVo4Zzh3TXFJY2lweWpxM1JXNzFGSTN6UStaYVJEYXN4Sm1UVHpJQnFr?= =?utf-8?B?dndnSDVJcDA5SFVoUGlMcXM0K0lDYmg4K3FkcExXSWdsTGswYUFEaTZtN0Jp?= =?utf-8?B?VnRDVkVIWlNzc3puZzBqdXBaRFlQMlozU0s4ak8zb1gvYWVPOCtTMVA2ZCtO?= =?utf-8?B?bitpRUJxaTVwTVA3TE9ieDBXSDFubUFGM21oRjlJcTVTVDRUVFFiTEIzbVdK?= =?utf-8?B?OG11WEN4R2VDZFc3SlJiczZDUTM5a0syRk9JcDc1akFUaHZiY1hCR3U1QXpa?= =?utf-8?B?Q3M2SG1JNVU4MGprdCtZd3hKYktjdksxRTJjUEwzM3pBbklqbzBEM2wwMTBw?= =?utf-8?Q?kKrwHol8pIk=3D?= X-Microsoft-Exchange-Diagnostics: 1;MWHPR07MB3549;6:Ycf5d0LeuBf9Wtk147s6XLhkIUSVLQk0limln6KuTy/tFMwvC/BTag0c0yIvgNWgmxW0ID8nq0AexeBvYZxRkzjZrzW5gB2MB9kHF45wJnoHr8oe4E6hEn0+0XpEmXFB1yKgJPblM7c+Ydh7ZGpRjqOlFMk0jU3zunEKuocYRXBDEnoDmayeN/tsK9WXCsyCu2RfC1jHz+cLybGakCvoGYW3l1hNlZbnBkf1T8VLd1G24pKjPfpHPPIdbvbUBSQUU1GhF2u/oVX6BbELieJkwzOWN6vOw7cH16gib4gctMj3eABlTX43QGXoBfQILsNl8GxcsGnEVAmzfMxRskdX3w==;5:6B1ot/IMR21SlkA75+I9KqodBTv5bbfvrkIRKs/rJ9hmadJ/xI4G4w5RB2mN/0Fnks9EZdbGGt4vn69nlQC7Zdom/zB3ubw93Km4yMD91HUhofuKFieU6b5oMkHWvn4Nd2x1eXqft2fvwXI7Ap/YhQ==;24:pFiFgU46zwGLu6iPhVgy/F/8BBOd6raPoj6S7/T/0TgwVxhIMFSAvAx+qHFj8+6TRPDqX+RB1ka0U5IyY3Mm6ZwXkKg9ehbaPVVqy1P+9Ck=;7:VnG1b2Bhn6CQPdQjrayZ7HSh+9kwHuNS19INUz+aKTOMNv7mAneYVSO28LIeRpfctZD8nHBhCuJHDSrn7E6B/virSx83aDQRWTA4fkm+hA+EjNmcclsFpeJWM0O7vOihC/TaK7UWomF5IHiVLfBog7xlyaa+os3SY2Hg3HgD1Bj1/NuAR5yUbdM6kS3ZJ2YfMz6qsQqc13MQHrAOvGxDud5ISwgzufM48EOUcHbslfo= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-OriginatorOrg: cavium.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 20 Sep 2017 23:36:46.8698 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 711e4ccf-2e9b-4bcf-a551-4094005b6194 X-MS-Exchange-Transport-CrossTenantHeadersStamped: MWHPR07MB3549 X-SW-Source: 2017-09/txt/msg01422.txt.bz2 On Tue, 2017-09-19 at 10:49 -0600, Martin Sebor wrote: > On 09/19/2017 09:54 AM, Steve Ellcey wrote: > > On Tue, 2017-09-19 at 09:50 +0200, Frédéric Marchal wrote: > > >  > > > > > > > >    error (is_pragma > > > >           ? G_("missing name in %<#pragma target\(\"%s=\")%>") > > > >           : G_("missing name in % > > > > attribute"), > > > >           "arch"); > > > > > > > > The additional benefit of this approach is that it would also make > > > > the quoting consistent with what seems to be the prevailing style > > > > of these sorts of messages.  (It would be nice to eventually > > > > converge on the same style/quoting and phrasing across all back > > > > and front ends.) > > > Indeed! That's even better as the message uses words the user sees in the > > > source code whatever his/her locale language is. So I am looking at redoing the error messages and I am trying to decide between two forms. Make pragma/attribute part of the non-translatable string by showing the pragma and/or attribute syntax ast it would be in the C/C++ code (what about Fortran or Ada?). error (is_pragma   ? G_("missing architecture name in %<#pragma GCC target (\"arch=string\")%>")   : G_("missing architecture name in %<__attribute__ ((target(\"arch=string\"))) %>")); Or include them in the part that does get translated and include less of what is actually in the text of the file being compiled. error (is_pragma   ? G_("missing architecture name in % pragma")   : G_("missing architecture name in % attribute")); Opinions? Steve Ellcey sellcey@cavium.com