public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Steve Ellcey <sellcey@cavium.com>
To: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>,
	Sudi Das	 <Sudi.Das@arm.com>,
	James Greenhalgh <James.Greenhalgh@arm.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	nd <nd@arm.com>, 	Marcus Shawcroft <Marcus.Shawcroft@arm.com>
Subject: Re: [PATCH][AArch64] Add BIC-imm and ORR-imm SIMD pattern
Date: Wed, 04 Oct 2017 23:05:00 -0000	[thread overview]
Message-ID: <1507158330.23982.4.camel@cavium.com> (raw)
In-Reply-To: <f3902e09-2622-faa3-6dfd-94924bde520a@arm.com>

On Wed, 2017-10-04 at 16:41 +0100, Richard Earnshaw (lists) wrote:
> On 02/10/17 10:05, Sudi Das wrote:
> > 
> > 2017-10-02 Sudakshina Das  <sudi.das@arm.com>
> > 
> > 	* config/aarch64/aarch64-protos.h (enum simd_immediate_check): New check type
> > 	for aarch64_simd_valid_immediate.
> > 	(aarch64_output_simd_mov_immediate): Update prototype.
> > 	(aarch64_simd_valid_immediate): Update prototype.
> > 
> > 	* config/aarch64/aarch64-simd.md (orr<mode>3): modified pattern to add
> > 	support for ORR-immediate.
> > 	(and<mode>3): modified pattern to add support for BIC-immediate.
> > 
> > 	* config/aarch64/aarch64.c (aarch64_simd_valid_immediate): Function now checks
> > 	for valid immediate for BIC and ORR based on new enum argument.
> > 	(aarch64_output_simd_mov_immediate): Function now used to output BIC/ORR imm
> > 	as well based on new enum argument.
> >  
> > 	* config/aarch64/constraints.md (Do): New vector immediate constraint.
> > 	(Db) : Likewise.
> > 
> > 	* config/aarch64/predicates.md (aarch64_reg_or_orr_imm): New
> > predicate.
> > 	(aarch64_reg_or_bic_imm): Likewise.

I think this patch is causing a bunch of test failures on aarch64.  I
had to apply the patch for PR82396 (that was reverted) in order to
build ToT GCC, but when I did that and ran the testsuite I got a bunch
of failures like:

/home/sellcey/cavium-pr-27386/src/gcc/gcc/testsuite/gcc.c-
torture/compile/pr54713-1.c:45:18: internal compiler error: in
aarch64_simd_valid_immediate, at config/aarch64/aarch64.c:11539
0xf2227b aarch64_simd_valid_immediate(rtx_def*, machine_mode, bool,
simd_immediate_info*, simd_immediate_check)
        ../../../src/gcc/gcc/config/aarch64/aarch64.c:11539
0x11047b3 aarch64_reg_or_bic_imm(rtx_def*, machine_mode)
        ../../../src/gcc/gcc/config/aarch64/predicates.md:79
0xab29ab insn_operand_matches(insn_code, unsigned int, rtx_def*)
        ../../../src/gcc/gcc/optabs.c:6891
0xab29ab maybe_legitimize_operand_same_code
        ../../../src/gcc/gcc/optabs.c:6919
0xab545f maybe_legitimize_operand
        ../../../src/gcc/gcc/optabs.c:6990
0xab545f maybe_legitimize_operands(insn_code, unsigned int, unsigned
int, expand_operand*)
        ../../../src/gcc/gcc/optabs.c:7055
0xab5a8f maybe_gen_insn(insn_code, unsigned int, expand_operand*)
        ../../../src/gcc/gcc/optabs.c:7073
0xab8503 expand_binop_directly
        ../../../src/gcc/gcc/optabs.c:1075
0xab87af expand_binop(machine_mode, optab_tag, rtx_def*, rtx_def*,
rtx_def*, int, optab_methods)
        ../../../src/gcc/gcc/optabs.c:1156
0x8736d7 expand_expr_real_2(separate_ops*, rtx_def*, machine_mode,
expand_modifier)
        ../../../src/gcc/gcc/expr.c:9582
0x749027 expand_gimple_stmt_1
        ../../../src/gcc/gcc/cfgexpand.c:3691
0x749027 expand_gimple_stmt
        ../../../src/gcc/gcc/cfgexpand.c:3751
0x750387 expand_gimple_basic_block
        ../../../src/gcc/gcc/cfgexpand.c:5750
0x751ef7 execute
        ../../../src/gcc/gcc/cfgexpand.c:6357

  reply	other threads:[~2017-10-04 23:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-18 16:51 Sudi Das
2017-05-05 13:38 ` Richard Earnshaw (lists)
2017-08-07 13:56   ` Sudi Das
2017-09-20 10:39     ` James Greenhalgh
2017-09-25 10:14       ` Sudi Das
2017-09-26 19:04         ` James Greenhalgh
2017-09-27 17:57           ` Sudi Das
2017-09-28  8:55             ` Richard Earnshaw (lists)
2017-10-02  9:05               ` Sudi Das
2017-10-04 15:41                 ` Richard Earnshaw (lists)
2017-10-04 23:05                   ` Steve Ellcey [this message]
2017-10-05 15:41                     ` Sudi Das

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1507158330.23982.4.camel@cavium.com \
    --to=sellcey@cavium.com \
    --cc=James.Greenhalgh@arm.com \
    --cc=Marcus.Shawcroft@arm.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=Sudi.Das@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).