From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64502 invoked by alias); 19 Oct 2017 17:27:36 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 64493 invoked by uid 89); 19 Oct 2017 17:27:36 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 19 Oct 2017 17:27:34 +0000 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6C3273E2D8; Thu, 19 Oct 2017 17:27:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 6C3273E2D8 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=dmalcolm@redhat.com Received: from ovpn-116-179.phx2.redhat.com (ovpn-116-179.phx2.redhat.com [10.3.116.179]) by smtp.corp.redhat.com (Postfix) with ESMTP id A0F2B61553; Thu, 19 Oct 2017 17:27:30 +0000 (UTC) Message-ID: <1508434050.17132.1.camel@redhat.com> Subject: Re: [committed] Add gnu::unique_ptr From: David Malcolm To: Gerald Pfeifer Cc: Pedro Alves , Richard Biener , gcc-patches@gcc.gnu.org, Trevor Saunders , Jonathan Wakely Date: Thu, 19 Oct 2017 17:41:00 -0000 In-Reply-To: References: <46f13850-b1bd-7ce4-e7a8-cd826d838966@redhat.com> <1508187336-32666-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg01291.txt.bz2 On Thu, 2017-10-19 at 19:23 +0200, Gerald Pfeifer wrote: > On Mon, 16 Oct 2017, David Malcolm wrote: > > For reference, here's what I committed: > > I'm afraid this may have broken the bootstrap with clang? > > In file included from /scratch/tmp/gerald/gcc-HEAD/gcc/unique-ptr- > tests.cc:23: > In file included from /scratch/tmp/gerald/gcc- > HEAD/gcc/../include/unique-ptr.h:77: > In file included from /usr/include/c++/v1/memory:629: > /usr/include/c++/v1/typeinfo:199:2: error: no member named > 'fancy_abort' in namespace 'std::__1'; did you mean simply > 'fancy_abort'? > _VSTD::abort(); > ^~~~~~~ > /usr/include/c++/v1/__config:390:15: note: expanded from macro > '_VSTD' > #define _VSTD std::_LIBCPP_NAMESPACE > ^ > /scratch/tmp/gerald/gcc-HEAD/gcc/system.h:725:13: note: 'fancy_abort' > declared here > extern void fancy_abort (const char *, int, const char *) > ^ > > > This is FreeBSD clang version 4.0.0 (tags/RELEASE_400/final 297347) > (based on LLVM 4.0.0), on x86_64-unknown-freebsd11.1. > > Gerald Sorry about the breakage. There seem to have been similar problems on OS X: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=82610 The proposed fix there is to include in system.h, which presumably would fix this also.