From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pl1-x634.google.com (mail-pl1-x634.google.com [IPv6:2607:f8b0:4864:20::634]) by sourceware.org (Postfix) with ESMTPS id 0D62E3858D20 for ; Mon, 12 Jun 2023 14:37:40 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0D62E3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-pl1-x634.google.com with SMTP id d9443c01a7336-1b3b3f67ad6so16888425ad.3 for ; Mon, 12 Jun 2023 07:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1686580659; x=1689172659; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Ip1/xy/XQBpeSeOsMcBJitfax7ySIBQ1DYLIsHoK/EY=; b=GlqpIN8n+IZh9USsN8K50mcMqy/Zhn14OUhu4KivAQiU6mYHMna8s1OjfBK9fLdP6o gIqo2V1MiiVyBHNvyj/11FLESht0pKtp9iSsiR/ROsrPe2eahtR3zzqaRMfN7aR7QS2H dnn/VlXqdLG8HvZa1WhNVwrIEJfpM400svNssqw+Ef6XO/oMo1YNHW4m1528ZbT3XIaZ yNjc+e6Y+i6sq718ulGmGD9thnuaCyl16tkOScHw/Yh+3+Qih0txR6sGojAaw/Jf70g+ CmPOx9QU3FGHGJuXYVBmWpc0saF+agwouT545ca7cScT21u4HhO9ddW/Z3l1cN0RPug8 8keg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1686580659; x=1689172659; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Ip1/xy/XQBpeSeOsMcBJitfax7ySIBQ1DYLIsHoK/EY=; b=ULbYfD2xdwpgiOnFFUPr6okhGP+LTQ5R6GVpK3KiBQP/UKg3xcrJd8F8LrC9qwBz13 0m9D/NIjU70R1uiK7j9r00C1MHZrrxoYyQPktdgrW0ojzzO6rr4oEVlQIB3+XxOG75/a 0ec6NV5+gHwY97X50pl/mTJIUg0N9xc9J8wbYeML9fRY2N9391Ve9lgYovS4mu3aysCX CTsprPKxrO+WU9ZPMLsuRwEdSwmZ+w41YUduCTlDUn8OIfTqPgoBKoO6tE9AoeHWhx8j DpPiDeeLpnvBWnudD40NOTNoTFt5c7g77r3u/Q1z2ffzs9c08vrXOrxDV3B0PBLtK21F /JlA== X-Gm-Message-State: AC+VfDxEB6ugdJ8X2HvgvZo7pEE/a2Aow975XS6+1nTBtLu0EphYIj84 JtyHz0Lwb6nmlLwx+v/gYN4= X-Google-Smtp-Source: ACHHUZ45KsdBmvu9bpNLJsXcE04JoSOeOmwEgR2MNh5IpgPEU01dvxhvYY9Awf7FCsX2buFPyei8ug== X-Received: by 2002:a17:903:18c:b0:1b2:4b28:793c with SMTP id z12-20020a170903018c00b001b24b28793cmr7639534plg.29.1686580658903; Mon, 12 Jun 2023 07:37:38 -0700 (PDT) Received: from [172.31.0.109] ([136.36.130.248]) by smtp.gmail.com with ESMTPSA id b16-20020a170902d51000b001af98dcf958sm8356377plg.288.2023.06.12.07.37.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Jun 2023 07:37:38 -0700 (PDT) Message-ID: <150a6cac-26d2-4d1a-c301-3770e707fe79@gmail.com> Date: Mon, 12 Jun 2023 08:37:36 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1 Subject: Re: [PATCH 1/2] Implementation of new RISCV optimizations pass: fold-mem-offsets. Content-Language: en-US To: Manolis Tsamis Cc: gcc-patches@gcc.gnu.org, Richard Biener , Palmer Dabbelt , Philipp Tomsich , Kito Cheng References: <20230525123550.1072506-1-manolis.tsamis@vrull.eu> <20230525123550.1072506-2-manolis.tsamis@vrull.eu> <91d71dae-b235-fbd0-c8f0-001b7f1e444c@gmail.com> From: Jeff Law In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-2.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,FREEMAIL_FROM,NICE_REPLY_A,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 6/12/23 01:36, Manolis Tsamis wrote: >> > > Even if late, one question for the dynamic instruction numbers. > Was this measured just with f-m-o or with the stack pointer fold patch > applied too? > I remember I was getting better improvements in the past, but most of > the cases had to do with the stack pointer so the second patch is > necessary. It was just the main f-m-o patch, so there'll be additional benefits with the ability to cprop the stack pointer. And even if we don't get measurable wins for something like mcf due to its memory bound nature, smaller, tighter code is always preferable. Jeff