From: Steve Ellcey <sellcey@cavium.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
Richard Earnshaw <Richard.Earnshaw@arm.com>,
Marcus Shawcroft <Marcus.Shawcroft@arm.com>,
James Greenhalgh <James.Greenhalgh@arm.com>
Subject: Re: [Patch][aarch64] Add missing thunderx2-t99 instruction scheduling pipeline descriptions.
Date: Mon, 04 Dec 2017 17:33:00 -0000 [thread overview]
Message-ID: <1512408817.14842.15.camel@cavium.com> (raw)
In-Reply-To: <5A258369.4090109@foss.arm.com>
On Mon, 2017-12-04 at 17:18 +0000, Kyrill Tkachov wrote:
> > +(define_insn_reservation "thunderx2t99_multiple" 1
> > +Â Â (and (eq_attr "tune" "thunderx2t99")
> > +Â Â Â Â Â Â Â (eq_attr "type" "multiple"))
> > +Â Â "thunderx2t99_i0+thunderx2t99_i1+thunderx2t99_i2+thunderx2t99_ls
> > 0+thunderx2t99_ls1+thunderx2t99_sd+thunderx2t99_i1m1+thunderx2t99_i
> > 1m2+thunderx2t99_i1m3+thunderx2t99_ls0d1+thunderx2t99_ls0d2+thunder
> > x2t99_ls0d3+thunderx2t99_ls1d1+thunderx2t99_ls1d2+thunderx2t99_ls1d
> > 3+thunderx2t99_f0+thunderx2t99_f1")
> > +
> We try to adhere to the 80 columns per line rule in the schedulingÂ
> description files as well,
> so can you please use "\" to break this into multiple lines.
Yes, I wasn't sure if whatever program parses this file would honor
backslashes so I didn't break it up. Â The falkor_extra definition in
falkor.md that I looked at is more than 80 characters and that is one
of the reasons I wasn't sure backslashes would be honored. Â But I see
other places (power8.md) where the backslashes are used so I will make
that change if and when the patch is approved.
Steve Ellcey
sellcey@cavium.com
next prev parent reply other threads:[~2017-12-04 17:33 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-12-01 18:42 Steve Ellcey
2017-12-04 17:18 ` Kyrill Tkachov
2017-12-04 17:33 ` Steve Ellcey [this message]
2017-12-05 14:39 ` James Greenhalgh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1512408817.14842.15.camel@cavium.com \
--to=sellcey@cavium.com \
--cc=James.Greenhalgh@arm.com \
--cc=Marcus.Shawcroft@arm.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).