* [PATCH rs6000] Fix for builtins-4-int128-runnable.c
@ 2018-02-14 19:09 Carl Love
2018-02-14 20:14 ` Peter Bergner
2018-02-14 20:52 ` Segher Boessenkool
0 siblings, 2 replies; 3+ messages in thread
From: Carl Love @ 2018-02-14 19:09 UTC (permalink / raw)
To: gcc-patches, David Edelsohn, Segher Boessenkool; +Cc: Bill Schmidt, cel
GCC maintainers:
The following patch contains fixes an issue with the 128-bit test on
Power 7. Power 7 does not support int128 so the test must be
restricted to run on Power 8 and later.
The change was tested by hand on a Power 8 machine with the command:
make -k check-gcc RUNTESTFLAGS="--target_board=unix'{-mcpu=power7}'
powerpc.exp=builtins-4-int128-runnable.c"Â
to verify the test passes cleanly with the change in the dg directives.
Please let me know if the patch is OK for trunk. Thanks.
Carl Love
--------------------------------------------
2018-02-14 Carl Love <cel@us.ibm.com>
* gcc.target/powerpc/builtins-4-int128-runnable.c (dg-require-effective-target):
Change vsx_hw to p8vector_hw.
(dg-options): Change -maltivec -mvsx to -mpower8-vector.
---
gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c b/gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c
index 162e267..4f4e7a9 100644
--- a/gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c
+++ b/gcc/testsuite/gcc.target/powerpc/builtins-4-int128-runnable.c
@@ -1,7 +1,7 @@
/* { dg-do run } */
/* { dg-require-effective-target int128 } */
-/* { dg-require-effective-target vsx_hw } */
-/* { dg-options "-maltivec -mvsx" } */
+/* { dg-require-effective-target p8vector_hw } */
+/* { dg-options "-mpower8-vector" } */
#include <inttypes.h>
#include <altivec.h> // vector
--
2.7.4
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH rs6000] Fix for builtins-4-int128-runnable.c
2018-02-14 19:09 [PATCH rs6000] Fix for builtins-4-int128-runnable.c Carl Love
@ 2018-02-14 20:14 ` Peter Bergner
2018-02-14 20:52 ` Segher Boessenkool
1 sibling, 0 replies; 3+ messages in thread
From: Peter Bergner @ 2018-02-14 20:14 UTC (permalink / raw)
To: Carl Love; +Cc: gcc-patches, David Edelsohn, Segher Boessenkool, Bill Schmidt
On 2/14/18 1:09 PM, Carl Love wrote:
> The following patch contains fixes an issue with the 128-bit test on
> Power 7. Power 7 does not support int128 so the test must be
> restricted to run on Power 8 and later.
To be pedantic, GCC POWER7 supports __int128_t just fine (in 64-bit mode).
It however does not support vector __int128_t which is what we're testing
here.
Peter
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH rs6000] Fix for builtins-4-int128-runnable.c
2018-02-14 19:09 [PATCH rs6000] Fix for builtins-4-int128-runnable.c Carl Love
2018-02-14 20:14 ` Peter Bergner
@ 2018-02-14 20:52 ` Segher Boessenkool
1 sibling, 0 replies; 3+ messages in thread
From: Segher Boessenkool @ 2018-02-14 20:52 UTC (permalink / raw)
To: Carl Love; +Cc: gcc-patches, David Edelsohn, Bill Schmidt
Hi Carl,
On Wed, Feb 14, 2018 at 11:09:09AM -0800, Carl Love wrote:
> The following patch contains fixes an issue with the 128-bit test on
> Power 7. Power 7 does not support int128 so the test must be
> restricted to run on Power 8 and later.
> 2018-02-14 Carl Love <cel@us.ibm.com>
(blank line here)
> * gcc.target/powerpc/builtins-4-int128-runnable.c (dg-require-effective-target):
Line too long. You can put the ( at the start of a new line.
> Change vsx_hw to p8vector_hw.
> (dg-options): Change -maltivec -mvsx to -mpower8-vector.
Otherwise fine, thanks! Okay for trunk.
Segher
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-02-14 20:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-02-14 19:09 [PATCH rs6000] Fix for builtins-4-int128-runnable.c Carl Love
2018-02-14 20:14 ` Peter Bergner
2018-02-14 20:52 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).