From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18754 invoked by alias); 24 Sep 2018 16:37:43 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 18743 invoked by uid 89); 24 Sep 2018 16:37:42 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-6.2 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,GIT_PATCH_1,KAM_NUMSUBJECT,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=HX-Received:a37, HX-Received:sk:l15-v6m, Hx-languages-length:2061, H*Ad:U*msebor X-HELO: mail-qk1-f193.google.com Received: from mail-qk1-f193.google.com (HELO mail-qk1-f193.google.com) (209.85.222.193) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 24 Sep 2018 16:37:40 +0000 Received: by mail-qk1-f193.google.com with SMTP id c126-v6so11750098qkd.7 for ; Mon, 24 Sep 2018 09:37:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:references:cc:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding; bh=/AAcTe2EQmh3qyRrNNXHnDRsf7tN+QVbK4JsVg7WHbA=; b=Px+UD+oJQ7rPBwDhlK7+XfPcCB3vhNmwJgK8vQ3vkfDpMn6L9rekgoCRxksk1Wgr0M dwfo5iJtNsyebVJjGLkpg5LQI8gpumnNKoJStuHhvC4/7WxeU+//AGAafR+DfNebDxOZ BkuiI7HKVWwpA7n2dOM2drdrAEXO6GdOKWihnc2qmYezxzRMbPIxBmmNDt6e1JlMo0K2 K5w7cXRbC4YTESGLH0Pjnw92n1HebaGFVyPjT/OA38wlda+ob5jyvdVeZE3HFw9Z4Be4 lgB4cr1Jep93veicoTIv6z3IJY7e5DlrflmdNdrfbFD7x+ETQgE6X9cd60Pe9z9dPxvL DNcg== Return-Path: Received: from localhost.localdomain (97-118-105-75.hlrn.qwest.net. [97.118.105.75]) by smtp.gmail.com with ESMTPSA id w6-v6sm9458047qtk.9.2018.09.24.09.37.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 24 Sep 2018 09:37:37 -0700 (PDT) Subject: Re: [PATCH] PR86957 To: Indu Bhagat , =?UTF-8?Q?Martin_Li=c5=a1ka?= References: <6a2ea403-22c3-91f6-f826-29e186f21b91@suse.cz> <159a29c5-8f8b-4194-dbea-1c9bd414db3a@oracle.com> <7ed25f0a-10a8-3eca-c032-29e76054bfb6@suse.cz> <20180917105249.GA49438@kam.mff.cuni.cz> Cc: gcc-patches@gcc.gnu.org From: Martin Sebor Message-ID: <15203968-8ae2-9da8-0c14-83ed1ebbb907@gmail.com> Date: Mon, 24 Sep 2018 16:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=iso-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg01354.txt.bz2 On 09/21/2018 05:27 PM, Indu Bhagat wrote: > Attached is the refreshed patch for trunk. > > After commit 264462 (Remove arc profile histogram in non-LTO mode.), the > API > of get_coverage_counts was changed a bit. So the main difference between > the > current version of my patch from the previous one is that : > > Now I use > + if (counter == GCOV_COUNTER_ARCS) > + warning_at (DECL_SOURCE_LOCATION (current_function_decl), > + OPT_Wmissing_profile, > + "profile for function %qD not found in profile data", > + current_function_decl); > > instead of > + if (summary) > + warning_at (DECL_SOURCE_LOCATION (current_function_decl), > + OPT_Wmissing_profile, > + "profile for function %qD not found in profile data", > + current_function_decl); > > to warn about missing profile of a function only once > (get_coverage_counts is > called from two diff flows : getting exec counts for arc counter and > computing > histogram for other other counters) > > I am not sure of any better way to avoid superfluous warnings per function. > > Is the patch OK ? > In the text below: @@ -4823,6 +4823,23 @@ This warning is enabled by @option{-Wall}. @opindex Wno-missing-include-dirs Warn if a user-supplied include directory does not exist. +@item -Wmissing-profile +@opindex Wmissing-profile +@opindex Wno-missing-profile +Warn if feedback profiles are missing when using the +@option{-fprofile-use} option. +This option diagnoses those cases where a new function or a new file is added +to the user code between compiling with @option{-fprofile-generate} and with +@option{-fprofile-use}, without regenerating the profiles. In these cases, the +profile feedback data files do not contain any profile feedback information for +the newly added function or file respectively. Also, in the case when profile +count data (.gcda) files are wiped out, GCC cannot use any profile feedback +information. I would suggest to use the term "remove" or "delete" instead of the informal "wipe out" when referring to removing files or their contents. Martin