From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5327 invoked by alias); 11 Jul 2014 09:06:18 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5314 invoked by uid 89); 11 Jul 2014 09:06:17 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Jul 2014 09:06:16 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 2AD98290B8BE; Fri, 11 Jul 2014 11:06:13 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 1UhGQ0p3yU3Y; Fri, 11 Jul 2014 11:06:13 +0200 (CEST) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 1308C290B8B9; Fri, 11 Jul 2014 11:06:13 +0200 (CEST) From: Eric Botcazou To: DJ Delorie Cc: gcc-patches@gcc.gnu.org Subject: Re: [patch 1/4] change specific int128 -> generic intN Date: Fri, 11 Jul 2014 09:06:00 -0000 Message-ID: <1528221.6ADjPgnoBP@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.29-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: <201407101634.s6AGYm4o019679@greed.delorie.com> References: <201404142303.s3EN3ONP009938@greed.delorie.com> <1878297.97iUzkpC0g@polaris> <201407101634.s6AGYm4o019679@greed.delorie.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2014-07/txt/msg00768.txt.bz2 > PSImode is 20 bits, fits in a 20 bit register, and uses 20 bit operations. Then why do you need this change? > - TYPE_SIZE (type) = bitsize_int (GET_MODE_BITSIZE (TYPE_MODE (type))); > + TYPE_SIZE (type) = bitsize_int (GET_MODE_PRECISION (TYPE_MODE > (type))); TYPE_SIZE_UNIT (type) = size_int (GET_MODE_SIZE (TYPE_MODE > (type))); break; What are GET_MODE_BITSIZE and GET_MODE_PRECISION for PSImode? > If a type is 17-20 bits, PSImode is chosen. If it's 21 bits or > larger, SImode is chosen. If it's 16 or fewer bits, HImode is chosen. Size or precision? That's the crux of the matter. -- Eric Botcazou