public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Martin Sebor <msebor@gmail.com>
To: Marek Polacek <polacek@redhat.com>, Jason Merrill <jason@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)
Date: Fri, 30 Sep 2016 17:22:00 -0000	[thread overview]
Message-ID: <15342189-351a-5655-42b3-9ad32667ec90@gmail.com> (raw)
In-Reply-To: <20160930164337.GE3223@redhat.com>

> +		permerror (input_location, "ISO C++11 only allows pointer "
> +			   "conversions for integer literals");

FWIW, I think it would be clearer to either mention the currently
selected language version or leave it out completely rather than
hardcoding C++11.  When the user specifies -std=c++14 (or later),
or when that's the current version used by the compiler, a warning
that tells them what C++ 11 allows isn't really relevant (or
meaningful), and becomes less so as time goes on.

Martin

  reply	other threads:[~2016-09-30 17:05 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-10 15:06 Marek Polacek
2016-09-10 15:13 ` Jakub Jelinek
2016-09-10 15:48   ` Marek Polacek
2016-09-14  5:56 ` Jason Merrill
2016-09-15 12:31   ` Marek Polacek
2016-09-19 19:51     ` Jason Merrill
2016-09-21 19:55       ` Jason Merrill
2016-09-23 13:29         ` Marek Polacek
2016-09-23 14:37           ` Jason Merrill
2016-09-30 16:52             ` Marek Polacek
2016-09-30 17:22               ` Martin Sebor [this message]
2016-09-30 19:52                 ` Martin Sebor
2016-09-30 20:02                   ` Marek Polacek
2016-09-30 22:16                     ` Martin Sebor
2016-09-30 22:16               ` Jason Merrill
2016-10-01 14:41                 ` Marek Polacek
2016-10-02 18:43                   ` Jason Merrill
2017-01-04  6:56                     ` Eric Gallager

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15342189-351a-5655-42b3-9ad32667ec90@gmail.com \
    --to=msebor@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    --cc=polacek@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).