From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 103046 invoked by alias); 28 Aug 2018 14:19:51 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 102286 invoked by uid 89); 28 Aug 2018 14:19:50 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 28 Aug 2018 14:19:49 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A294E308FC53; Tue, 28 Aug 2018 14:19:47 +0000 (UTC) Received: from ovpn-116-201.phx2.redhat.com (ovpn-116-201.phx2.redhat.com [10.3.116.201]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8702F60927; Tue, 28 Aug 2018 14:19:45 +0000 (UTC) Message-ID: <1535465983.6963.97.camel@redhat.com> Subject: Re: [PATCH] Fix version check for ATTRIBUTE_GCC_DUMP_PRINTF From: David Malcolm To: Jakub Jelinek Cc: Joseph Myers , Richard Biener , GCC Patches Date: Tue, 28 Aug 2018 14:19:00 -0000 In-Reply-To: <20180828122626.GO2218@tucnak> References: <20180827065751.GB2218@tucnak> <1535416331-352-1-git-send-email-dmalcolm@redhat.com> <20180828064359.GM2218@tucnak> <20180828122626.GO2218@tucnak> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg01774.txt.bz2 On Tue, 2018-08-28 at 14:26 +0200, Jakub Jelinek wrote: > On Tue, Aug 28, 2018 at 08:43:59AM +0200, Jakub Jelinek wrote: > > On Mon, Aug 27, 2018 at 08:32:11PM -0400, David Malcolm wrote: > > > gcc/ChangeLog: > > > * dumpfile.h (ATTRIBUTE_GCC_DUMP_PRINTF): Change version check > > > on > > > GCC_VERSION for usage of "__gcc_dump_printf__" format from > > > >= 3005 to >= 9000. > > > > Ok, thanks. > > Another option would be to use __gcc_tdiag__ for GCC_VERSION >= 3005 > and < > 9000, that differs from __gcc_dump_printf__ only in %E (tree vs. > gimple *) > and %D/%F/%V/%K added to __gcc_tdiag__, so worst case one would get a > couple > of rare warnings when %E is used somewhere; certainly better than > having a > warning on every TU that includes dumpfile.h. Maybe, but I think that trying to decipher warnings based on something that's close to the rules but not the same as them could get confusing (especially if we add some new codes to __gcc_dump_printf__). I've gone ahead with the simpler fix, as posted above, to stop the flood of warnings (r263920). Sorry again. Dave