From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108778 invoked by alias); 1 Oct 2018 14:13:29 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108743 invoked by uid 89); 1 Oct 2018 14:13:25 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=strips X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 01 Oct 2018 14:13:23 +0000 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 67D8E307C714; Mon, 1 Oct 2018 14:13:22 +0000 (UTC) Received: from ovpn-116-164.phx2.redhat.com (ovpn-116-164.phx2.redhat.com [10.3.116.164]) by smtp.corp.redhat.com (Postfix) with ESMTP id 039DD1001F41; Mon, 1 Oct 2018 14:13:21 +0000 (UTC) Message-ID: <1538403201.14521.58.camel@redhat.com> Subject: Re: [PATCH] dumpfile.c: use prefixes other that 'note: ' for MSG_{OPTIMIZED_LOCATIONS|MISSED_OPTIMIZATION} From: David Malcolm To: Andreas Schwab Cc: gcc-patches@gcc.gnu.org Date: Mon, 01 Oct 2018 14:20:00 -0000 In-Reply-To: <87in2onebi.fsf@igel.home> References: <1537905614-44303-1-git-send-email-dmalcolm@redhat.com> <87in2onebi.fsf@igel.home> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-10/txt/msg00033.txt.bz2 On Sun, 2018-09-30 at 00:12 +0200, Andreas Schwab wrote: > That produces extra output that breaks a few tests. > > g++.dg/vect/pr33426-ivdep-2.cc -std=c++11 (test for excess errors) > g++.dg/vect/pr33426-ivdep-2.cc -std=c++14 (test for excess errors) > g++.dg/vect/pr33426-ivdep-2.cc -std=c++98 (test for excess errors) > g++.dg/vect/pr33426-ivdep-3.cc (test for excess errors) > g++.dg/vect/pr33426-ivdep-4.cc (test for excess errors) > g++.dg/vect/pr33426-ivdep.cc -std=c++11 (test for excess errors) > g++.dg/vect/pr33426-ivdep.cc -std=c++14 (test for excess errors) > g++.dg/vect/pr33426-ivdep.cc -std=c++98 (test for excess errors) > gcc.dg/vect/nodump-vect-opt-info-1.c (test for excess errors) > gcc.dg/vect/vect-ivdep-1.c (test for excess errors) > gcc.dg/vect/vect-ivdep-1.c -flto -ffat-lto-objects (test for excess > errors) > gcc.dg/vect/vect-ivdep-2.c (test for excess errors) > gcc.dg/vect/vect-ivdep-2.c -flto -ffat-lto-objects (test for excess > errors) > > FAIL: gcc.dg/vect/vect-ivdep-1.c (test for excess errors) > Excess errors: > /usr/local/gcc/gcc-20180929/gcc/testsuite/gcc.dg/vect/vect-ivdep- > 1.c:11:3: optimized: loop versioned for vectorization to enhance > alignment Thanks for the report; sorry about the breakage. What target is this for? I'm not seeing these issues on x86_64-pc- linux-gnu. I think that what's happening is that my patch changed various existing dump messages from -fopt-info from being "note: " to being "optimized: " or "missed: ". gcc/testsuite/lib/prune.exp has: # Ignore informational notes. regsub -all "(^|\n)\[^\n\]*: note: \[^\n\]*" $text "" text which strips out all notes after dg-message directives have been checked. Presumably these pre-existing "note: " dump messages were being ignored, and are no longer matching that pattern. I can see two approaches to fixing this: (a) extend those lines in prune.exp to also ignore "optimized: " and "missed: " (b) figure out the criteria for when these messages appear, and add new dg-optimized and dg-missed directives to the tests in questions, with suitable filters. Is there a link to the .log files somewhere so I can see the precise messages in question? (e.g. are they all "loop versioned for vectorization to enhance alignment"?). Thanks, and sorry again about the breakage. Dave