public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jeff Law <law@redhat.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>,
	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Cc: mjambor@suse.cz
Subject: Re: [PATCH] Fix gcc.dg/warn-abs-1.c for arm and aarch64-none-elf
Date: Tue, 18 Sep 2018 14:00:00 -0000	[thread overview]
Message-ID: <153a7941-730d-98bb-f93d-b66126f32c57@redhat.com> (raw)
In-Reply-To: <5BA10193.4060101@foss.arm.com>

On 9/18/18 7:45 AM, Kyrill Tkachov wrote:
> Hi all,
> 
> This new test has some difficulties on the fabsl function.
> On arm this is because we don't support the _Float128 type which the
> test uses.
> This is handled in the patch by requiring a float128 target selector.
> 
> On aarch64-none-elf, a Newlib target, it fails because fabsl is not
> available.
> long double support is known to be incomplete in newlib, and the fabsl
> function is not available
> for targets where long double is larger than a double.
> Therefore this patch skips the test on such targets.
> 
> Ok for trunk?
> 
> Thanks,
> Kyrill
> 
> 2018-09-18  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
>     * gcc.dg/warn-abs-1.c: Require float128 target.
>     Skip if large_long_double newlib target.

OK
jeff

  reply	other threads:[~2018-09-18 13:51 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-09-18 13:50 Kyrill Tkachov
2018-09-18 14:00 ` Jeff Law [this message]
2018-09-18 14:04 ` Rainer Orth
2018-09-18 14:19   ` Kyrill Tkachov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=153a7941-730d-98bb-f93d-b66126f32c57@redhat.com \
    --to=law@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=kyrylo.tkachov@foss.arm.com \
    --cc=mjambor@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).