From: David Malcolm <dmalcolm@redhat.com>
To: Kyrill Tkachov <kyrylo.tkachov@foss.arm.com>
Cc: Jeff Law <law@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
David Malcolm <dmalcolm@redhat.com>
Subject: [PATCH] Add missing ZLIBINC to CFLAGS-optinfo-emit-json.o
Date: Tue, 13 Nov 2018 18:45:00 -0000 [thread overview]
Message-ID: <1542134724-27842-1-git-send-email-dmalcolm@redhat.com> (raw)
In-Reply-To: <5BEB10B5.9060003@foss.arm.com>
On Tue, 2018-11-13 at 17:58 +0000, Kyrill Tkachov wrote:
> Hi David,
>
> On 09/11/18 21:00, Jeff Law wrote:
> > On 11/9/18 10:51 AM, David Malcolm wrote:
> > > One of the concerns noted at Cauldron about -fsave-optimization-
> > > record
> > > was the size of the output files.
> > >
> > > This file implements compression of the -fsave-optimization-
> > > record
> > > output, using zlib.
> > >
> > > I did some before/after testing of this patch, using SPEC 2017's
> > > 502.gcc_r with -O3, looking at the sizes of the generated
> > > FILENAME.opt-record.json[.gz] files.
> > >
> > > The largest file was for insn-attrtab.c:
> > > before: 171736285 bytes (164M)
> > > after: 5304015 bytes (5.1M)
> > >
> > > Smallest file was for vasprintf.c:
> > > before: 30567 bytes
> > > after: 4485 bytes
> > >
> > > Median file by size before was lambda-mat.c:
> > > before: 2266738 bytes (2.2M)
> > > after: 75988 bytes (15K)
> > >
> > > Total of all files in the benchmark:
> > > before: 2041720713 bytes (1.9G)
> > > after: 66870770 bytes (63.8M)
> > >
> > > ...so clearly compression is a big win in terms of file size, at
> > > the
> > > cost of making the files slightly more awkward to work with. [1]
> > > I also wonder if we want to support any pre-filtering of the
> > > output
> > > (FWIW roughly half of the biggest file seems to be "Adding assert
> > > for "
> > > messages from tree-vrp.c).
> > >
> > > Successfully bootstrapped & regrtested on x86_64-pc-linux-gnu.
> > >
> > > OK for trunk?
> > >
>
> So does this now add a dependency on zlib?
> I can't build GCC on my aarch64-none-linux machine after this patch
> due to a missing zlib.h.
> I see there's a zlib in the top-level GCC tree. Is that build/used
> during the GCC build itself?
>
> Thanks,
> Kyrill
Sorry about that. Does the following patch fix the build for you?
gcc/ChangeLog:
* Makefile.in (CFLAGS-optinfo-emit-json.o): Add $(ZLIBINC).
---
gcc/Makefile.in | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 16c9ed6..1e8a311 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2233,7 +2233,7 @@ s-bversion: BASE-VER
$(STAMP) s-bversion
CFLAGS-toplev.o += -DTARGET_NAME=\"$(target_noncanonical)\"
-CFLAGS-optinfo-emit-json.o += -DTARGET_NAME=\"$(target_noncanonical)\"
+CFLAGS-optinfo-emit-json.o += -DTARGET_NAME=\"$(target_noncanonical)\" $(ZLIBINC)
pass-instances.def: $(srcdir)/passes.def $(PASSES_EXTRA) \
$(srcdir)/gen-pass-instances.awk
--
1.8.5.3
next prev parent reply other threads:[~2018-11-13 18:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-11-09 17:04 [PATCH] -fsave-optimization-record: compress the output using zlib David Malcolm
2018-11-09 21:00 ` Jeff Law
2018-11-13 17:58 ` Kyrill Tkachov
2018-11-13 18:45 ` David Malcolm [this message]
2018-11-14 9:49 ` [PATCH] Add missing ZLIBINC to CFLAGS-optinfo-emit-json.o Kyrill Tkachov
2018-11-14 19:02 ` David Malcolm
2018-11-13 18:28 David Malcolm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1542134724-27842-1-git-send-email-dmalcolm@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=kyrylo.tkachov@foss.arm.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).