From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44702 invoked by alias); 27 Nov 2018 16:07:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 44407 invoked by uid 89); 27 Nov 2018 16:07:40 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=patience X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 27 Nov 2018 16:07:38 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 468633DBCA; Tue, 27 Nov 2018 16:07:37 +0000 (UTC) Received: from ovpn-116-138.phx2.redhat.com (ovpn-116-138.phx2.redhat.com [10.3.116.138]) by smtp.corp.redhat.com (Postfix) with ESMTP id D2AA3608C1; Tue, 27 Nov 2018 16:07:36 +0000 (UTC) Message-ID: <1543334856.4619.107.camel@redhat.com> Subject: Re: [PATCH v5 1/3] PR preprocessor/83173: Additional check before decrementing highest_location From: David Malcolm To: Mike Gulick , gcc-patches@gcc.gnu.org Date: Tue, 27 Nov 2018 16:07:00 -0000 In-Reply-To: <20181127145304.228046-1-mgulick@mathworks.com> References: <1543329772.4619.104.camel@redhat.com> <20181127145304.228046-1-mgulick@mathworks.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2018-11/txt/msg02205.txt.bz2 On Tue, 2018-11-27 at 09:53 -0500, Mike Gulick wrote: > 2018-11-27 Mike Gulick > > PR preprocessor/83173 > * libcpp/files.c (_cpp_stack_include): Check if > line_table->highest_location is past current line before > decrementing. I've committed these patches to trunk as r266516, r266518, and r266520 respectively. Thanks for all your work on this (and your patience; sorry about the delays in reviewing it) Dave