public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@adacore.com>
To: Sebastian Huber <sebastian.huber@embedded-brains.de>
Cc: gcc-patches@gcc.gnu.org, Daniel Hellstrom <daniel@gaisler.com>,
	Joel Sherrill <Joel.Sherrill@oarcorp.com>
Subject: Re: [PATCH] RTEMS: Add LEON3/SPARC multilibs
Date: Sat, 23 Nov 2013 09:48:00 -0000	[thread overview]
Message-ID: <1548770.1XdPKFFHk2@polaris> (raw)
In-Reply-To: <528B51FF.1070204@embedded-brains.de>

> I back ported your list of changes from mainline to GCC 4.8.  See the
> attached patches.  In addition to your proposed changes I had to add
> 
> 2013-04-10  Steven Bosscher  <steven@gcc.gnu.org>
> 
>         * config/sparc/sparc.c: Include tree-pass.h.
>         (TARGET_MACHINE_DEPENDENT_REORG): Do not redefine.
>         (sparc_reorg): Rename to sparc_do_work_around_errata.  Move to
>         head of file.  Change return type.  Split off gate function.
>         (sparc_gate_work_around_errata): New function.
>         (pass_work_around_errata): New pass definition.
>         (insert_pass_work_around_errata) New pass insert definition to
>         insert pass_work_around_errata just after delayed-branch scheduling.
> (sparc_option_override): Insert the pass.
>         * config/sparc/t-sparc (sparc.o): Add TREE_PASS_H dependence.
> 
> This was necessary for
> 
> 2013-07-22  Eric Botcazou  <ebotcazou@adacore.com>
> 
> 	* config.gcc (sparc*-*-*): Accept leon3 processor.
> 	(sparc-leon*-*): Merge with sparc*-*-* and add leon3 support.
> 	* doc/invoke.texi (SPARC Options): Adjust -mfix-ut699 entry.
> 	* config/sparc/sparc-opts.h (enum processor_type): Add PROCESSOR_LEON3.
> 	* config/sparc/sparc.opt (enum processor_type): Add leon3.
> 	(mfix-ut699): Adjust comment.
> 	* config/sparc/sparc.h (TARGET_CPU_leon3): New define.
> 	(CPP_CPU32_DEFAULT_SPEC): Add leon3 support.
> 	(CPP_CPU_SPEC): Likewise.
> 	(ASM_CPU_SPEC): Likewise.
> 	* config/sparc/sparc.c (leon3_cost): New constant.
> 	(sparc_option_override): Add leon3 support.
> 	(mem_ref): New function.
> 	(sparc_gate_work_around_errata): Return true if -mfix-ut699 is enabled.
> 	(sparc_do_work_around_errata): Look into the instruction in the delay
> 	slot and adjust accordingly.  Add fix for the data cache nullify issues
> 	of the UT699.  Change insertion position for the NOP.
> 	* config/sparc/leon.md (leon_fpalu, leon_fpmds, write_buf): Delete.
> 	(leon3_load): New reservation.
> 	(leon_store): Bump latency to 2.
> 	(grfpu): New automaton.
> 	(grfpu_alu): New unit.
> 	(grfpu_ds): Likewise.
> 	(leon_fp_alu): Adjust.
> 	(leon_fp_mult): Delete.
> 	(leon_fp_div): Split into leon_fp_divs and leon_fp_divd.
> 	(leon_fp_sqrt): Split into leon_fp_sqrts and leon_fp_sqrtd.
> 	* config/sparc/sparc.md (cpu): Add leon3.
> 	* config/sparc/sync.md (atomic_exchangesi): Disable if -mfix-ut699.
> 	(swapsi): Likewise.
> 	(atomic_test_and_set): Likewise.
> 	(ldstub): Likewise.
> 
> I cannot judge if this was good or bad.  I can only perform mechanical
> changes since I don't know how the compiler works.
> 
> I run the GCC test suite on the GDB SIS with RTEMS, but its hard for me to
> interpret the results.  I think there are no new test failures due to the
> back ports.

Everything is clean on SPARC/Solaris and SPARC64/Solaris as well so I have no 
objections to backporting the whole set from a SPARC maintainership viewpoint
(and we have been using something equivalent at AdaCore for some time without 
any problems so far).  But we need the blessing of the RMs I guess here.

-- 
Eric Botcazou

  reply	other threads:[~2013-11-22 22:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-29 11:17 Sebastian Huber
2013-08-30 12:06 ` Daniel Hellstrom
2013-09-17 18:44   ` Joel Sherrill
2013-09-18 18:30     ` Ralf Corsépius
2013-09-19  8:45       ` Sebastian Huber
2013-09-19  8:50         ` Eric Botcazou
2013-09-19  8:57           ` Sebastian Huber
2013-11-19 12:42           ` Sebastian Huber
2013-11-23  9:48             ` Eric Botcazou [this message]
2013-11-24 19:59               ` Eric Botcazou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1548770.1XdPKFFHk2@polaris \
    --to=ebotcazou@adacore.com \
    --cc=Joel.Sherrill@oarcorp.com \
    --cc=daniel@gaisler.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=sebastian.huber@embedded-brains.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).