From: David Malcolm <dmalcolm@redhat.com>
To: Qing Zhao <qing.zhao@oracle.com>,
Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
Cc: gcc Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH][Preprocessor]patch to fix PR 90581
Date: Thu, 30 May 2019 20:42:00 -0000 [thread overview]
Message-ID: <1559248684.2997.156.camel@redhat.com> (raw)
In-Reply-To: <6E77B3DB-A2D1-48EB-9CDF-5225135AB3BE@oracle.com>
On Thu, 2019-05-30 at 15:17 -0500, Qing Zhao wrote:
> > On May 30, 2019, at 2:13 PM, Bernhard Reutner-Fischer <rep.dot.nop@
> > gmail.com> wrote:
> >
> > On 30 May 2019 18:23:43 CEST, Qing Zhao <qing.zhao@oracle.com>
> > wrote:
> > > Hi,
> > >
> > > PR 90581 (provide an option to adjust the maximum depth of nested
> > > #include)
> > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=90581
> > >
> > > is to add a new cpp option -fmax-inlcude-depth
> >
> > Typo inl vs inc.
>
> Okay, will fix this.
>
> >
> > Why isn't this a param?
>
> do you mean to change â-fmax-include-depth=â to â-param max-include-
> depth=â?
>
That sounds like a good idea to me.
> > Wouldn't a param ease range checking not to overflow the uint max
> > and maybe automagically provide diagnostics for out of range input?
(indeed)
next prev parent reply other threads:[~2019-05-30 20:38 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-30 16:26 Qing Zhao
2019-05-30 19:20 ` Bernhard Reutner-Fischer
2019-05-30 20:35 ` Qing Zhao
2019-05-30 20:42 ` David Malcolm [this message]
2019-05-30 20:46 ` Qing Zhao
2019-05-30 20:49 ` David Malcolm
2019-05-30 21:05 ` Qing Zhao
2019-05-31 9:01 ` Richard Biener
2019-06-03 14:49 ` [PATCH][Preprocessor][Version 2]patch " Qing Zhao
2019-06-03 15:03 ` Paolo Carlini
2019-06-03 16:42 ` [PATCH][Preprocessor][Version 3]patch " Qing Zhao
2019-06-03 16:46 ` Qing Zhao
2019-06-07 8:26 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1559248684.2997.156.camel@redhat.com \
--to=dmalcolm@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=qing.zhao@oracle.com \
--cc=rep.dot.nop@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).