From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21632 invoked by alias); 11 Jul 2014 09:17:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 21614 invoked by uid 89); 11 Jul 2014 09:17:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00 autolearn=ham version=3.3.2 X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 11 Jul 2014 09:17:46 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 91D70290B99F; Fri, 11 Jul 2014 11:17:43 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id lMrqXG4cK3V2; Fri, 11 Jul 2014 11:17:43 +0200 (CEST) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 28E5E290B891; Fri, 11 Jul 2014 11:17:43 +0200 (CEST) From: Eric Botcazou To: Daniel Cederman Cc: gcc-patches@gcc.gnu.org, Software Subject: Re: [PATCH] Generate more efficient memory barriers for LEON3 Date: Fri, 11 Jul 2014 09:17:00 -0000 Message-ID: <15616175.35bbqlivPE@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.29-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: <53BF985F.3040307@gaisler.com> References: <53AAB0AF.5060802@gaisler.com> <8335833.LQKX1h2mvF@polaris> <53BF985F.3040307@gaisler.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2014-07/txt/msg00773.txt.bz2 > The full barrier pattern membar_leon3 also gets generated so I think > that one should be kept also. Do you have a testcase? membar is generated by sparc_emit_membar_for_model and, for the TSO model of LEON3, implied = StoreStore | LoadLoad | LoadStore so mm can only be StoreLoad, which means that membar_storeload will match so the full barrier never will. -- Eric Botcazou