* 3.3 PATCH: Sort libjava test sources
@ 2002-07-17 9:57 Rainer Orth
2002-07-18 11:01 ` Tom Tromey
0 siblings, 1 reply; 2+ messages in thread
From: Rainer Orth @ 2002-07-17 9:57 UTC (permalink / raw)
To: java-patches; +Cc: gcc-patches
libjava testcases are run in a random order (i.e. as tcl's glob procedure
finds them) which can vary between testsuite runs. This makes it difficult
to compare mail-report.log for changes in testsuite results. The following
patch fixes this by sorting the source files, just like e.g. the
libstdc++-v3 testsuite does.
Successfully bootstrapped on i386-pc-solaris2.8 with the desired effect :-)
Ok for mainline?
Rainer
Mon Jul 15 14:20:01 2002 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE>
* libjava.compile/compile.exp: Sort sources.
* libjava.jni/jni.exp (gcj_jni_run): Likewise.
* libjava.lang/lang.exp: Likewise.
Index: libjava.compile/compile.exp
===================================================================
RCS file: /cvs/gcc/gcc/libjava/testsuite/libjava.compile/compile.exp,v
retrieving revision 1.2
diff -u -p -r1.2 compile.exp
--- libjava.compile/compile.exp 17 May 2000 15:48:44 -0000 1.2
+++ libjava.compile/compile.exp 17 Jul 2002 16:47:24 -0000
@@ -1,6 +1,6 @@
global srcdir subdir
-catch "glob -nocomplain ${srcdir}/${subdir}/*.java" srcfiles
+catch { lsort [glob -nocomplain ${srcdir}/${subdir}/*.java] } srcfiles
verbose "srcfiles are $srcfiles"
set prefix ""
Index: libjava.jni/jni.exp
===================================================================
RCS file: /cvs/gcc/gcc/libjava/testsuite/libjava.jni/jni.exp,v
retrieving revision 1.7
diff -u -p -r1.7 jni.exp
--- libjava.jni/jni.exp 27 Mar 2002 16:29:04 -0000 1.7
+++ libjava.jni/jni.exp 17 Jul 2002 16:47:24 -0000
@@ -167,7 +167,7 @@ proc gcj_jni_run {} {
# For now we only test JNI on native builds.
if {$build_triplet == $host_triplet} {
- catch "glob -nocomplain ${srcdir}/${subdir}/*.java" srcfiles
+ catch { lsort [glob -nocomplain ${srcdir}/${subdir}/*.java] } srcfiles
foreach x $srcfiles {
gcj_jni_test_one $x
Index: libjava.lang/lang.exp
===================================================================
RCS file: /cvs/gcc/gcc/libjava/testsuite/libjava.lang/lang.exp,v
retrieving revision 1.1
diff -u -p -r1.1 lang.exp
--- libjava.lang/lang.exp 4 Oct 1999 03:30:54 -0000 1.1
+++ libjava.lang/lang.exp 17 Jul 2002 16:47:24 -0000
@@ -1,6 +1,6 @@
global srcdir subdir
-catch "glob -nocomplain ${srcdir}/${subdir}/*.out" srcfiles
+catch { lsort [glob -nocomplain ${srcdir}/${subdir}/*.out] } srcfiles
verbose "srcfiles are $srcfiles"
set prefix ""
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 3.3 PATCH: Sort libjava test sources
2002-07-17 9:57 3.3 PATCH: Sort libjava test sources Rainer Orth
@ 2002-07-18 11:01 ` Tom Tromey
0 siblings, 0 replies; 2+ messages in thread
From: Tom Tromey @ 2002-07-18 11:01 UTC (permalink / raw)
To: Rainer Orth; +Cc: java-patches, gcc-patches
>>>>> "Rainer" == Rainer Orth <ro@TechFak.Uni-Bielefeld.DE> writes:
Rainer> Mon Jul 15 14:20:01 2002 Rainer Orth <ro@TechFak.Uni-Bielefeld.DE>
Rainer> * libjava.compile/compile.exp: Sort sources.
Rainer> * libjava.jni/jni.exp (gcj_jni_run): Likewise.
Rainer> * libjava.lang/lang.exp: Likewise.
Thanks, please check this in.
Tom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2002-07-18 16:57 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-07-17 9:57 3.3 PATCH: Sort libjava test sources Rainer Orth
2002-07-18 11:01 ` Tom Tromey
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).