From: Jeff Law <jeffreyalaw@gmail.com>
To: Simon Marchi <simon.marchi@polymtl.ca>,
Nick Clifton <nickc@redhat.com>,
gcc-patches@gcc.gnu.org, gdb-patches@sourceware.org
Cc: Binutils <binutils@sourceware.org>
Subject: Re: RFC: Changing AC_PROG_CC to AC_PROG_CC_C99 in top level configure
Date: Fri, 30 Apr 2021 15:48:00 -0600 [thread overview]
Message-ID: <15701c5f-5653-f0e4-990a-43094d18a702@gmail.com> (raw)
In-Reply-To: <8c1b0ed9-e6f3-9c22-45c5-c2680a2a4830@polymtl.ca>
On 4/30/2021 12:36 PM, Simon Marchi via Gcc-patches wrote:
> On 2021-04-26 7:32 a.m., Nick Clifton via Gdb-patches wrote:> Hi Guys,
>> Given that gcc, gdb and now binutils are all now requiring C99 as a
>> minimum version of C, are there any objections to updating
>> configure.ac to reflect this ?
>>
>> Cheers
>> Nick
>>
>> diff --git a/configure.ac b/configure.ac
>> index a721316d07b..59b4194fb24 100644
>> --- a/configure.ac
>> +++ b/configure.ac
>> @@ -1278,7 +1278,7 @@ else
>> WINDMC_FOR_BUILD="\$(WINDMC)"
>> fi
>>
>> -AC_PROG_CC
>> +AC_PROG_CC_C99
>> AC_PROG_CXX
>>
>> # We must set the default linker to the linker used by gcc for the correct
> Hi Nick,
>
> I think this fix is obvious enough, I encourage you to push it, that
> will fix the build failure many people get in opcodes/ppc-dis.c. We'll
> just remove the line later when we upgrade to Autoconf 2.71, as simple
> as that. For now we use 2.69. If that matters, you have my OK for the
> GDB side of things.
That works for me. I'd just sent Alan the trivial patch to make
ppc-dis.c compile again with C89, but if we're going to update
configure.ac appropriately, then it wouldn't be needed.
Jeff
next prev parent reply other threads:[~2021-04-30 21:48 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-26 11:32 Nick Clifton
2021-04-26 19:32 ` Joseph Myers
2021-04-26 20:05 ` Mike Frysinger
2021-04-26 21:31 ` Christian Biesinger
2021-04-27 10:49 ` Nick Clifton
2021-04-27 16:58 ` Joseph Myers
2021-04-30 18:36 ` Simon Marchi
2021-04-30 21:48 ` Jeff Law [this message]
2021-05-03 6:28 ` Alan Modra
2021-05-03 14:47 ` Simon Marchi
2021-05-03 16:26 ` Tom Tromey
2021-05-03 21:51 ` Alan Modra
2021-05-03 23:30 ` Simon Marchi
2021-05-04 12:42 ` Nick Clifton
2021-05-04 15:16 ` Simon Marchi
2021-05-05 0:18 ` Alan Modra
2021-05-05 7:05 ` Iain Sandoe
2021-05-05 7:20 ` Alan Modra
2021-05-05 7:23 ` Iain Sandoe
2021-05-10 8:49 ` Iain Sandoe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15701c5f-5653-f0e4-990a-43094d18a702@gmail.com \
--to=jeffreyalaw@gmail.com \
--cc=binutils@sourceware.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=gdb-patches@sourceware.org \
--cc=nickc@redhat.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).