From: <apinski@marvell.com>
To: <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>
Subject: [PATCH 1/2] Fix uninitialized field in expand_operand.
Date: Thu, 16 Jan 2020 07:08:00 -0000 [thread overview]
Message-ID: <1579151329-6088-1-git-send-email-apinski@marvell.com> (raw)
From: Andrew Pinski <apinski@marvell.com>
Commit g:f96bf49a0 added the target field to expand_operand.
But it leaves it uninitialized when doing a full initialization
inside create_expand_operand. This fixes the problem and improves
the code generation inside create_expand_operand too.
OK? Bootstrapped and tested on x86_64-linux-gnu with no regressions.
ChangeLog:
* optabs.h (create_expand_operand): Initialize target field also.
Change-Id: Ib653fbfbb2b0709970db87fb94de14b59758bc6c
---
gcc/optabs.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/gcc/optabs.h b/gcc/optabs.h
index 07bdc56586e..5bd19503a0a 100644
--- a/gcc/optabs.h
+++ b/gcc/optabs.h
@@ -78,6 +78,7 @@ create_expand_operand (class expand_operand *op,
{
op->type = type;
op->unsigned_p = unsigned_p;
+ op->target = 0;
op->unused = 0;
op->mode = mode;
op->value = value;
--
2.17.1
next reply other threads:[~2020-01-16 5:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-01-16 7:08 apinski [this message]
2020-01-16 7:32 ` [PATCH 2/2] Uninitialized padding in struct _dep apinski
2020-01-16 9:41 ` Richard Biener
2020-01-16 9:40 ` [PATCH 1/2] Fix uninitialized field in expand_operand Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1579151329-6088-1-git-send-email-apinski@marvell.com \
--to=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).