From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 23095 invoked by alias); 29 Apr 2016 11:23:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 23077 invoked by uid 89); 29 Apr 2016 11:23:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.5 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_NONE autolearn=no version=3.3.2 spammy=1523, 1468, HX-Envelope-From:sk:ebotcaz, H*F:U*ebotcazou X-HELO: smtp.eu.adacore.com Received: from mel.act-europe.fr (HELO smtp.eu.adacore.com) (194.98.77.210) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Fri, 29 Apr 2016 11:23:03 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 36EF1812D3; Fri, 29 Apr 2016 13:23:01 +0200 (CEST) Received: from smtp.eu.adacore.com ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id SiXGPKaAsdeG; Fri, 29 Apr 2016 13:23:01 +0200 (CEST) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.eu.adacore.com (Postfix) with ESMTPSA id 1181F812D1; Fri, 29 Apr 2016 13:23:01 +0200 (CEST) From: Eric Botcazou To: Uros Bizjak Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH, i386]: Extend TARGET_READ_MODIFY{,_WRITE} peepholes to all integer modes Date: Fri, 29 Apr 2016 11:23:00 -0000 Message-ID: <1587814.Yvh9q60GN3@polaris> User-Agent: KMail/4.14.10 (Linux/3.16.7-35-desktop; KDE/4.14.9; x86_64; ; ) In-Reply-To: References: <3799415.uPfXC5v7Nr@polaris> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-SW-Source: 2016-04/txt/msg01979.txt.bz2 > Attached patch was actually tested on a couple of cases. It generates > the same assembly as before. Note that you could just remove the second ":W" in the define_insn pattern. That's better, but not quite it because this segfaults at -O2: #0 memory_operand (op=0xabababababababab, mode=mode@entry=VOIDmode) at /home/eric/svn/gcc/gcc/recog.c:1360 #1 0x00000000014388b1 in get_attr_memory (insn=insn@entry=0x7ffff697b8c0) at /home/eric/svn/gcc/gcc/config/i386/i386.md:2120 #2 0x0000000001636fb8 in insn_default_latency_generic (insn=0x7ffff697b8c0) at /home/eric/svn/gcc/gcc/config/i386/i386.md:27394 #3 0x00000000017f9695 in insn_cost (insn=0x7ffff697b8c0) at /home/eric/svn/gcc/gcc/haifa-sched.c:1415 #4 0x00000000017feb75 in dep_cost_1 (link=link@entry=0x2e962e8, dw=dw@entry=0) at /home/eric/svn/gcc/gcc/haifa-sched.c:1468 #5 0x0000000001800d7a in dep_cost (link=0x2e962e8) at /home/eric/svn/gcc/gcc/haifa-sched.c:1523 #6 priority (insn=0x7ffff697b8c0) at /home/eric/svn/gcc/gcc/haifa- sched.c:1674 #7 0x0000000001800e6f in set_priorities (head=, tail=) at /home/eric/svn/gcc/gcc/haifa-sched.c:7209 #8 0x0000000000f689e3 in compute_priorities () at /home/eric/svn/gcc/gcc/sched-rgn.c:3022 #9 0x0000000000f6bc46 in schedule_region (rgn=0) at /home/eric/svn/gcc/gcc/sched-rgn.c:3115 #10 schedule_insns () at /home/eric/svn/gcc/gcc/sched-rgn.c:3513 #11 0x0000000000f6c4de in schedule_insns () (gdb) frame 1 #1 0x00000000014388b1 in get_attr_memory (insn=insn@entry=0x7ffff697b8c0) at /home/eric/svn/gcc/gcc/config/i386/i386.md:2120 2120 (match_test "TARGET_AVX") (gdb) p debug_rtx(insn) (insn 779 927 928 2 (parallel [ (set (mem/v:DI (reg/f:DI 7 sp) [0 S8 A8]) (unspec:DI [ (const_int 0 [0]) ] UNSPEC_PROBE_STACK)) (clobber (reg:CC 17 flags)) ]) c52104y.adb:57 1005 {probe_stack_di} (expr_list:REG_UNUSED (reg:CC 17 flags) (nil))) $1 = void -- Eric Botcazou