From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 30458 invoked by alias); 18 Apr 2012 19:19:06 -0000 Received: (qmail 30424 invoked by uid 22791); 18 Apr 2012 19:19:05 -0000 X-SWARE-Spam-Status: No, hits=-2.7 required=5.0 tests=AWL,BAYES_00,FREEMAIL_FROM,KHOP_THREADED,RCVD_IN_DNSWL_NONE,RCVD_IN_HOSTKARMA_NO,RCVD_IN_HOSTKARMA_YE,TW_TJ,T_RP_MATCHES_RCVD X-Spam-Check-By: sourceware.org Received: from qmta08.emeryville.ca.mail.comcast.net (HELO qmta08.emeryville.ca.mail.comcast.net) (76.96.30.80) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 18 Apr 2012 19:18:17 +0000 Received: from omta05.emeryville.ca.mail.comcast.net ([76.96.30.43]) by qmta08.emeryville.ca.mail.comcast.net with comcast id zXJ61i0070vp7WLA8XJHdx; Wed, 18 Apr 2012 19:18:17 +0000 Received: from up.mrs.kithrup.com ([24.4.193.8]) by omta05.emeryville.ca.mail.comcast.net with comcast id zXJF1i01E0BKwT48RXJGFu; Wed, 18 Apr 2012 19:18:16 +0000 Subject: Re: Remove SETJMP_VIA_SAVE_AREA support Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Mike Stump In-Reply-To: <201106021241.49426.ebotcazou@adacore.com> Date: Wed, 18 Apr 2012 19:19:00 -0000 Cc: gcc-patches@gcc.gnu.org Content-Transfer-Encoding: quoted-printable Message-Id: <15A01AEA-2E50-44A8-B94D-C2D18746190C@comcast.net> References: <201106021241.49426.ebotcazou@adacore.com> To: Eric Botcazou X-IsSubscribed: yes Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-04/txt/msg01109.txt.bz2 On Jun 2, 2011, at 3:41 AM, Eric Botcazou wrote: > This removes the (undocumented) support for SETJMP_VIA_SAVE_AREA from the= =20 > compiler. > 2011-06-02 Eric Botcazou > * builtins.c (expand_builtin_setjmp_setup): Do not set calls_setjmp. > --- builtins.c (revision 174559) > +++ builtins.c (working copy) > @@ -806,10 +806,6 @@ expand_builtin_setjmp_setup (rtx buf_add > emit_insn (gen_builtin_setjmp_setup (buf_addr)); > #endif >=20=20 > - /* Tell optimize_save_area_alloca that extra work is going to > - need to go on during alloca. */ > - cfun->calls_setjmp =3D 1; > - > /* We have a nonlocal label. */ > cfun->has_nonlocal_label =3D 1; > } You do know that at least rtl hoisting is dependent upon calls_setjmp being= set, right? :-( This part breaks my port. I think you read the comment and thought it was = exhaustive, I don't believe it is. Any objection to putting it back, or, would you like me to drill down on rt= l hoisting?