public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: "Martin Liška" <mliska@suse.cz>
To: Jakub Jelinek <jakub@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Add limit for maximal alignment options (PR c/84310).
Date: Tue, 20 Feb 2018 10:05:00 -0000	[thread overview]
Message-ID: <15a4f3d8-08f9-a46c-86fd-9e1cd6a00245@suse.cz> (raw)
In-Reply-To: <20180220084309.GZ5867@tucnak>

On 02/20/2018 09:43 AM, Jakub Jelinek wrote:
> On Mon, Feb 12, 2018 at 01:09:43PM +0100, Martin Liška wrote:
>> Following patch fixes 2 issues with -falign-*:
>> 1) when using -malign-x=16 (or corresponding -falign-* value) then ICE appeared
>> as code in final.c can deal just with limited alignment.
>> 2) thus I also documented and limited the maximum value of -falign-* options.
>>
>> Patch can bootstrap on ppc64le-redhat-linux and survives regression tests.
>> i386.exp test-suite works fine on x86_64 machine.
>>
>> Ready to be installed?
>> Martin
>>
>> gcc/ChangeLog:
>>
>> 2018-02-09  Martin Liska  <mliska@suse.cz>
>>
>> 	PR c/84310
>> 	PR target/79747
>> 	* final.c (shorten_branches): Build align_tab array with one
>> 	more element.
>> 	* opts.c (finish_options): Add alignment option limit check.
>> 	(MAX_CODE_ALIGN): Likewise.
>> 	(MAX_CODE_ALIGN_VALUE): Likewise.
>> 	* doc/invoke.texi: Document maximum allowed option value for
>> 	all -falign-* options.
>>
>> gcc/testsuite/ChangeLog:
>>
>> 2018-02-12  Martin Liska  <mliska@suse.cz>
>>
>> 	PR c/84310
>> 	PR target/79747
>> 	* gcc.target/i386/pr84310.c: New test.
>> 	* gcc.target/i386/pr84310-2.c: Likewise.
> 
> Ok, thanks.
> 
> 	Jakub
> 

Thanks Jakub!
Would it be possible to backport that to active branches?

Martin

  reply	other threads:[~2018-02-20 10:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-02-12 12:09 Martin Liška
2018-02-20  8:25 ` Martin Liška
2018-02-20  8:43 ` Jakub Jelinek
2018-02-20 10:05   ` Martin Liška [this message]
2018-02-20 12:49     ` Jakub Jelinek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=15a4f3d8-08f9-a46c-86fd-9e1cd6a00245@suse.cz \
    --to=mliska@suse.cz \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jakub@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).