From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-u-204.mailbox.org (mout-u-204.mailbox.org [91.198.250.253]) by sourceware.org (Postfix) with ESMTPS id 638A5385DC02 for ; Wed, 1 Apr 2020 10:51:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 638A5385DC02 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mout-u-204.mailbox.org (Postfix) with ESMTPS id 48sjfX6FvpzQlHS; Wed, 1 Apr 2020 12:51:00 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id p8791Z0rPkpy; Wed, 1 Apr 2020 12:50:57 +0200 (CEST) Subject: Re: [PATCH] S/390: Fix PR91628 To: Stefan Liebler , GCC Patches References: <0afe1b58-2544-98c2-b056-a724f1a5fa6d@linux.ibm.com> <349a43fc-2a10-19ee-c7f0-ee18b29722e4@linux.ibm.com> From: Iain Buclaw Message-ID: <15b5b45f-de91-91df-3fb7-3befc0a6ffa4@gdcproject.org> Date: Wed, 1 Apr 2020 12:50:55 +0200 MIME-Version: 1.0 In-Reply-To: <349a43fc-2a10-19ee-c7f0-ee18b29722e4@linux.ibm.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-GB Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 0742E1760 X-Rspamd-Score: -0.82 / 15.00 / 200.00 X-Spam-Status: No, score=-13.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS, KAM_NUMSUBJECT, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Apr 2020 10:51:04 -0000 On 01/04/2020 08:28, Stefan Liebler wrote: > ping > Hi Stefan, As I've already said, I think that the name should be __ibmz_get_tls_offset to make clear that it is an internal function. Other than that, looks good to me. Iain.