From: Jeff Law <law@redhat.com>
To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com
Subject: Re: [09/13] Use function_arg_info for TARGET_MUST_PASS_IN_STACK
Date: Mon, 19 Aug 2019 22:04:00 -0000 [thread overview]
Message-ID: <15ec819f-63e4-aba3-d702-94a4a26e7a9c@redhat.com> (raw)
In-Reply-To: <mptsgpxb2rm.fsf@arm.com>
On 8/19/19 9:20 AM, Richard Sandiford wrote:
> Use function_arg_info for TARGET_MUST_PASS_IN_STACK.
>
> The hook is passed the promoted mode instead of the original type mode.
>
> The expr.h reference in the documentation is no longer correct, but
> pointing to calls.h or calls.c doesn't help much either. I just left
> this as-is since it's not related to the point of the series.
>
> After previous changes, most places already pass arg.mode and arg.type.
> Only i386 and mcore needed to construct a new one out of nothing.
> rs6000 needs to construct one slightly earlier than before.
>
>
> 2019-08-19 Richard Sandiford <richard.sandiford@arm.com>
>
> gcc/
> * target.def (must_pass_in_stack): Take a function_arg_info instead
> of a mode and a type.
> * doc/tm.texi: Regenerate.
> * calls.h (must_pass_in_stack_var_size): Take a function_arg_info
> instead of a mode and a type.
> (must_pass_in_stack_var_size_or_pad): Likewise.
> * calls.c (must_pass_in_stack_var_size): Likewise.
> (must_pass_in_stack_var_size_or_pad): Likewise.
> (initialize_argument_information): Update call to
> targetm.calls.must_pass_in_stack.
> (must_pass_va_arg_on_stack): Likewise.
> * function.c (assign_parm_find_entry_rtl): Likewise.
> * targhooks.c (hook_pass_by_reference_must_pass_in_stack): Likewise.
> * config/alpha/alpha.c (alpha_function_arg): Likewise.
> (alpha_function_arg_advance): Likewise.
> * config/cr16/cr16.c (cr16_function_arg): Likewise.
> (cr16_function_arg_advance): Likewise.
> * config/cris/cris.c (cris_pass_by_reference): Likewise.
> (cris_arg_partial_bytes): Likewise.
> * config/iq2000/iq2000.c (iq2000_pass_by_reference): Likewise.
> * config/lm32/lm32.c (lm32_function_arg): Likewise.
> * config/mcore/mcore.c (mcore_num_arg_regs): Likewise.
> (mcore_function_arg, mcore_arg_partial_bytes): Likewise.
> * config/mips/mips.c (mips_pass_by_reference): Likewise.
> * config/mmix/mmix.c (mmix_function_arg_advance): Likewise.
> (mmix_function_arg_1, mmix_pass_by_reference): Likewise.
> * config/sh/sh.c (sh_pass_by_reference): Likewise.
> * config/stormy16/stormy16.c (xstormy16_function_arg): Likewise.
> * config/xtensa/xtensa.c (xtensa_function_arg_advance): Likewise.
> * config/arm/arm.c (arm_must_pass_in_stack): Take a function_arg_info
> instead of a mode and a type.
> * config/fr30/fr30.c (fr30_must_pass_in_stack): Likewise.
> (fr30_num_arg_regs): Likewise.
> (fr30_setup_incoming_varargs): Update calls accordingly.
> (fr30_arg_partial_bytes, fr30_function_arg): Likewise.
> (fr30_function_arg_advance): Likewise.
> * config/frv/frv.c (frv_must_pass_in_stack): Take a function_arg_info
> instead of a mode and a type.
> * config/gcn/gcn.c (num_arg_regs): Likewise.
> (gcn_function_arg, gcn_function_arg_advance): Update calls to
> num_arg_regs and targetm.calls.must_pass_in_stack.
> (gcn_arg_partial_bytes): Likewise.
> * config/i386/i386.c (ix86_must_pass_in_stack): Take a
> function_arg_info instead of a mode and a type.
> (classify_argument): Update call accordingly.
> * config/nds32/nds32.c (nds32_must_pass_in_stack): Take a
> function_arg_info instead of a mode and a type.
> * config/rs6000/rs6000-internal.h (rs6000_must_pass_in_stack):
> Likewise.
> * config/rs6000/rs6000-call.c (rs6000_must_pass_in_stack): Likewise.
> (rs6000_parm_needs_stack): Update call accordingly.
> (setup_incoming_varargs): Likewise.
>
OK
jeff
next prev parent reply other threads:[~2019-08-19 21:07 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-19 15:15 [00/13] Pass an argument descriptor to target hooks Richard Sandiford
2019-08-19 15:16 ` [01/13] Add pass_va_arg_by_reference Richard Sandiford
2019-08-19 20:04 ` Jeff Law
2019-08-19 15:17 ` [02/13] Add must_pass_va_arg_in_stack Richard Sandiford
2019-08-19 20:05 ` Jeff Law
2019-08-19 15:18 ` [03/13] Use function_arg_info for TARGET_ARG_PARTIAL_BYTES Richard Sandiford
2019-08-19 20:42 ` Jeff Law
2019-08-19 15:19 ` [04/13] Use function_arg_info for TARGET_PASS_BY_REFERENCE Richard Sandiford
2019-08-19 20:43 ` Jeff Law
2019-08-19 15:20 ` [05/13] Use function_arg_info for TARGET_SETUP_INCOMING_ARGS Richard Sandiford
2019-08-19 20:50 ` Jeff Law
2019-08-19 15:21 ` [06/13] Use function_arg_info for TARGET_FUNCTION_(INCOMING_)ARG Richard Sandiford
2019-08-19 21:07 ` Jeff Law
2019-08-19 15:22 ` [07/13] Use function_arg_info for TARGET_FUNCTION_ARG_ADVANCE Richard Sandiford
2019-08-19 21:11 ` Jeff Law
2019-08-19 15:23 ` [08/13] Use function_arg_info for TARGET_CALLEE_COPIES Richard Sandiford
2019-08-19 21:16 ` Jeff Law
2019-08-19 15:24 ` [09/13] Use function_arg_info for TARGET_MUST_PASS_IN_STACK Richard Sandiford
2019-08-19 22:04 ` Jeff Law [this message]
2019-08-19 15:47 ` [10/13] Add a apply_pass_by_reference_rules helper Richard Sandiford
2019-08-19 22:19 ` Jeff Law
2019-08-19 15:51 ` [11/13] Make function.c use function_arg_info internally Richard Sandiford
2019-08-19 22:47 ` Jeff Law
2019-08-19 15:52 ` [13/13] Add a pass_by_reference flag to function_arg_info Richard Sandiford
2019-08-19 22:54 ` Jeff Law
2019-08-19 15:52 ` [12/13] Make calls.c use function_arg_info internally Richard Sandiford
2019-08-19 22:49 ` Jeff Law
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15ec819f-63e4-aba3-d702-94a4a26e7a9c@redhat.com \
--to=law@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.sandiford@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).