From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTPS id 62D283857C4F for ; Mon, 18 Dec 2023 21:35:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 62D283857C4F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 62D283857C4F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702935315; cv=none; b=IrlAJDiu4jp0gNpZZt0AyzobWF0xouxR2IgTTykfa5+4SeM8SNv7CcP/BltP++XSDDpKDHyRfggASpjSKo3nD892O3ZhL+OWZfHxbmn5HLBBpGLzdIOHSkXRu/Do/O5jbZ0wRA74MtVf/uJY57rC8j2AHLSU6RVyu41i85dtVWQ= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702935315; c=relaxed/simple; bh=Wf96SKAazH2e06qDr9NlnqbHQtXdJSN6HeqdoIpTtMw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Dw0zhIwbrTRQiI7B78YS0ZLdqCNrYwIfrgx3+OjZJczmNoGhsaSjRoSMGIt117GViDRwzhts1AtxaFpzQfqnLpXOXP53aLkuGkLoiueEdG0yQpAyXYbq3j+urVpg0IxESKuNWJQF2ktwRUl35xpROJVjLQigjFnkAZRAH9MZ/f0= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1702935314; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=IkF8cBK+Mtds8IpMFP3gUG2zhGu2vU9+a4tdb+PMU+I=; b=QNu6GyU7wewO2zGt8/owkD8SU7ZswvQUDTANyJrFbZa+V68PY++OK9IR3m7BJFiSHcrFMg wdaeJaSouaZVN7vUbwc2bD7voPleJKZdYMsD2V8oVJUVaO6p9sxTij0tfWtlC8v/h5Owu8 IRG5ecf7+Hu/WBs4ChsH+K0DSD49D6A= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-541-VmszetkrMEypo1Nfj1C3Hw-1; Mon, 18 Dec 2023 16:35:12 -0500 X-MC-Unique: VmszetkrMEypo1Nfj1C3Hw-1 Received: by mail-qv1-f70.google.com with SMTP id 6a1803df08f44-67f4e1a35daso12361556d6.3 for ; Mon, 18 Dec 2023 13:35:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702935312; x=1703540112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=IkF8cBK+Mtds8IpMFP3gUG2zhGu2vU9+a4tdb+PMU+I=; b=fHSZui2ANbws9bXk46T2pVFk2QrP4URDsiO7F2AZVe2D4L504y8sZlzELrbKFB21lH iCsmYRYV+Iv9sHz3Qoe/9t+Zdl0vbSgpyQHPMrXV8PUZs94d0dTaTYLeM5rxZpEkYx4L /JtGzkYXRdbjk95z5BxsHjTswvk+XR3d7HMEWuJpHd6D0nAoL+DfXDKNXctrM06R4/l8 JfnGoVPXormjc+Ad3DsxOcOHoGVuS3LIp8lJk9IQhLs83AMdl9mTZoaD21XlNb/bgrZ4 D+SNgNrw9I+T4LUBoBnNc9cqCMw7rQf/rfrENsP4wds7BSbFhyIz/r/f4YxLH93qUZWy tRjA== X-Gm-Message-State: AOJu0YxwafoIiO/BZEbiKCunrGKF1/DruoPuI1ZGMjuKiAFOL9Dfhlvf 3U5jXJ8BuYJIPUSusCSeKwtU++xfL4eS9PBtFpts8GZ0tafLhd0KPh88la4DawQfhZbT5FdhayG FULrz8zLJstmXJUz4yg== X-Received: by 2002:a05:6214:21c9:b0:67f:3a85:9310 with SMTP id d9-20020a05621421c900b0067f3a859310mr4221664qvh.101.1702935312083; Mon, 18 Dec 2023 13:35:12 -0800 (PST) X-Google-Smtp-Source: AGHT+IEL2ksF20byQznlkFm+xfRXGmsejwK2SQhiumWTNdflCBGI3jKf22Lw0FiekBOe3qReD9CJUA== X-Received: by 2002:a05:6214:21c9:b0:67f:3a85:9310 with SMTP id d9-20020a05621421c900b0067f3a859310mr4221655qvh.101.1702935311852; Mon, 18 Dec 2023 13:35:11 -0800 (PST) Received: from [192.168.1.146] (130-44-146-16.s12558.c3-0.arl-cbr1.sbo-arl.ma.cable.rcncustomer.com. [130.44.146.16]) by smtp.gmail.com with ESMTPSA id jx13-20020a0562142b0d00b0067f4f07587csm693511qvb.69.2023.12.18.13.35.11 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 18 Dec 2023 13:35:11 -0800 (PST) Message-ID: <1602753a-457b-4baa-bcc4-483411f61878@redhat.com> Date: Mon, 18 Dec 2023 16:35:10 -0500 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] c++: [[deprecated]] on template redecl [PR84542] To: Marek Polacek , Patrick Palka Cc: gcc-patches@gcc.gnu.org References: <20231218195004.1238589-1-ppalka@redhat.com> From: Jason Merrill In-Reply-To: X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-6.2 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE,RCVD_IN_MSPIKE_H4,RCVD_IN_MSPIKE_WL,SPF_HELO_NONE,SPF_NONE,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 12/18/23 14:56, Marek Polacek wrote: > On Mon, Dec 18, 2023 at 02:50:04PM -0500, Patrick Palka wrote: >> Bootstrapped and regtested on x86_64-pc-linux-gnu, does this look >> OK for trunk? > > LGTM but... > >> -- >8 -- >> >> The deprecated and unavailable attributes weren't working when used on >> a template redeclaration ultimately because the corresponding tree flags >> on the underlying decls weren't being merged across redeclarations. >> >> PR c++/84542 >> >> gcc/cp/ChangeLog: >> >> * decl.cc (merge_attribute_bits): > > ...this entry is missing. Thanks, Indeed. OK with that fixed.