From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout-p-201.mailbox.org (mout-p-201.mailbox.org [80.241.56.171]) by sourceware.org (Postfix) with ESMTPS id 9C866385802B for ; Fri, 27 Nov 2020 20:26:39 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 9C866385802B Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4CjR3x6jKbzQlX9; Fri, 27 Nov 2020 21:26:37 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter06.heinlein-hosting.de (spamfilter06.heinlein-hosting.de [80.241.56.125]) (amavisd-new, port 10030) with ESMTP id LoIrA0AUqUa1; Fri, 27 Nov 2020 21:26:34 +0100 (CET) Date: Fri, 27 Nov 2020 21:26:31 +0100 From: Iain Buclaw Subject: Re: [PATCH] INSTALL: Default to --enable-cet=auto To: Matthias Klose , "H.J. Lu" Cc: GCC Patches , Richard Biener References: <20201127134211.1808714-1-hjl.tools@gmail.com> In-Reply-To: MIME-Version: 1.0 Message-Id: <1606508590.2azy49d6bi.astroid@galago.none> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-MBO-SPAM-Probability: X-Rspamd-Score: -5.19 / 15.00 / 15.00 X-Rspamd-Queue-Id: CA1B21842 X-Rspamd-UID: ccbd0e X-Spam-Status: No, score=-16.1 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, GIT_PATCH_0, RCVD_IN_DNSWL_LOW, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 27 Nov 2020 20:26:42 -0000 Excerpts from H.J. Lu's message of November 27, 2020 8:28 pm: > On Fri, Nov 27, 2020 at 11:02 AM Matthias Klose wrote: >> >> On 11/27/20 3:54 PM, H.J. Lu via Gcc-patches wrote: >> > On Fri, Nov 27, 2020 at 6:24 AM Richard Biener wro= te: >> >> >> >> OK. >> >> >> >> On Fri, 27 Nov 2020, H.J. Lu wrote: >> >> >> >>> PR other/98027 >> >>> * doc/install: Default to --enable-cet=3Dauto. >> >>> --- >> >>> gcc/doc/install.texi | 9 ++++----- >> >>> 1 file changed, 4 insertions(+), 5 deletions(-) >> >>> >> >>> diff --git a/gcc/doc/install.texi b/gcc/doc/install.texi >> >>> index 5f879ca4cea..021c347cc09 100644 >> >>> --- a/gcc/doc/install.texi >> >>> +++ b/gcc/doc/install.texi >> >>> @@ -2259,11 +2259,10 @@ instrumentation, see @option{-fcf-protection= } option. When >> >>> to add @option{-fcf-protection} and, if needed, other target >> >>> specific options to a set of building options. >> >>> >> >>> -The option is disabled by default. When @code{--enable-cet=3Dauto} >> >>> -is used, it is enabled on Linux/x86 if target binutils >> >>> -supports @code{Intel CET} instructions and disabled otherwise. >> >>> -In this case the target libraries are configured to get additional >> >>> -@option{-fcf-protection} option. >> >>> +@code{--enable-cet=3Dauto} is default. CET is enabled on Linux/x86= if >> >>> +target binutils supports @code{Intel CET} instructions and disabled >> >>> +otherwise. In this case, the target libraries are configured to ge= t >> >>> +additional @option{-fcf-protection} option. >> >>> >> >>> @item --with-riscv-attribute=3D@samp{yes}, @samp{no} or @samp{defau= lt} >> >>> Generate RISC-V attribute by default, in order to record extra buil= d >> >>> >> >> >> > >> > OK for backport to GCC 10? >> >> I only found that because of failing package builds in a test rebuild. S= ee >> PR98025. Is it safe to backport that, if it breaks the ABI of a runtime = library >=20 > libphobos has some CET issues which have been fixed in GCC 11. >=20 There's still a remaining issue (see PR 98025) that I'm about to push a fix for. >> shipped with GCC 10? >> >=20 > It is just a documentation change. >=20 I don't think the backport is necessary, as it is default disabled in GCC 10. It was only at the beginning of the GCC 11 development cycle that it got changed to default auto. Iain.