From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by sourceware.org (Postfix) with ESMTPS id 36EDB3858D33 for ; Wed, 1 Feb 2023 14:44:23 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 36EDB3858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.cz Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 207AD1F74C; Wed, 1 Feb 2023 14:44:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1675262662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sPQhWvB4nubBDhfFP/XsWZCcBO6pumJMxp1vQTtowLU=; b=fTW2y+Mx6xKZcFkhqKVKHsY+D7Bk6ZGWG0NzdWcqQ5Y4ZC9dzByBI4jg9UThPHJpWRM0VE hNpToEbuC32I5erY/SdT26pAKrFmdF83mObO73zWNUqi2bsxVybqtoa+pf7vI+hWgF6epd 23OnYokgVMafExzaMpmRPDG7zxnWBiM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1675262662; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sPQhWvB4nubBDhfFP/XsWZCcBO6pumJMxp1vQTtowLU=; b=MwFPX2nxtE3heQ8pT0PwOx/YgAoH1WMIENNuat20rLLexpcKn4OCtPsSI+R8m3H+EadUaC sRMm5Rx0EWwhX8Aw== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 01C451348C; Wed, 1 Feb 2023 14:44:21 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id duS3OcV62mMOfQAAMHmgww (envelope-from ); Wed, 01 Feb 2023 14:44:21 +0000 Message-ID: <160b53bd-0747-9699-2fef-62415bb6450f@suse.cz> Date: Wed, 1 Feb 2023 15:44:21 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.6.1 Subject: Re: [PATCH] ipa: silent -Wodr notes with -w To: Martin Jambor , gcc-patches@gcc.gnu.org Cc: Jan Hubicka References: Content-Language: en-US From: =?UTF-8?Q?Martin_Li=c5=a1ka?= In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-5.9 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 2/1/23 15:26, Martin Jambor wrote: > Hi, > > On Fri, Dec 02 2022, Martin Liška wrote: >> If -w is used, warn_odr properly sets *warned = false and >> so it should be preserved when calling warn_types_mismatch. >> >> Noticed that during a LTO reduction where I used -w. >> >> Patch can bootstrap on x86_64-linux-gnu and survives regression tests. >> >> Ready to be installed? >> Thanks, >> Martin >> >> gcc/ChangeLog: >> >> * ipa-devirt.cc (odr_types_equivalent_p): Respect *warned >> value if set. > Hi. > Sorry for skipping this for so long, usually ODR stuff is... interesting > to the point I gladly leave it to Honza. Makes sense, however, he's not much active when it comes to patch review. > > Please go ahead and commit the patch. The way I read the code, your > version must have been the intended behavior and the dereference is > missing. Yep, the patch seems to me quite straightforward. Thanks, Martin > > Thanks, > > Martin >