From: "Paweł Sikora" <pawel.sikora@agmk.net>
To: gcc-patches@gcc.gnu.org
Cc: Jonathan Wakely <jwakely.gcc@gmail.com>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [debug/profile-mode] broken c++config.h
Date: Fri, 16 Mar 2012 15:45:00 -0000 [thread overview]
Message-ID: <1618170.cNQ6tBueUv@vmx> (raw)
In-Reply-To: <CAH6eHdS26eFOUikahq3WzPFVD-Q4hXKwo_ubU+xY0zDNVHmM_A@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 1495 bytes --]
On Friday 16 of March 2012 14:29:21 Jonathan Wakely wrote:
> 2012/3/16 Paweł Sikora:
> > Hi,
> >
> > during gcc build process there's some sed magic (libstdc++-v3/include/Makefile.{am,in}) in action
> > which modifies libstdc++/include/bits/c++config.h (replaces '#define _GLIBCXX_EXTERN_TEMPLATE'
> > according to --enable-extern-template=yes/no settings). in fact, this sed rule also produces
> > a wrong '#define _GLIBCXX_EXTERN_TEMPLATE 1 -1' in line 293:
> >
> > #if defined(_GLIBCXX_DEBUG) || defined(_GLIBCXX_PROFILE)
> > # define _GLIBCXX_STD_C __cxx1998
> > # define _GLIBCXX_BEGIN_NAMESPACE_CONTAINER \
> > namespace _GLIBCXX_STD_C { _GLIBCXX_BEGIN_NAMESPACE_VERSION
> > # define _GLIBCXX_END_NAMESPACE_CONTAINER \
> > } _GLIBCXX_END_NAMESPACE_VERSION
> > # undef _GLIBCXX_EXTERN_TEMPLATE
> > # define _GLIBCXX_EXTERN_TEMPLATE 1 -1 <==== here
> > #endif
> >
> > this broken macro causes runtime errors on mingw (see PR52540).
> > attached small patch fixes all weird runtime errors for me.
>
> Should the addition be \$$ to escape it for the shell as well as for make?
> (I know it works, but that might not be true for all shells.)
i don't think that $, could be expaneded by any shell.
> The diff for Makefile.in is unnecessary, as it should be regenerated
> from Makefile.am
>
> Apart from that the patch looks good, I've CC'd gcc-patches, could you
> provide a changelog entry?
attached. i hope it's correct :)
[-- Attachment #2: ChangeLog --]
[-- Type: text/x-changelog, Size: 223 bytes --]
2012-03-16 Paweł Sikora <pawel.sikora@agmk.net>
PR libstdc++/52540
* include/Makefile.am (c++config.h): Fix sed rule to not break
the _GLIBCXX_EXTERN_TEMPLATE redefinition.
* include/Makefile.in: Regenerated.
next prev parent reply other threads:[~2012-03-16 15:45 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <7281837.C0MGfFFFqB@vmx>
2012-03-16 14:29 ` Jonathan Wakely
2012-03-16 15:31 ` Paolo Carlini
2012-03-16 15:45 ` Paweł Sikora [this message]
2012-03-16 17:16 ` Jonathan Wakely
2012-03-19 12:36 ` Paolo Carlini
2012-03-20 9:23 ` Paolo Bonzini
2012-03-20 10:36 ` Paolo Carlini
2012-03-20 12:20 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1618170.cNQ6tBueUv@vmx \
--to=pawel.sikora@agmk.net \
--cc=gcc-patches@gcc.gnu.org \
--cc=jwakely.gcc@gmail.com \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).