From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.burntcomma.com (mail2.burntcomma.com [217.169.27.34]) by sourceware.org (Postfix) with ESMTPS id BB94A3846423 for ; Tue, 25 Jun 2024 02:49:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org BB94A3846423 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=harmstone.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=harmstone.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org BB94A3846423 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=217.169.27.34 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719283747; cv=none; b=i65Gsyjfp2rzCekCrLkXPF312bV3LAiz/oFwtr6P7IVqyssAJU8PUhgUp+iScZ7crKLD0Wzyd/4nPHYCy0QPLdAsnlFi2AOTU3myYs0cswzWo7xodMuTjOVMsu2lh5gpBd08Nz0MappqJKOQNJMSsjQH2SaicHF+rJlXtty/V50= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1719283747; c=relaxed/simple; bh=K2oJ+T13PpwaPt+sXN6lAiRlkbUvEYpITFw772HlAKs=; h=DKIM-Signature:Message-ID:Date:Mime-Version:Subject:To:From; b=SdheBa5CiUUGXBAoDHWwqp3V/XXCAGXqnNUTMKle91xLeUpoWLsJAFVaVh59QU6l4w246ouxd/Rhx9ks/8hneT5aL81Vba3mt+hHUpLg44Sus6NAXE8cDJo0zI80xpUYR+cN6k+rZi6cphlPo8BNnUg97zRmzL0RodO0CqXzBR4= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [IPV6:2a02:8012:8cf0:0:b62e:99ff:fee9:ad9f] (beren.burntcomma.com [IPv6:2a02:8012:8cf0:0:b62e:99ff:fee9:ad9f]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "hellas", Issuer "burntcomma.com" (verified OK)) by mail.burntcomma.com (Postfix) with ESMTPS id D94473D56C95; Tue, 25 Jun 2024 03:49:03 +0100 (BST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=harmstone.com; s=mail; t=1719283743; bh=nTZZy2NE67bCt0gEmsJn6jP472CMsRk7MDqljMPfhAU=; h=Date:Subject:To:References:From:In-Reply-To; b=gPQOOCF+0bAG5xK7Vhgxz+7MaBE5jq9UZ7hmKheWn3c3Xk+45r1XseyUSyq3EbMIy Ok6z7Rg39hPeNGotgHUjWFJBguIIlQIcPWLbRy7pmhoRtlEd2gwcxRC9l/EVP6t5YY XemHo+FC1cUuskQrqH9yVDi6zR+8+5u3FGyNPOYU= Message-ID: <16345e93-84da-4f3b-a428-e4ff6889f2d3@harmstone.com> Date: Tue, 25 Jun 2024 03:49:03 +0100 Mime-Version: 1.0 Subject: Re: [PATCH 05/11] Handle const and varible modifiers for CodeView To: Jeff Law , gcc-patches@gcc.gnu.org References: <20240618001713.24034-1-mark@harmstone.com> <20240618001713.24034-6-mark@harmstone.com> <95e88a1a-4797-460e-97ef-c4417f40eab7@gmail.com> Content-Language: en-GB From: Mark Harmstone Autocrypt: addr=mark@harmstone.com; keydata= xsBNBFp/GMsBCACtFsuHZqHWpHtHuFkNZhMpiZMChyou4X8Ueur3XyF8KM2j6TKkZ5M/72qT EycEM0iU1TYVN/Rb39gBGtRclLFVY1bx4i+aUCzh/4naRxqHgzM2SeeLWHD0qva0gIwjvoRs FP333bWrFKPh5xUmmSXBtBCVqrW+LYX4404tDKUf5wUQ9bQd2ItFRM2mU/l6TUHVY2iMql6I s94Bz5/Zh4BVvs64CbgdyYyQuI4r2tk/Z9Z8M4IjEzQsjSOfArEmb4nj27R3GOauZTO2aKlM 8821rvBjcsMk6iE/NV4SPsfCZ1jvL2UC3CnWYshsGGnfd8m2v0aLFSHZlNd+vedQOTgnABEB AAHNI01hcmsgSGFybXN0b25lIDxtYXJrQGhhcm1zdG9uZS5jb20+wsCRBBMBCAA7AhsvBQsJ CAcCBhUICQoLAgQWAgMBAh4BAheAFiEEG2JgKYgV0WRwIJAqbKyhHeAWK+0FAmRQOkICGQEA CgkQbKyhHeAWK+22wgf/dBOJ0pHdkDi5fNmWynlxteBsy3VCo0qC25DQzGItL1vEY95EV4uX re3+6eVRBy9gCKHBdFWk/rtLWKceWVZ86XfTMHgy+ZnIUkrD3XZa3oIV6+bzHgQ15rXXckiE A5N+6JeY/7hAQpSh/nOqqkNMmRkHAZ1ZA/8KzQITe1AEULOn+DphERBFD5S/EURvC8jJ5hEr lQj8Tt5BvA57sLNBmQCE19+IGFmq36EWRCRJuH0RU05p/MXPTZB78UN/oGT69UAIJAEzUzVe sN3jiXuUWBDvZz701dubdq3dEdwyrCiP+dmlvQcxVQqbGnqrVARsGCyhueRLnN7SCY1s5OHK ls7ATQRafxjLAQgAvkcSlqYuzsqLwPzuzoMzIiAwfvEW3AnZxmZn9bQ+ashB9WnkAy2FZCiI /BPwiiUjqgloaVS2dIrVFAYbynqSbjqhki+uwMliz7/jEporTDmxx7VGzdbcKSCe6rkE/72o 6t7KG0r55cmWnkdOWQ965aRnRAFY7Zzd+WLqlzeoseYsNj36RMaqNR7aL7x+kDWnwbw+jgiX tgNBcnKtqmJc04z/sQTa+sUX53syht1Iv4wkATN1W+ZvQySxHNXK1r4NkcDA9ZyFA3NeeIE6 ejiO7RyC0llKXk78t0VQPdGS6HspVhYGJJt21c5vwSzIeZaneKULaxXGwzgYFTroHD9n+QAR AQABwsGsBBgBCAAgFiEEG2JgKYgV0WRwIJAqbKyhHeAWK+0FAlp/GMsCGy4BQAkQbKyhHeAW K+3AdCAEGQEIAB0WIQR6bEAu0hwk2Q9ibSlt5UHXRQtUiwUCWn8YywAKCRBt5UHXRQtUiwdE B/9OpyjmrshY40kwpmPwUfode2Azufd3QRdthnNPAY8Tv9erwsMS3sMh+M9EP+iYJh+AIRO7 fDN/u0AWIqZhHFzCndqZp8JRYULnspXSKPmVSVRIagylKew406XcAVFpEjloUtDhziBN7ykk srAMoLASaBHZpAfp8UAGDrr8Fx1on46rDxsWbh1K1h4LEmkkVooDELjsbN9jvxr8ym8Bkt54 FcpypTOd8jkt/lJRvnKXoL3rZ83HFiUFtp/ZkveZKi53ANUaqy5/U5v0Q0Ppz9ujcRA9I/V3 B66DKMg1UjiigJG6espeIPjXjw0n9BCa9jqGICyJTIZhnbEs1yEpsM87eUIH/0UFLv0b8IZe pL/3QfiFoYSqMEAwCVDFkCt4uUVFZczKTDXTFkwm7zflvRHdy5QyVFDWMyGnTN+Bq48Gwn1M uRT/Sg37LIjAUmKRJPDkVr/DQDbyL6rTvNbA3hTBu392v0CXFsvpgRNYaT8oz7DDBUUWj2Ny 6bZCBtwr/O+CwVVqWRzKDQgVo4t1xk2ts1F0R1uHHLsX7mIgfXBYdo/y4UgFBAJH5NYUcBR+ QQcOgUUZeF2MC9i0oUaHJOIuuN2q+m9eMpnJdxVKAUQcZxDDvNjZwZh+ejsgG4Ejd2XR/T0y XFoR/dLFIhf2zxRylN1xq27M9P2t1xfQFocuYToPsVk= In-Reply-To: <95e88a1a-4797-460e-97ef-c4417f40eab7@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-6.4 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On 24/6/24 04:39, Jeff Law wrote: >> > So presumably you're freeing these objects elsewhere?  I see the free (custom_types), but I don' see where you free an subobjects.  Did I miss something? > > I'll go ahead and commit, but please double check for memory leaks. Thanks Jeff. I just realized I wrote "varible" rather than "volatile" - ah well. See patch 4 - write_custom_types loops through the custom_types linked list, and removes and frees the head until it's empty. Mark