From: <apinski@marvell.com>
To: <gcc-patches@gcc.gnu.org>
Cc: Andrew Pinski <apinski@marvell.com>
Subject: [PATCH 1/4] Add dump prints when execute_fixup_cfg removes a write only var store.
Date: Mon, 18 Oct 2021 21:54:01 -0700 [thread overview]
Message-ID: <1634619244-18969-2-git-send-email-apinski@marvell.com> (raw)
In-Reply-To: <1634619244-18969-1-git-send-email-apinski@marvell.com>
From: Andrew Pinski <apinski@marvell.com>
While debugging PR 102703, I found it was hard to figure out where
the store was being removed as there was no pass which was outputting
why the store was removed.
This adds to execute_fixup_cfg the output.
Also note most of removals happen when execute_fixup_cfg is called
from the inliner.
gcc/ChangeLog:
* tree-cfg.c (execute_fixup_cfg): Output when the statement
is removed when it is a write only var.
---
gcc/tree-cfg.c | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/gcc/tree-cfg.c b/gcc/tree-cfg.c
index 4b4b0b52d9a..b78e4564e4d 100644
--- a/gcc/tree-cfg.c
+++ b/gcc/tree-cfg.c
@@ -9737,6 +9737,13 @@ execute_fixup_cfg (void)
&& (TREE_STATIC (lhs) || DECL_EXTERNAL (lhs))
&& varpool_node::get (lhs)->writeonly)
{
+ if (dump_file && (dump_flags & TDF_DETAILS))
+ {
+ fprintf (dump_file, "Removing statement, writes"
+ " to write only var:\n");
+ print_gimple_stmt (dump_file, stmt, 0,
+ TDF_VOPS|TDF_MEMSYMS);
+ }
unlink_stmt_vdef (stmt);
gsi_remove (&gsi, true);
release_defs (stmt);
--
2.17.1
next prev parent reply other threads:[~2021-10-19 4:54 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 4:54 [PATCH 0/4] Fix PR tree-opt/102703 apinski
2021-10-19 4:54 ` apinski [this message]
2021-10-19 23:10 ` [PATCH 1/4] Add dump prints when execute_fixup_cfg removes a write only var store Jeff Law
2021-10-19 4:54 ` [PATCH 2/4] Remove outdated comment about execute_fixup_cfg apinski
2021-10-19 23:10 ` Jeff Law
2021-10-19 4:54 ` [PATCH 3/4] Factor out removal of write only stores from execute_fixup_cfg apinski
2021-10-19 23:11 ` Jeff Law
2021-10-19 4:54 ` [PATCH 4/4] Improve maybe_remove_writeonly_store to do a simple DCE for defining statement apinski
2021-10-19 23:13 ` Jeff Law
2021-10-20 6:58 ` Richard Biener
2021-10-20 19:53 ` Jeff Law
2021-10-20 19:57 ` Andrew Pinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1634619244-18969-2-git-send-email-apinski@marvell.com \
--to=apinski@marvell.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).