From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ibuclaw@gdcproject.org>
Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172])
 by sourceware.org (Postfix) with ESMTPS id 7A9913858414
 for <gcc-patches@gcc.gnu.org>; Mon, 29 Nov 2021 00:31:51 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 7A9913858414
Received: from smtp202.mailbox.org (smtp202.mailbox.org
 [IPv6:2001:67c:2050:105:465:1:4:0])
 (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest
 SHA256) (No client certificate requested)
 by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4J2R9x4Yx0zQk2F;
 Mon, 29 Nov 2021 01:31:49 +0100 (CET)
X-Virus-Scanned: amavisd-new at heinlein-support.de
Date: Mon, 29 Nov 2021 01:31:42 +0100
From: Iain Buclaw <ibuclaw@gdcproject.org>
Subject: Re: [committed 03/12] d: Insert null terminator in obstack buffers
To: gcc-patches@gcc.gnu.org, Martin =?iso-8859-2?b?TGm5a2E=?= <mliska@suse.cz>
References: <20210730110111.569140-1-ibuclaw@gdcproject.org>
 <20210730110111.569140-3-ibuclaw@gdcproject.org>
 <93b68eb8-656d-8390-6489-c0c83ddd1dc5@suse.cz>
 <1637930092.zsabwq5bl3.astroid@galago.none>
In-Reply-To: <1637930092.zsabwq5bl3.astroid@galago.none>
MIME-Version: 1.0
Message-Id: <1638145734.otop9jccm9.astroid@galago.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Status: No, score=-6.0 required=5.0 tests=BAYES_00, BODY_8BITS,
 DKIM_SIGNED, DKIM_VALID, DKIM_VALID_AU, DKIM_VALID_EF, RCVD_IN_DNSWL_LOW,
 RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.4
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on
 server2.sourceware.org
X-BeenThere: gcc-patches@gcc.gnu.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gcc-patches mailing list <gcc-patches.gcc.gnu.org>
List-Unsubscribe: <https://gcc.gnu.org/mailman/options/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=unsubscribe>
List-Archive: <https://gcc.gnu.org/pipermail/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-request@gcc.gnu.org?subject=help>
List-Subscribe: <https://gcc.gnu.org/mailman/listinfo/gcc-patches>,
 <mailto:gcc-patches-request@gcc.gnu.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Nov 2021 00:31:55 -0000

Excerpts from Iain Buclaw's message of November 26, 2021 1:35 pm:
> Excerpts from Martin Li=C5=A1ka's message of November 25, 2021 3:09 pm:
>> On 7/30/21 13:01, Iain Buclaw via Gcc-patches wrote:
>>> |Covers cases where functions that handle the extracted strings ignore =
the explicit length. This isn't something that's known to happen in the cur=
rent front-end, but the self-hosted front-end has been observed to do this =
in its conversions between D and C-style strings.|
>>=20
>> Can you please cherry pick this for gcc-11 branch as I see nasty output =
when using --verbose:
>>=20
>> $ gcc /home/marxin/Programming/gcc/gcc/testsuite/gdc.dg/attr_optimize4.d=
 -c --verbose
>> ...
>> predefs   GNU D_Version2 LittleEndian GNU_DWARF2_Exceptions GNU_StackGro=
wsDown GNU_InlineAsm D_LP64 assert D_ModuleInfo D_Exceptions D_TypeInfo all=
 X86_64 D_HardFloat Posix linux CRuntime_Glibc CppRuntime_Gcc=EF=BF=BD=EF=
=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=
=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD=
=EF=BF=BD=EF=BF=BD=EF=BF=BD=EF=BF=BD...
>>=20
>>=20
>=20
> Ouch, I'll have a look at gcc-9 and 10 too to see if they are the same.
>=20

FYI, patch applied cleanly to gcc-11 branch and has been committed.
Saw no regressions on x86_64-linux-gnu in both bootstrap and tests.

Checked other branches, however earlier releases used the dmd
front-end's OutBuffer, so are unaffected.

Iain.