From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by sourceware.org (Postfix) with ESMTPS id 522003857364 for ; Mon, 27 Jun 2022 02:47:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 522003857364 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.17.1.5/8.17.1.5) with ESMTP id 25QNq9o3024906; Mon, 27 Jun 2022 02:47:34 GMT Received: from pps.reinject (localhost [127.0.0.1]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gy1grjrcj-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jun 2022 02:47:34 +0000 Received: from m0098419.ppops.net (m0098419.ppops.net [127.0.0.1]) by pps.reinject (8.17.1.5/8.17.1.5) with ESMTP id 25R2gVU7008141; Mon, 27 Jun 2022 02:47:34 GMT Received: from ppma04ams.nl.ibm.com (63.31.33a9.ip4.static.sl-reverse.com [169.51.49.99]) by mx0b-001b2d01.pphosted.com (PPS) with ESMTPS id 3gy1grjrc0-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jun 2022 02:47:34 +0000 Received: from pps.filterd (ppma04ams.nl.ibm.com [127.0.0.1]) by ppma04ams.nl.ibm.com (8.16.1.2/8.16.1.2) with SMTP id 25R2aVE9017955; Mon, 27 Jun 2022 02:47:32 GMT Received: from b06avi18626390.portsmouth.uk.ibm.com (b06avi18626390.portsmouth.uk.ibm.com [9.149.26.192]) by ppma04ams.nl.ibm.com with ESMTP id 3gwt08t5qc-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 27 Jun 2022 02:47:32 +0000 Received: from d06av22.portsmouth.uk.ibm.com (d06av22.portsmouth.uk.ibm.com [9.149.105.58]) by b06avi18626390.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 25R2kX4P19792240 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 27 Jun 2022 02:46:33 GMT Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id EFD4C4C040; Mon, 27 Jun 2022 02:47:29 +0000 (GMT) Received: from d06av22.portsmouth.uk.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 3B45E4C044; Mon, 27 Jun 2022 02:47:28 +0000 (GMT) Received: from [9.200.41.46] (unknown [9.200.41.46]) by d06av22.portsmouth.uk.ibm.com (Postfix) with ESMTP; Mon, 27 Jun 2022 02:47:27 +0000 (GMT) Content-Type: multipart/mixed; boundary="------------1PdOVoPmata1EGnjFsWLdDpq" Message-ID: <1647e4bb-fa61-065f-d90d-b56503f44770@linux.ibm.com> Date: Mon, 27 Jun 2022 10:47:26 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:91.0) Gecko/20100101 Thunderbird/91.6.1 Subject: Re: [PATCH v3] rs6000: Adjust mov optabs for opaque modes [PR103353] Content-Language: en-US To: Segher Boessenkool Cc: Peter Bergner , GCC Patches , David Edelsohn , will schmidt References: <09c34b29-feea-d26e-2c4f-5e096ab286bc@linux.ibm.com> <20220623190619.GU25951@gate.crashing.org> <6ded988f-6684-e42e-ca82-d81ff55178d2@linux.ibm.com> <20220624164917.GX25951@gate.crashing.org> From: "Kewen.Lin" In-Reply-To: <20220624164917.GX25951@gate.crashing.org> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: aEfEGJPFFq7pW8Sf4yy0yz7XVhFGvXYS X-Proofpoint-ORIG-GUID: gw2KKn7T5o9t5MQInPgvlsrk8wrcRbxR X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.205,Aquarius:18.0.883,Hydra:6.0.517,FMLib:17.11.122.1 definitions=2022-06-27_01,2022-06-24_01,2022-06-22_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 lowpriorityscore=0 bulkscore=0 adultscore=0 priorityscore=1501 clxscore=1015 impostorscore=0 malwarescore=0 mlxscore=0 suspectscore=0 mlxlogscore=999 phishscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2204290000 definitions=main-2206270009 X-Spam-Status: No, score=-11.9 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, DKIM_VALID_EF, GIT_PATCH_0, KAM_SHORT, NICE_REPLY_A, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 Jun 2022 02:47:37 -0000 This is a multi-part message in MIME format. --------------1PdOVoPmata1EGnjFsWLdDpq Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi Segher! on 2022/6/25 00:49, Segher Boessenkool wrote: > Hi! > > On Fri, Jun 24, 2022 at 09:03:59AM +0800, Kewen.Lin wrote: >> on 2022/6/24 03:06, Segher Boessenkool wrote: >>> On Wed, May 18, 2022 at 10:07:48PM +0800, Kewen.Lin wrote: >>>> As PR103353 shows, we may want to continue to expand a MMA built-in >>>> function like a normal function, even if we have already emitted >>>> error messages about some missing required conditions. As shown in >>>> that PR, without one explicit mov optab on OOmode provided, it would >>>> call emit_move_insn recursively. >>> >>> First off: lxvp is a VSX insn, not an MMA insn. So please don't call it >>> that -- this confusion is what presumably caused the problem here, so it >>> would be good to root it out :-) >> >> I guess the "it" in "don't call it call" is for "MMA built-in function"? >> It comes from the current code: > > Your proposed commit message says "MMA built-in function". It is not > an MMA builtin, or rather, it should not be. > >>>> + /* Opaque modes are only expected to be available when MMA is supported, >>> >>> Why do people expect that? It is completely wrong. The name "opaque" >>> itself already says this is not just for MMA, but perhaps more >>> importantly, it is a basic VSX insn, doesn't touch any MMA resources, >>> and is useful in other contexts as well. >> >> ... The above statements are also based on current code, for now, the >> related things like built-in functions, mov optab, hard_regno_ok etc. >> for these two modes are guarded by TARGET_MMA. > > Opaque modes are a generic thing, not an rs6000 thing. It is important > not to conflate completely different things that just happened to > coincide some months ago (but not anymore right now even!) > >> I think I get your points here, you want to separate these opaque >> modes from MMA since the underlying lxvp/stxvp are not MMA specific, >> so those related things (bifs, mov optabs etc.) are not necessarily >> guarded under MMA. > > Yup. This can take some time of course, but in the mean time we should > stop pretending the status quo is correct. > >>> So this needs some bigger surgery. >> >> Yes, Peter may have more comments on this. > > Yes. Can you do a patch that just fixes this PR103353, without adding > more misleading comments? :-) > Many thanks for all the further explanation above! The attached patch updated the misleading comments as you pointed out and suggested, could you help to have another look? BR, Kewen --------------1PdOVoPmata1EGnjFsWLdDpq Content-Type: text/plain; charset=UTF-8; name="0001-rs6000-Adjust-mov-optabs-for-opaque-modes-PR103353.patch" Content-Disposition: attachment; filename*0="0001-rs6000-Adjust-mov-optabs-for-opaque-modes-PR103353.patc"; filename*1="h" Content-Transfer-Encoding: base64 RnJvbSBlZTQ5Y2QxNGI2OWFhYTM3M2IwYWNhNzFjNDU2MDk0NGEwYjQzZmJjIE1vbiBTZXAg MTcgMDA6MDA6MDAgMjAwMQpGcm9tOiAiS2V3ZW4uTGluIiA8bGlua3dAZ2NjLmdudS5vcmc+ CkRhdGU6IE1vbiwgMjcgSnVuIDIwMjIgMTA6NDI6MzcgKzA4MDAKU3ViamVjdDogW1BBVENI XSByczYwMDA6IEFkanVzdCBtb3Ygb3B0YWJzIGZvciBvcGFxdWUgbW9kZXMgW1BSMTAzMzUz XQoKQXMgUFIxMDMzNTMgc2hvd3MsIHdlIG1heSB3YW50IHRvIGNvbnRpbnVlIHRvIGV4cGFu ZCBidWlsdC1pbgpmdW5jdGlvbiBfX2J1aWx0aW5fdnN4X2x4dnAsIGV2ZW4gaWYgd2UgaGF2 ZSBhbHJlYWR5IGVtaXR0ZWQKZXJyb3IgbWVzc2FnZXMgYWJvdXQgc29tZSBtaXNzaW5nIHJl cXVpcmVkIGNvbmRpdGlvbnMuICBBcwpzaG93biBpbiB0aGF0IFBSLCB3aXRob3V0IG9uZSBl eHBsaWNpdCBtb3Ygb3B0YWIgb24gT09tb2RlCnByb3ZpZGVkLCBpdCB3b3VsZCBjYWxsIGVt aXRfbW92ZV9pbnNuIHJlY3Vyc2l2ZWx5LgoKU28gdGhpcyBwYXRjaCBpcyB0byBhbGxvdyB0 aGUgbW92IHBhdHRlcm4gdG8gYmUgZ2VuZXJhdGVkIGR1cmluZwpleHBhbmRpbmcgcGhhc2Ug aWYgY29tcGlsZXIgaGFzIGFscmVhZHkgc2VlbiBlcnJvcnMuCgoJUFIgdGFyZ2V0LzEwMzM1 MwoKZ2NjL0NoYW5nZUxvZzoKCgkqIGNvbmZpZy9yczYwMDAvbW1hLm1kIChkZWZpbmVfZXhw YW5kIG1vdm9vKTogTW92ZSBUQVJHRVRfTU1BIGNvbmRpdGlvbgoJY2hlY2sgdG8gcHJlcGFy YXRpb24gc3RhdGVtZW50cyBhbmQgYWRkIGhhbmRsaW5ncyBmb3IgIVRBUkdFVF9NTUEuCgko ZGVmaW5lX2V4cGFuZCBtb3Z4byk6IExpa2V3aXNlLgoKZ2NjL3Rlc3RzdWl0ZS9DaGFuZ2VM b2c6CgoJKiBnY2MudGFyZ2V0L3Bvd2VycGMvcHIxMDMzNTMuYzogTmV3IHRlc3QuCi0tLQog Z2NjL2NvbmZpZy9yczYwMDAvbW1hLm1kICAgICAgICAgICAgICAgICAgICB8IDM1ICsrKysr KysrKysrKysrKysrLS0tLQogZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L3Bvd2VycGMvcHIx MDMzNTMuYyB8IDIyICsrKysrKysrKysrKysKIDIgZmlsZXMgY2hhbmdlZCwgNTEgaW5zZXJ0 aW9ucygrKSwgNiBkZWxldGlvbnMoLSkKIGNyZWF0ZSBtb2RlIDEwMDY0NCBnY2MvdGVzdHN1 aXRlL2djYy50YXJnZXQvcG93ZXJwYy9wcjEwMzM1My5jCgpkaWZmIC0tZ2l0IGEvZ2NjL2Nv bmZpZy9yczYwMDAvbW1hLm1kIGIvZ2NjL2NvbmZpZy9yczYwMDAvbW1hLm1kCmluZGV4IGEx ODNiNmExNjhhLi5hOWNmNTlkNjhiNSAxMDA2NDQKLS0tIGEvZ2NjL2NvbmZpZy9yczYwMDAv bW1hLm1kCisrKyBiL2djYy9jb25maWcvcnM2MDAwL21tYS5tZApAQCAtMjY4LDEwICsyNjgs MjMgQEAgKGRlZmluZV9pbnRfYXR0ciBhdnZpNGk0aTQJWyhVTlNQRUNfTU1BX1BNWFZJOEdF UjRQUAkicG14dmk4Z2VyNHBwIikKIChkZWZpbmVfZXhwYW5kICJtb3ZvbyIKICAgWyhzZXQg KG1hdGNoX29wZXJhbmQ6T08gMCAibm9uaW1tZWRpYXRlX29wZXJhbmQiKQogCShtYXRjaF9v cGVyYW5kOk9PIDEgImlucHV0X29wZXJhbmQiKSldCi0gICJUQVJHRVRfTU1BIgorICAiIgog ewotICByczYwMDBfZW1pdF9tb3ZlIChvcGVyYW5kc1swXSwgb3BlcmFuZHNbMV0sIE9PbW9k ZSk7Ci0gIERPTkU7CisgIGlmIChUQVJHRVRfTU1BKSB7CisgICAgcnM2MDAwX2VtaXRfbW92 ZSAob3BlcmFuZHNbMF0sIG9wZXJhbmRzWzFdLCBPT21vZGUpOworICAgIERPTkU7CisgIH0K KyAgLyogUFIxMDMzNTMgc2hvd3Mgd2UgbWF5IHdhbnQgdG8gY29udGludWUgdG8gZXhwYW5k IHRoZSBfX2J1aWx0aW5fdnN4X2x4dnAKKyAgICAgYnVpbHQtaW4gZnVuY3Rpb24sIGV2ZW4g aWYgd2UgaGF2ZSBhbHJlYWR5IGVtaXR0ZWQgZXJyb3IgbWVzc2FnZXMgYWJvdXQKKyAgICAg c29tZSBtaXNzaW5nIHJlcXVpcmVkIGNvbmRpdGlvbnMuICBBcyBzaG93biBpbiB0aGF0IFBS LCB3aXRob3V0IG9uZQorICAgICBleHBsaWNpdCBtb3Ygb3B0YWIgb24gT09tb2RlIHByb3Zp ZGVkLCBpdCB3b3VsZCBjYWxsIGVtaXRfbW92ZV9pbnNuCisgICAgIHJlY3Vyc2l2ZWx5LiAg U28gd2UgYWxsb3cgdGhpcyBwYXR0ZXJuIHRvIGJlIGdlbmVyYXRlZCB3aGVuIHdlIGFyZQor ICAgICBleHBhbmRpbmcgdG8gUlRMIGFuZCBoYXZlIHNlZW4gZXJyb3JzLiAgSXQgd291bGQg bm90IGNhdXNlIGZ1cnRoZXIgSUNFcworICAgICBhcyB0aGUgY29tcGlsYXRpb24gd291bGQg c3RvcCBzb29uIGFmdGVyIGV4cGFuZGluZy4gICovCisgIGVsc2UgaWYgKGN1cnJlbnRseV9l eHBhbmRpbmdfdG9fcnRsICYmIHNlZW5fZXJyb3IgKCkpCisgICAgOworICBlbHNlCisgICAg Z2NjX3VucmVhY2hhYmxlICgpOwogfSkKIAogKGRlZmluZV9pbnNuX2FuZF9zcGxpdCAiKm1v dm9vIgpAQCAtMzAwLDEwICszMTMsMjAgQEAgKGRlZmluZV9pbnNuX2FuZF9zcGxpdCAiKm1v dm9vIgogKGRlZmluZV9leHBhbmQgIm1vdnhvIgogICBbKHNldCAobWF0Y2hfb3BlcmFuZDpY TyAwICJub25pbW1lZGlhdGVfb3BlcmFuZCIpCiAJKG1hdGNoX29wZXJhbmQ6WE8gMSAiaW5w dXRfb3BlcmFuZCIpKV0KLSAgIlRBUkdFVF9NTUEiCisgICIiCiB7Ci0gIHJzNjAwMF9lbWl0 X21vdmUgKG9wZXJhbmRzWzBdLCBvcGVyYW5kc1sxXSwgWE9tb2RlKTsKLSAgRE9ORTsKKyAg aWYgKFRBUkdFVF9NTUEpIHsKKyAgICByczYwMDBfZW1pdF9tb3ZlIChvcGVyYW5kc1swXSwg b3BlcmFuZHNbMV0sIFhPbW9kZSk7CisgICAgRE9ORTsKKyAgfQorICAvKiBQUjEwMzM1MyBz aG93cyB3ZSBtYXkgd2FudCB0byBjb250aW51ZSB0byBleHBhbmQgdGhlIF9fYnVpbHRpbl92 c3hfbHh2cAorICAgICBidWlsdC1pbiBmdW5jdGlvbiwgZXZlbiBpZiB3ZSBoYXZlIGFscmVh ZHkgZW1pdHRlZCBlcnJvciBtZXNzYWdlcyBhYm91dAorICAgICBzb21lIG1pc3NpbmcgcmVx dWlyZWQgY29uZGl0aW9ucy4gIFNvIGRvIHRoZSBzYW1lIGhhbmRsaW5ncyBmb3IgWE9tb2Rl CisgICAgIGFzIE9PbW9kZSBoZXJlLiAgKi8KKyAgZWxzZSBpZiAoY3VycmVudGx5X2V4cGFu ZGluZ190b19ydGwgJiYgc2Vlbl9lcnJvciAoKSkKKyAgICA7CisgIGVsc2UKKyAgICBnY2Nf dW5yZWFjaGFibGUgKCk7CiB9KQogCiAoZGVmaW5lX2luc25fYW5kX3NwbGl0ICIqbW92eG8i CmRpZmYgLS1naXQgYS9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvcG93ZXJwYy9wcjEwMzM1 My5jIGIvZ2NjL3Rlc3RzdWl0ZS9nY2MudGFyZ2V0L3Bvd2VycGMvcHIxMDMzNTMuYwpuZXcg ZmlsZSBtb2RlIDEwMDY0NAppbmRleCAwMDAwMDAwMDAwMC4uNWQ1MTlmYjFiN2IKLS0tIC9k ZXYvbnVsbAorKysgYi9nY2MvdGVzdHN1aXRlL2djYy50YXJnZXQvcG93ZXJwYy9wcjEwMzM1 My5jCkBAIC0wLDAgKzEsMjIgQEAKKy8qIHsgZGctcmVxdWlyZS1lZmZlY3RpdmUtdGFyZ2V0 IHBvd2VycGNfYWx0aXZlY19vayB9ICovCisvKiBJZiB0aGUgZGVmYXVsdCBjcHUgdHlwZSBp cyBwb3dlcjEwIG9yIGxhdGVyLCBNTUEgaXMgZW5hYmxlZCBieSBkZWZhdWx0LgorICAgVG8g a2VlcCB0aGUgdGVzdCBwb2ludCBhdmFpbGFibGUgYWxsIHRoZSB0aW1lLCB0aGlzIGNhc2Ug c3BlY2lmaWVzCisgICAtbWRlamFnbnUtY3B1PXBvd2VyNiB0byBtYWtlIGl0IGJlIHRlc3Rl ZCB3aXRob3V0IE1NQS4gICovCisvKiB7IGRnLW9wdGlvbnMgIi1tYWx0aXZlYyAtbWRlamFn bnUtY3B1PXBvd2VyNiIgfSAqLworCisvKiBWZXJpZnkgdGhlcmUgaXMgbm8gSUNFIGFuZCBk b24ndCBjaGVjayB0aGUgZXJyb3IgbWVzc2FnZXMgb24gTU1BCisgICByZXF1aXJlbWVudCBz aW5jZSB0aGV5IGNvdWxkIGJlIGZyYWdpbGUgYW5kIGFyZSBub3QgdGVzdCBwb2ludHMKKyAg IG9mIHRoaXMgY2FzZS4gICovCisvKiB7IGRnLWV4Y2Vzcy1lcnJvcnMgInByMTAzMzUzIiB9 ICovCisKK3ZvaWQKK2ZvbyAoX192ZWN0b3JfcGFpciAqZHN0LCBkb3VibGUgKngpCit7Cisg IGRzdFswXSA9IF9fYnVpbHRpbl92c3hfbHh2cCAoMCwgKF9fdmVjdG9yX3BhaXIgKikodm9p ZCAqKXgpOworfQorCit2b2lkCitiYXIgKF9fdmVjdG9yX3BhaXIgKnNyYywgZG91YmxlICp4 KQoreworICBfX2J1aWx0aW5fdnN4X3N0eHZwIChzcmNbMF0sIDAsIChfX3ZlY3Rvcl9wYWly ICopKHZvaWQgKil4KTsKK30KLS0gCjIuMzIuMAoK --------------1PdOVoPmata1EGnjFsWLdDpq--