From: Eric Botcazou <ebotcazou@adacore.com>
To: "Richard Earnshaw (lists)" <Richard.Earnshaw@arm.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [ARM] Fix ICE during thunk generation with -mlong-calls
Date: Tue, 18 Sep 2018 09:18:00 -0000 [thread overview]
Message-ID: <1672454.sA1WPEYBBg@polaris> (raw)
In-Reply-To: <ced41c58-4ce6-487d-9c88-24856809e8fa@arm.com>
> this seems to contradict your statement above about having to work
> harder to fix up minipools.
Why? Fixing up minipools is done in the generic ARM reorg pass, not in the
Thumb reorg pass(es).
> Why do we need a barrier here unconditionally (ie in the non-longcall case)?
We don't, but it doesn't harm to put it either. For example, the x86, PowerPC
and SPARC ports always do it.
--
Eric Botcazou
next prev parent reply other threads:[~2018-09-18 9:02 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-09-17 11:23 Eric Botcazou
2018-09-17 13:14 ` Richard Earnshaw (lists)
2018-09-18 9:18 ` Eric Botcazou [this message]
2018-09-18 10:51 ` Richard Earnshaw (lists)
2018-09-24 9:26 ` Eric Botcazou
2018-09-25 14:31 ` Richard Earnshaw (lists)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1672454.sA1WPEYBBg@polaris \
--to=ebotcazou@adacore.com \
--cc=Richard.Earnshaw@arm.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).