From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=mmFA=5U=gdcproject.org=ibuclaw@sourceware.org>
Received: from mout-p-202.mailbox.org (mout-p-202.mailbox.org [80.241.56.172])
	by sourceware.org (Postfix) with ESMTPS id 6751E3858D32
	for <gcc-patches@gcc.gnu.org>; Mon, 23 Jan 2023 13:21:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 6751E3858D32
Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=gdcproject.org
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gdcproject.org
Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:b231:465::1])
	(using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)
	 key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256)
	(No client certificate requested)
	by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4P0rNZ1jkkz9sTC;
	Mon, 23 Jan 2023 14:21:50 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gdcproject.org;
	s=MBO0001; t=1674480110;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=blRkYiGYObxfqzg0eKpoO9cQJVksqzngtIF8d6CDncE=;
	b=FOpxGSLCq3FOwm4toUThlmLPcxC7+S2o4uEVM4Ps8RKX5+awl4Eg6UuuXNXO6Z/PPrkKIP
	Pep6wUuyTFflfwbJwoL0XJWZIxLeq6oM/nudI7WdJQ1zlb38zTqj7u2uFLPedI0tSh5/eS
	JihvMoH9+1+cKAGkLGscVl8SaY3azMwCFL850lkQiJ19Uf6jUqJfyMgbj68vJ/CS8Doue0
	cIYNsTYYXQAJKwvd4C10QUWEl1OTL0cnoSe3A5A82EACdBpZLfySM77yqpQymbNixY+Hee
	HcqvPdjF2Kv6bFwx7CPuOptbA5e5MnoRRaqCK+uue30gWMpmjWm3PxbzSzEmPw==
Date: Mon, 23 Jan 2023 14:21:46 +0100
From: Iain Buclaw <ibuclaw@gdcproject.org>
Subject: Re: [PATCH] IBM zSystems: Fix TARGET_D_CPU_VERSIONS
To: gcc-patches@gcc.gnu.org, krebbel@linux.ibm.com,
	Stefan Schulze Frielinghaus <stefansf@linux.ibm.com>
References: <20230113175428.1771219-1-stefansf@linux.ibm.com>
In-Reply-To: <20230113175428.1771219-1-stefansf@linux.ibm.com>
MIME-Version: 1.0
Message-Id: <1674477296.avq4a7yu1w.astroid@pulse.none>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Rspamd-Queue-Id: 4P0rNZ1jkkz9sTC
X-Spam-Status: No, score=-7.7 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_LOW,SPF_HELO_NONE,SPF_PASS,TXREP autolearn=ham autolearn_force=no version=3.4.6
X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org
List-Id: <gcc-patches.gcc.gnu.org>

Excerpts from Stefan Schulze Frielinghaus via Gcc-patches's message of Janu=
ar 13, 2023 6:54 pm:
> In the context of D the interpretation of S390, S390X, and SystemZ is a
> bit fuzzy.  The wording S390X was wrongly deprecated in favour of
> SystemZ by commit
> https://github.com/dlang/dlang.org/commit/3b50a4c3faf01c32234d0ef8be5f829=
15a61c23f
> Thus, SystemZ is used for 64-bit targets, now, and S390 for 31-bit
> targets.  However, in TARGET_D_CPU_VERSIONS depending on TARGET_ZARCH we
> set the CPU version to SystemZ.  This is also the case if compiled for
> 31-bit targets leading to the following error:
>=20
> libphobos/libdruntime/core/sys/posix/sys/stat.d:967:13: error: static ass=
ert:  '96u =3D=3D 144u' is false
>   967 |             static assert(stat_t.sizeof =3D=3D 144);
>       |             ^
>=20

So that I follow, there are three possible combinations?

ESA 31-bit (S390)
ESA 64-bit (what was S390X)
z/Arch 64-bit (SystemZ)

> Thus in order to keep this patch simple I went for keeping SystemZ for
> 64-bit targets and S390, as usual, for 31-bit targets and dropped the
> distinction between ESA and z/Architecture.
>=20
> Bootstrapped and regtested on IBM zSystems.  Ok for mainline?
>=20

OK by me.  Maybe keep both S390X and SystemZ for TARGET_64BIT? There's
only ever been a binary distinction as far as I'm aware.

Iain.