From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTPS id 99A313851167 for ; Thu, 29 Sep 2022 22:35:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 99A313851167 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1664490914; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type; bh=o0zb2iUDlZd6TIfMUhNf7GQBvrX+ZuMSNN6q2ZO+oVo=; b=gYtLJNeMZ83JySvm7c+r7Jgvq4NDs4GKvEAVDHsLdQLn2Qv1dOC3YrKqS4YXD6cRmtzH9b ZI464JpTctiq+UI72C4VcbteSv+ZfRRg5DYz6zoP05RZLsEWHLNmgUgNzc73wTfjbor5vV wjmJ+dMAf1GItrmar7jcK2iDumnnqe0= Received: from mail-qv1-f70.google.com (mail-qv1-f70.google.com [209.85.219.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-600-P8_u3HTRMH2fJCzaxR_K8Q-1; Thu, 29 Sep 2022 18:35:12 -0400 X-MC-Unique: P8_u3HTRMH2fJCzaxR_K8Q-1 Received: by mail-qv1-f70.google.com with SMTP id em2-20020ad44f82000000b004af5338777cso1875809qvb.4 for ; Thu, 29 Sep 2022 15:35:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=subject:from:cc:to:content-language:user-agent:mime-version:date :message-id:x-gm-message-state:from:to:cc:subject:date; bh=jaY3e/Tfqo8NlMtUVih//wnRiRZ1abJBF0f02NOIo4k=; b=KMNI8coh9QUb27IJzpPRM85IqC6yjqXVzcSKkCPQLSExqrX9kc/JRI42CPPTdHSC9m j3QxUl5RJ7o1RJq8GzQ2pTtvJq3SQhSwprtszUTxwO4kSSPYqKaafxe5WAfJlST+Irvh XLP2D6gtmowHIGhHGC1uGcGaLH3uE789PU9ILkmUeSf94dRAjI5avAA9MvW+xMmoxEqE BPCFFvdP+IBXMOwYQ8/nSioPR9PKk0bZ2D47FqQNE2OWlKaqL3YyjoGoO8WZ/Gg/1a/S 3avsPu61RJACb+rsvZhb33Hxj+F5ugqH9eqlPhZmMWDWxKZJdJ8v/FwS3px3zia4heYI OVvQ== X-Gm-Message-State: ACrzQf2wpGrzDnx4YJZNayCvudCCodfELN1I6/ok0OP2MIrxicK91Mtw Xsg4wIttPZVZJoGKPCrHrqfGzoOYgpD5Idn1rhdPqnAGZmYJj3/8T8y2FJICt/6l2qxLvwR8k6J piWprHm+1EJtlVF9laN5DzkUmDiN7I8adJ/NHz6z94jwXVDK/F6r1883Sjx4rPZGSiUqtzA== X-Received: by 2002:a05:622a:1482:b0:35b:afa9:d8a3 with SMTP id t2-20020a05622a148200b0035bafa9d8a3mr4512657qtx.621.1664490911975; Thu, 29 Sep 2022 15:35:11 -0700 (PDT) X-Google-Smtp-Source: AMsMyM7ZwrdoIKhGTzKTMZF8Ww49xOCDXp63ivFZsSLuoSlYPiatbSjuWvEoCvDNpG+E4xVHy+YTKw== X-Received: by 2002:a05:622a:1482:b0:35b:afa9:d8a3 with SMTP id t2-20020a05622a148200b0035bafa9d8a3mr4512643qtx.621.1664490911684; Thu, 29 Sep 2022 15:35:11 -0700 (PDT) Received: from ?IPV6:2607:fea8:a263:f600::3dbe? ([2607:fea8:a263:f600::3dbe]) by smtp.gmail.com with ESMTPSA id l5-20020ac80785000000b0035cf31005e2sm302571qth.73.2022.09.29.15.35.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 15:35:10 -0700 (PDT) Message-ID: <16763009-abeb-5785-80fc-40cd755fef0c@redhat.com> Date: Thu, 29 Sep 2022 18:35:09 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.1 To: gcc-patches Cc: "hernandez, aldy" From: Andrew MacLeod Subject: [PATCH] Audit op1_range and op2_range for undefined LHS. X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: multipart/mixed; boundary="------------iKaxGk9tSEqOabJUUoAevFw3" Content-Language: en-US X-Spam-Status: No, score=-12.5 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,GIT_PATCH_0,RCVD_IN_DNSWL_NONE,SPF_HELO_NONE,SPF_NONE,TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: This is a multi-part message in MIME format. --------------iKaxGk9tSEqOabJUUoAevFw3 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit If the LHS is undefined, GORI should not proceed further.  There are a few places where this happens, and a few potential traps. Most haven't been an issue up until now, but forthcoming changes tend to cause them to trigger more often. Bootstrapped on x86_64-pc-linux-gnu with no regressions.  Pushed. Andrew --------------iKaxGk9tSEqOabJUUoAevFw3 Content-Type: text/x-patch; charset=UTF-8; name="0002-Audit-op1_range-and-op2_range-for-undefined-LHS.patch" Content-Disposition: attachment; filename*0="0002-Audit-op1_range-and-op2_range-for-undefined-LHS.patch" Content-Transfer-Encoding: base64 RnJvbSBiZWIxMzVhYWFiYWM0NzcxYTQwNWI4ZDQxYWQzNzI4NWVlNmY4NzJlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBBbmRyZXcgTWFjTGVvZCA8YW1hY2xlb2RAcmVkaGF0LmNvbT4K RGF0ZTogVHVlLCAyNyBTZXAgMjAyMiAxOToxMjowNiAtMDQwMApTdWJqZWN0OiBbUEFUQ0ggMi82 XSBBdWRpdCBvcDFfcmFuZ2UgYW5kIG9wMl9yYW5nZSBmb3IgdW5kZWZpbmVkIExIUy4KCklmIHRo ZSBMSFMgaXMgdW5kZWZpbmVkLCBHT1JJIHNob3VsZCBjZWFzZSBsb29raW5nLiBUaGVyZSBhcmUg bnVtZXJvdXMKcGxhY2VzIHdoZXJlIHRoaXMgaGFwcGVucywgYW5kIGEgZmV3IHBvdGVudGlhbCB0 cmFwcy4KCgkqIHJhbmdlLW9wLmNjIChvcGVyYXRvcl9taW51czo6b3AyX3JhbmdlKTogQ2hlY2sg Zm9yIHVuZGVmaW5lZC4KCShvcGVyYXRvcl9tdWx0OjpvcDFfcmFuZ2UpOiBEaXR0by4KCShvcGVy YXRvcl9leGFjdF9kaXZpZGU6Om9wMV9yYW5nZSk6IERpdHRvLgoJKG9wZXJhdG9yX2xzaGlmdDo6 b3AxX3JhbmdlKTogRGl0dG8uCgkob3BlcmF0b3JfcnNoaWZ0OjpvcDFfcmFuZ2UpOiBEaXR0by4K CShvcGVyYXRvcl9jYXN0OjpvcDFfcmFuZ2UpOiBEaXR0by4KCShvcGVyYXRvcl9iaXR3aXNlX2Fu ZDo6b3AxX3JhbmdlKTogRGl0dG8uCgkob3BlcmF0b3JfYml0d2lzZV9vcjo6b3AxX3JhbmdlKTog RGl0dG8uCgkob3BlcmF0b3JfdHJ1bmNfbW9kOjpvcDFfcmFuZ2UpOiBEaXR0by4KCShvcGVyYXRv cl90cnVuY19tb2Q6Om9wMl9yYW5nZSk6IERpdHRvLgoJKG9wZXJhdG9yX2JpdHdpc2Vfbm90Ojpv cDFfcmFuZ2UpOiBEaXR0by4KCShwb2ludGVyX29yX29wZXJhdG9yOjpvcDFfcmFuZ2UpOiBEaXR0 by4KCShyYW5nZV9vcF9oYW5kbGVyOjpvcDFfcmFuZ2UpOiBEaXR0by4KCShyYW5nZV9vcF9oYW5k bGVyOjpvcDJfcmFuZ2UpOiBEaXR0by4KLS0tCiBnY2MvcmFuZ2Utb3AuY2MgfCAyOSArKysrKysr KysrKysrKysrKysrKysrKysrKysrKwogMSBmaWxlIGNoYW5nZWQsIDI5IGluc2VydGlvbnMoKykK CmRpZmYgLS1naXQgYS9nY2MvcmFuZ2Utb3AuY2MgYi9nY2MvcmFuZ2Utb3AuY2MKaW5kZXggMDcy ZWJkMzIxMDkuLjliYjA0YzM2MWQwIDEwMDY0NAotLS0gYS9nY2MvcmFuZ2Utb3AuY2MKKysrIGIv Z2NjL3JhbmdlLW9wLmNjCkBAIC0xNDgxLDYgKzE0ODEsOCBAQCBvcGVyYXRvcl9taW51czo6b3Ay X3JhbmdlIChpcmFuZ2UgJnIsIHRyZWUgdHlwZSwKIAkJCSAgIGNvbnN0IGlyYW5nZSAmb3AxLAog CQkJICAgcmVsYXRpb25fa2luZCByZWwgQVRUUklCVVRFX1VOVVNFRCkgY29uc3QKIHsKKyAgaWYg KGxocy51bmRlZmluZWRfcCAoKSkKKyAgICByZXR1cm4gZmFsc2U7CiAgIHJldHVybiBmb2xkX3Jh bmdlIChyLCB0eXBlLCBvcDEsIGxocyk7CiB9CiAKQEAgLTE2NTAsNiArMTY1Miw4IEBAIG9wZXJh dG9yX211bHQ6Om9wMV9yYW5nZSAoaXJhbmdlICZyLCB0cmVlIHR5cGUsCiAJCQkgIHJlbGF0aW9u X2tpbmQgcmVsIEFUVFJJQlVURV9VTlVTRUQpIGNvbnN0CiB7CiAgIHRyZWUgb2Zmc2V0OworICBp ZiAobGhzLnVuZGVmaW5lZF9wICgpKQorICAgIHJldHVybiBmYWxzZTsKIAogICAvLyBXZSBjYW4n dCBzb2x2ZSAwID0gT1AxICogTiBieSBkaXZpZGluZyBieSBOIHdpdGggYSB3cmFwcGluZyB0eXBl LgogICAvLyBGb3IgZXhhbXBsZTogRm9yIDAgPSBPUDEgKiAyLCBPUDEgY291bGQgYmUgMCwgb3Ig TUFYSU5ULCB3aGVyZWFzCkBAIC0xOTAyLDYgKzE5MDYsOCBAQCBvcGVyYXRvcl9leGFjdF9kaXZp ZGU6Om9wMV9yYW5nZSAoaXJhbmdlICZyLCB0cmVlIHR5cGUsCiAJCQkJICBjb25zdCBpcmFuZ2Ug Jm9wMiwKIAkJCQkgIHJlbGF0aW9uX2tpbmQgcmVsIEFUVFJJQlVURV9VTlVTRUQpIGNvbnN0CiB7 CisgIGlmIChsaHMudW5kZWZpbmVkX3AgKCkpCisgICAgcmV0dXJuIGZhbHNlOwogICB0cmVlIG9m ZnNldDsKICAgLy8gWzIsIDRdID0gb3AxIC8gWzMsM10gICBzaW5jZSBpdHMgZXhhY3QgZGl2aWRl LCBubyBuZWVkIHRvIHdvcnJ5IGFib3V0CiAgIC8vIHJlbWFpbmRlcnMgaW4gdGhlIGVuZHBvaW50 cywgc28gb3AxID0gWzIsNF0gKiBbMywzXSA9IFs2LDEyXS4KQEAgLTIxMTEsNiArMjExNyw4IEBA IG9wZXJhdG9yX2xzaGlmdDo6b3AxX3JhbmdlIChpcmFuZ2UgJnIsCiAJCQkgICAgY29uc3QgaXJh bmdlICZvcDIsCiAJCQkgICAgcmVsYXRpb25fa2luZCByZWwgQVRUUklCVVRFX1VOVVNFRCkgY29u c3QKIHsKKyAgaWYgKGxocy51bmRlZmluZWRfcCAoKSkKKyAgICByZXR1cm4gZmFsc2U7CiAgIHRy ZWUgc2hpZnRfYW1vdW50OwogCiAgIGlmICghbGhzLmNvbnRhaW5zX3AgKGJ1aWxkX3plcm9fY3N0 ICh0eXBlKSkpCkBAIC0yMTgzLDYgKzIxOTEsOCBAQCBvcGVyYXRvcl9yc2hpZnQ6Om9wMV9yYW5n ZSAoaXJhbmdlICZyLAogCQkJICAgIHJlbGF0aW9uX2tpbmQgcmVsIEFUVFJJQlVURV9VTlVTRUQp IGNvbnN0CiB7CiAgIHRyZWUgc2hpZnQ7CisgIGlmIChsaHMudW5kZWZpbmVkX3AgKCkpCisgICAg cmV0dXJuIGZhbHNlOwogICBpZiAob3AyLnNpbmdsZXRvbl9wICgmc2hpZnQpKQogICAgIHsKICAg ICAgIC8vIElnbm9yZSBub25zZW5zaWNhbCBzaGlmdHMuCkBAIC0yNDAxLDYgKzI0MTEsOCBAQCBv cGVyYXRvcl9jYXN0OjpvcDFfcmFuZ2UgKGlyYW5nZSAmciwgdHJlZSB0eXBlLAogCQkJICBjb25z dCBpcmFuZ2UgJm9wMiwKIAkJCSAgcmVsYXRpb25fa2luZCByZWwgQVRUUklCVVRFX1VOVVNFRCkg Y29uc3QKIHsKKyAgaWYgKGxocy51bmRlZmluZWRfcCAoKSkKKyAgICByZXR1cm4gZmFsc2U7CiAg IHRyZWUgbGhzX3R5cGUgPSBsaHMudHlwZSAoKTsKICAgZ2NjX2NoZWNraW5nX2Fzc2VydCAodHlw ZXNfY29tcGF0aWJsZV9wIChvcDIudHlwZSgpLCB0eXBlKSk7CiAKQEAgLTI5MzYsNiArMjk0OCw4 IEBAIG9wZXJhdG9yX2JpdHdpc2VfYW5kOjpvcDFfcmFuZ2UgKGlyYW5nZSAmciwgdHJlZSB0eXBl LAogCQkJCSBjb25zdCBpcmFuZ2UgJm9wMiwKIAkJCQkgcmVsYXRpb25fa2luZCByZWwgQVRUUklC VVRFX1VOVVNFRCkgY29uc3QKIHsKKyAgaWYgKGxocy51bmRlZmluZWRfcCAoKSkKKyAgICByZXR1 cm4gZmFsc2U7CiAgIGlmICh0eXBlc19jb21wYXRpYmxlX3AgKHR5cGUsIGJvb2xlYW5fdHlwZV9u b2RlKSkKICAgICByZXR1cm4gb3BfbG9naWNhbF9hbmQub3AxX3JhbmdlIChyLCB0eXBlLCBsaHMs IG9wMik7CiAKQEAgLTMxMTIsNiArMzEyNiw4IEBAIG9wZXJhdG9yX2JpdHdpc2Vfb3I6Om9wMV9y YW5nZSAoaXJhbmdlICZyLCB0cmVlIHR5cGUsCiAJCQkJY29uc3QgaXJhbmdlICZvcDIsCiAJCQkJ cmVsYXRpb25fa2luZCByZWwgQVRUUklCVVRFX1VOVVNFRCkgY29uc3QKIHsKKyAgaWYgKGxocy51 bmRlZmluZWRfcCAoKSkKKyAgICByZXR1cm4gZmFsc2U7CiAgIC8vIElmIHRoaXMgaXMgcmVhbGx5 IGEgbG9naWNhbCB3aV9mb2xkLCBjYWxsIHRoYXQuCiAgIGlmICh0eXBlc19jb21wYXRpYmxlX3Ag KHR5cGUsIGJvb2xlYW5fdHlwZV9ub2RlKSkKICAgICByZXR1cm4gb3BfbG9naWNhbF9vci5vcDFf cmFuZ2UgKHIsIHR5cGUsIGxocywgb3AyKTsKQEAgLTMzNjEsNiArMzM3Nyw4IEBAIG9wZXJhdG9y X3RydW5jX21vZDo6b3AxX3JhbmdlIChpcmFuZ2UgJnIsIHRyZWUgdHlwZSwKIAkJCSAgICAgICBj b25zdCBpcmFuZ2UgJiwKIAkJCSAgICAgICByZWxhdGlvbl9raW5kIHJlbCBBVFRSSUJVVEVfVU5V U0VEKSBjb25zdAogeworICBpZiAobGhzLnVuZGVmaW5lZF9wICgpKQorICAgIHJldHVybiBmYWxz ZTsKICAgLy8gUFIgOTEwMjkuCiAgIHNpZ25vcCBzaWduID0gVFlQRV9TSUdOICh0eXBlKTsKICAg dW5zaWduZWQgcHJlYyA9IFRZUEVfUFJFQ0lTSU9OICh0eXBlKTsKQEAgLTMzODUsNiArMzQwMyw4 IEBAIG9wZXJhdG9yX3RydW5jX21vZDo6b3AyX3JhbmdlIChpcmFuZ2UgJnIsIHRyZWUgdHlwZSwK IAkJCSAgICAgICBjb25zdCBpcmFuZ2UgJiwKIAkJCSAgICAgICByZWxhdGlvbl9raW5kIHJlbCBB VFRSSUJVVEVfVU5VU0VEKSBjb25zdAogeworICBpZiAobGhzLnVuZGVmaW5lZF9wICgpKQorICAg IHJldHVybiBmYWxzZTsKICAgLy8gUFIgOTEwMjkuCiAgIHNpZ25vcCBzaWduID0gVFlQRV9TSUdO ICh0eXBlKTsKICAgdW5zaWduZWQgcHJlYyA9IFRZUEVfUFJFQ0lTSU9OICh0eXBlKTsKQEAgLTM1 MTMsNiArMzUzMyw4IEBAIG9wZXJhdG9yX2JpdHdpc2Vfbm90OjpvcDFfcmFuZ2UgKGlyYW5nZSAm ciwgdHJlZSB0eXBlLAogCQkJCSBjb25zdCBpcmFuZ2UgJm9wMiwKIAkJCQkgcmVsYXRpb25fa2lu ZCByZWwgQVRUUklCVVRFX1VOVVNFRCkgY29uc3QKIHsKKyAgaWYgKGxocy51bmRlZmluZWRfcCAo KSkKKyAgICByZXR1cm4gZmFsc2U7CiAgIGlmICh0eXBlc19jb21wYXRpYmxlX3AgKHR5cGUsIGJv b2xlYW5fdHlwZV9ub2RlKSkKICAgICByZXR1cm4gb3BfbG9naWNhbF9ub3Qub3AxX3JhbmdlIChy LCB0eXBlLCBsaHMsIG9wMik7CiAKQEAgLTM5OTksNiArNDAyMSw4IEBAIHBvaW50ZXJfb3Jfb3Bl cmF0b3I6Om9wMV9yYW5nZSAoaXJhbmdlICZyLCB0cmVlIHR5cGUsCiAJCQkJY29uc3QgaXJhbmdl ICZvcDIgQVRUUklCVVRFX1VOVVNFRCwKIAkJCQlyZWxhdGlvbl9raW5kIHJlbCBBVFRSSUJVVEVf VU5VU0VEKSBjb25zdAogeworICBpZiAobGhzLnVuZGVmaW5lZF9wICgpKQorICAgIHJldHVybiBm YWxzZTsKICAgaWYgKGxocy56ZXJvX3AgKCkpCiAgICAgewogICAgICAgdHJlZSB6ZXJvID0gYnVp bGRfemVyb19jc3QgKHR5cGUpOwpAQCAtNDIzMCw2ICs0MjU0LDkgQEAgcmFuZ2Vfb3BfaGFuZGxl cjo6b3AxX3JhbmdlICh2cmFuZ2UgJnIsIHRyZWUgdHlwZSwKIAkJCSAgICAgcmVsYXRpb25fa2lu ZCByZWwpIGNvbnN0CiB7CiAgIGdjY19jaGVja2luZ19hc3NlcnQgKG1fdmFsaWQpOworCisgIGlm IChsaHMudW5kZWZpbmVkX3AgKCkpCisgICAgcmV0dXJuIGZhbHNlOwogICBpZiAobV9pbnQpCiAg ICAgcmV0dXJuIG1faW50LT5vcDFfcmFuZ2UgKGFzX2EgPGlyYW5nZT4gKHIpLCB0eXBlLAogCQkJ ICAgICBhc19hIDxpcmFuZ2U+IChsaHMpLApAQCAtNDI1MSw2ICs0Mjc4LDggQEAgcmFuZ2Vfb3Bf aGFuZGxlcjo6b3AyX3JhbmdlICh2cmFuZ2UgJnIsIHRyZWUgdHlwZSwKIAkJCSAgICAgcmVsYXRp b25fa2luZCByZWwpIGNvbnN0CiB7CiAgIGdjY19jaGVja2luZ19hc3NlcnQgKG1fdmFsaWQpOwor ICBpZiAobGhzLnVuZGVmaW5lZF9wICgpKQorICAgIHJldHVybiBmYWxzZTsKICAgaWYgKG1faW50 KQogICAgIHJldHVybiBtX2ludC0+b3AyX3JhbmdlIChhc19hIDxpcmFuZ2U+IChyKSwgdHlwZSwK IAkJCSAgICAgYXNfYSA8aXJhbmdlPiAobGhzKSwKLS0gCjIuMzcuMwoK --------------iKaxGk9tSEqOabJUUoAevFw3--