public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Eric Botcazou <ebotcazou@adacore.com>
To: gcc-patches@gcc.gnu.org
Cc: Douglas B Rupp <rupp@adacore.com>
Subject: [ARM] Resurrect VxWorks port
Date: Fri, 31 May 2013 17:58:00 -0000	[thread overview]
Message-ID: <1683552.y1sNTR3Ayg@polaris> (raw)

[-- Attachment #1: Type: text/plain, Size: 2028 bytes --]

Hi,

as diagnosed by Doug, the VxWorks port cannot be built since:

2011-05-18  Joseph Myers  <joseph@codesourcery.com>

which reorganized the ARM options and turned arm_fp16_format from a global 
variable defined in arm.c into an option variable, leading to:

In file included from ../../.././gcc/tm.h:20:0,
                 from /home/eric/svn/gcc/libgcc/fp-bit.c:38:
/home/eric/svn/gcc/libgcc/fp-bit.c: In function '__pack_f':
/home/eric/svn/gcc/libgcc/../gcc/config/arm/arm.h:426:22: error: 
'arm_fp16_format' undeclared (first use in this function)
     ((bits) == 16 && arm_fp16_format == ARM_FP16_FORMAT_ALTERNATIVE)
                      ^
/home/eric/svn/gcc/libgcc/fp-bit.c:205:7: note: in expansion of macro 
'LARGEST_EXPONENT_IS_NORMAL'
   if (LARGEST_EXPONENT_IS_NORMAL (FRAC_NBITS) && (isnan (src) || isinf 
(src)))
       ^
/home/eric/svn/gcc/libgcc/../gcc/config/arm/arm.h:426:22: note: each 
undeclared identifier is reported only once for each function it appears in
     ((bits) == 16 && arm_fp16_format == ARM_FP16_FORMAT_ALTERNATIVE)
                      ^
/home/eric/svn/gcc/libgcc/fp-bit.c:205:7: note: in expansion of macro 
'LARGEST_EXPONENT_IS_NORMAL'
   if (LARGEST_EXPONENT_IS_NORMAL (FRAC_NBITS) && (isnan (src) || isinf 
(src)))
       ^
make[3]: *** [_pack_sf.o] Error 1

Because fp-bit.c references macro
LARGEST_EXPONENT_IS_NORMAL (FRAC_NBITS)
which is defined in arm.h and references arm_fp16_format
which in turn is now a macro defined in options.h:
#define arm_fp16_format global_options.x_arm_fp16_format.

Furthermore

2011-08-05  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

moved fp-bit.c into libgcc, making it more convoluted to fix it.

So we are proposing to switch the VxWorks port over to the soft-fp emulation 
instead of the fp-bit one, like most of the other ARM ports.

Tested on ARM/VxWorks, OK for all active branches (they are all broken)?


2013-05-31  Douglas B Rupp  <rupp@adacore.com>

	* config.host (arm-wrs-vxworks): Configure with other soft float.


-- 
Eric Botcazou

[-- Attachment #2: p.diff --]
[-- Type: text/x-patch, Size: 479 bytes --]

Index: config.host
===================================================================
--- config.host	(revision 199343)
+++ config.host	(working copy)
@@ -316,7 +316,7 @@ alpha*-dec-*vms*)
 	md_unwind_header=alpha/vms-unwind.h
 	;;
 arm-wrs-vxworks)
-	tmake_file="$tmake_file arm/t-arm arm/t-vxworks t-fdpbit"
+	tmake_file="$tmake_file arm/t-arm arm/t-vxworks t-softfp-sfdf t-softfp-excl arm/t-softfp t-softfp"
 	extra_parts="$extra_parts crti.o crtn.o"
 	;;
 arm*-*-netbsdelf*)

             reply	other threads:[~2013-05-31 17:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-31 17:58 Eric Botcazou [this message]
2013-06-06 16:08 ` Richard Earnshaw

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1683552.y1sNTR3Ayg@polaris \
    --to=ebotcazou@adacore.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=rupp@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).