From: "Martin Liška" <mliska@suse.cz>
To: Marek Polacek <polacek@redhat.com>, Andrew Pinski <pinskia@gmail.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>,
Jakub Jelinek <jakub@redhat.com>,
Joseph Myers <joseph@codesourcery.com>,
Maxim Kuvyrkov <maxim.kuvyrkov@linaro.org>,
GCC Patches <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Eric Raymond <esr@thyrsus.com>
Subject: Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git
Date: Mon, 20 May 2019 07:29:00 -0000 [thread overview]
Message-ID: <16944caa-535d-ad8b-bb2c-53836d9b1eda@suse.cz> (raw)
In-Reply-To: <20190519200632.GB7979@redhat.com>
On 5/19/19 10:06 PM, Marek Polacek wrote:
> On Sun, May 19, 2019 at 01:00:45PM -0700, Andrew Pinski wrote:
>> On Sun, May 19, 2019 at 12:54 PM Segher Boessenkool
>> <segher@kernel.crashing.org> wrote:
>>>
>>> On Sun, May 19, 2019 at 03:21:01PM -0400, Marek Polacek wrote:
>>>> On Sun, May 19, 2019 at 03:11:08AM -0500, Segher Boessenkool wrote:
>>>>> On Sun, May 19, 2019 at 09:35:45AM +0200, Martin Liška wrote:
>>>>>> Do we really need a commit integer numbers after the transition? I know
>>>>>> we're used to it.
>>>>>> But git commit hash provides that same.
>>>>>
>>>>> Revision numbers are nice short text strings, and from a revision number
>>>>> you can see approximately when it happened, and from two revision numbers
>>>>> on the same branch you can trivially tell which one is older. Those are
>>>>> nice features. But we can live without it, IMO.
>>>>
>>>> Since I do many bisections a day, losing this capability would be Very Bad.
>>>> Without it, there's no range, and without a range, there's nothing to _bisect_.
>>>>
>>>> I bisect by hand, so if I have cc1plus.250000 (good) and cc1plus.260000 (bad),
>>>> I know the commit I'm looking for is within that range, and I can easily split
>>>> the range, and it's at most log n steps. Whereas if we had e.g. cc1plus.de28b0
>>>> and cc1plus.a9bd4d, I couldn't do it anymore.
>>>
>>> Git can bisect automatically just fine, there is no upside to doing things
>>> manually. In git there are various handy ways of referring to commits; you
>>> can say master@{3 days ago} for example, or zut@{31} to get the 31st
>>> commit back on branch "zut", etc. See "man gitrevisions".
>>
>> Well one thing is if you have prebuilt cc1/cc1plus. So it is not
>> really doing a manual bisect per-say but rather it is doing a manual
>> bisect using prebuilt binaries and knowing which one comes before
>> which one.
>
> Exactly, we have many TBs of prebuilt binaries.
I combine both together, feel free to use my script:
https://github.com/marxin/script-misc/blob/master/gcc-bisect.py
It uses git repository for navigation, information about branches, tag releases
and so on. And then I have a folder with pre-built binaries which are identified
by commit hash. That works all fine.
Martin
>
>> One way is store the binaries based on the date that commit happened
>> instead. This is a bit more complex but still doable.
>
> Yeah, I guess we'll have to do something like that, then. :/
>
> --
> Marek Polacek ⢠Red Hat, Inc. ⢠300 A St, Boston, MA
>
next prev parent reply other threads:[~2019-05-20 7:29 UTC|newest]
Thread overview: 103+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 16:11 Maxim Kuvyrkov
2019-05-14 21:20 ` Segher Boessenkool
2019-05-15 8:34 ` Maxim Kuvyrkov
2019-05-15 18:47 ` Segher Boessenkool
2019-05-16 9:44 ` Maxim Kuvyrkov
2019-05-15 11:19 ` Richard Biener
2019-05-15 12:08 ` Maxim Kuvyrkov
2019-05-15 18:42 ` Eric Gallager
2019-05-16 0:33 ` Paul Koning
2019-05-16 9:53 ` Maxim Kuvyrkov
2019-05-16 16:22 ` Jeff Law
2019-05-16 16:40 ` Maxim Kuvyrkov
2019-05-16 18:36 ` Ramana Radhakrishnan
2019-05-16 19:07 ` Jeff Law
2019-05-16 22:04 ` Jonathan Wakely
2019-05-17 11:33 ` Martin Liška
2019-05-16 23:54 ` Joseph Myers
2019-05-17 8:19 ` Richard Sandiford
2019-05-17 19:51 ` Segher Boessenkool
2019-05-17 20:59 ` Steve Ellcey
2019-05-17 21:23 ` Jason Merrill
2019-05-20 22:42 ` Joseph Myers
2019-05-21 14:24 ` Richard Earnshaw (lists)
2019-05-21 14:45 ` Jeff Law
2019-05-21 15:02 ` Richard Earnshaw (lists)
2019-05-21 16:44 ` Segher Boessenkool
2019-05-23 22:33 ` Joseph Myers
2019-05-24 8:58 ` Segher Boessenkool
2019-05-24 12:02 ` Florian Weimer
2019-05-29 1:50 ` Joseph Myers
2019-05-29 13:04 ` Segher Boessenkool
2019-05-31 0:16 ` Joseph Myers
2019-06-02 23:13 ` Segher Boessenkool
2019-06-03 22:33 ` Joseph Myers
2019-06-03 22:49 ` Segher Boessenkool
2019-06-05 18:04 ` Jason Merrill
2019-06-06 10:14 ` Richard Earnshaw (lists)
2019-06-06 23:41 ` Joseph Myers
2019-06-06 23:50 ` Ian Lance Taylor
2019-06-07 9:32 ` Richard Earnshaw (lists)
2019-06-06 23:36 ` Joseph Myers
2019-07-22 9:05 ` Maxim Kuvyrkov
2019-05-16 23:06 ` Joseph Myers
2019-05-17 12:22 ` Martin Liška
2019-05-17 12:39 ` Jakub Jelinek
2019-05-19 7:35 ` Martin Liška
2019-05-19 8:11 ` Segher Boessenkool
2019-05-19 19:21 ` Marek Polacek
2019-05-19 19:46 ` Andreas Schwab
2019-05-19 19:54 ` Segher Boessenkool
2019-05-19 20:01 ` Andrew Pinski
2019-05-19 20:06 ` Marek Polacek
2019-05-20 7:29 ` Martin Liška [this message]
2019-05-20 13:56 ` Florian Weimer
2019-05-20 14:18 ` Segher Boessenkool
2019-05-20 14:25 ` Jakub Jelinek
2019-05-20 14:26 ` Andreas Schwab
2019-05-20 14:29 ` Jakub Jelinek
2019-05-20 14:36 ` Andreas Schwab
2019-05-20 15:04 ` Segher Boessenkool
2019-05-17 14:59 ` Maxim Kuvyrkov
2019-05-19 7:09 ` Martin Liška
2019-05-17 14:56 ` Maxim Kuvyrkov
2019-05-17 13:07 ` Jason Merrill
2019-05-17 15:08 ` Maxim Kuvyrkov
2019-05-20 22:48 ` Joseph Myers
2019-05-28 10:44 ` Maxim Kuvyrkov
2019-07-16 10:21 ` Maxim Kuvyrkov
2019-07-16 12:40 ` Jason Merrill
2019-07-16 14:27 ` Maxim Kuvyrkov
2019-07-20 11:24 ` Maxim Kuvyrkov
2019-07-22 9:35 ` Maxim Kuvyrkov
2019-08-01 20:43 ` Jason Merrill
2019-08-02 8:41 ` Maxim Kuvyrkov
2019-08-02 8:57 ` Richard Biener
2019-08-02 10:27 ` Martin Liška
2019-08-02 10:54 ` Maxim Kuvyrkov
2019-08-02 11:01 ` Martin Liška
2019-08-02 11:06 ` Richard Biener
2019-08-02 11:35 ` Martin Liška
2019-08-02 22:31 ` Jason Merrill
2019-08-05 13:20 ` Martin Liška
2019-08-05 15:20 ` Monotonically increasing counter (was Re: [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git) Jason Merrill
2019-08-05 15:34 ` Jakub Jelinek
2019-08-05 15:45 ` Richard Earnshaw (lists)
2019-08-05 18:22 ` Jason Merrill
2019-08-14 18:49 ` Jason Merrill
2019-09-19 19:29 ` Jason Merrill
2019-09-21 18:18 ` Segher Boessenkool
2019-09-21 20:31 ` Nicholas Krause
2019-09-21 21:32 ` Jason Merrill
2019-09-22 0:20 ` Segher Boessenkool
2019-08-02 14:35 ` [Contrib PATCH] Add scripts to convert GCC repo from SVN to Git Segher Boessenkool
2019-08-02 14:55 ` Maxim Kuvyrkov
2019-08-05 16:43 ` Mike Stump
2019-08-05 8:24 ` Maxim Kuvyrkov
2019-08-06 11:16 ` Maxim Kuvyrkov
2019-08-23 8:27 ` Maxim Kuvyrkov
2019-08-23 22:08 ` Joseph Myers
2019-09-13 7:20 ` Maxim Kuvyrkov
2019-08-02 8:35 ` Maxim Kuvyrkov
2019-08-02 14:14 ` Maxim Kuvyrkov
2019-08-02 15:47 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16944caa-535d-ad8b-bb2c-53836d9b1eda@suse.cz \
--to=mliska@suse.cz \
--cc=esr@thyrsus.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=maxim.kuvyrkov@linaro.org \
--cc=pbonzini@redhat.com \
--cc=pinskia@gmail.com \
--cc=polacek@redhat.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).