From: "Martin Liška" <mliska@suse.cz>
To: Richard Biener <richard.guenther@gmail.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Richard Sandiford <richard.sandiford@arm.com>,
David Edelsohn <dje.gcc@gmail.com>
Subject: Re: [stage1][PATCH] Lower VEC_COND_EXPR into internal functions.
Date: Tue, 2 Jun 2020 17:00:56 +0200 [thread overview]
Message-ID: <16e3957c-e390-5984-b14e-dd3c70c3bd1c@suse.cz> (raw)
In-Reply-To: <CAFiYyc3p1df3pVU_BvF8Afr_R00mFH7201kQjwojNwW7VNc3xQ@mail.gmail.com>
[-- Attachment #1: Type: text/plain, Size: 440 bytes --]
On 6/2/20 1:09 PM, Richard Biener wrote:
> So please be constructive. Like, provide a testcase that ICEs
> with the FAILs replaced by gcc_unreachable (). Martin, may I suggest
> to do this replacement and bootstrap/test? I think it would be nice
> to have testsuite coverage for the FAILs, and maybe we have that
> already.
Hello.
There's the suggested patch that survives bootstrap on ppc64le-linux-gnu
and passes test-suite.
Martin
[-- Attachment #2: 0001-rs6000-replace-FAIL-with-gcc_unreachable.patch --]
[-- Type: text/x-patch, Size: 2413 bytes --]
From 22db04d058c9bbd140041e7aa2caf1613767095a Mon Sep 17 00:00:00 2001
From: Martin Liska <mliska@suse.cz>
Date: Tue, 2 Jun 2020 15:29:37 +0200
Subject: [PATCH] rs6000: replace FAIL with gcc_unreachable.
gcc/ChangeLog:
* config/rs6000/vector.md: Replace FAIL with gcc_unreachable
in all vcond* patterns.
---
gcc/config/rs6000/vector.md | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/gcc/config/rs6000/vector.md b/gcc/config/rs6000/vector.md
index 662521e74fe..796345c80d3 100644
--- a/gcc/config/rs6000/vector.md
+++ b/gcc/config/rs6000/vector.md
@@ -354,7 +354,7 @@ (define_expand "vcond<mode><mode>"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
(define_expand "vcond<mode><mode>"
@@ -371,7 +371,7 @@ (define_expand "vcond<mode><mode>"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
(define_expand "vcondv4sfv4si"
@@ -389,7 +389,7 @@ (define_expand "vcondv4sfv4si"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
(define_expand "vcondv4siv4sf"
@@ -407,7 +407,7 @@ (define_expand "vcondv4siv4sf"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
(define_expand "vcondv2dfv2di"
@@ -425,7 +425,7 @@ (define_expand "vcondv2dfv2di"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
(define_expand "vcondv2div2df"
@@ -443,7 +443,7 @@ (define_expand "vcondv2div2df"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
(define_expand "vcondu<mode><mode>"
@@ -460,7 +460,7 @@ (define_expand "vcondu<mode><mode>"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
(define_expand "vconduv4sfv4si"
@@ -478,7 +478,7 @@ (define_expand "vconduv4sfv4si"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
(define_expand "vconduv2dfv2di"
@@ -496,7 +496,7 @@ (define_expand "vconduv2dfv2di"
operands[3], operands[4], operands[5]))
DONE;
else
- FAIL;
+ gcc_unreachable ();
})
;; To support vector condition vectorization, define vcond_mask and vec_cmp.
--
2.26.2
next prev parent reply other threads:[~2020-06-02 15:00 UTC|newest]
Thread overview: 65+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-09-24 10:25 [PATCH][RFC] Come up with VEC_COND_OP_EXPRs Martin Liška
2019-09-24 11:11 ` Richard Sandiford
2019-09-24 11:29 ` Richard Biener
2019-09-24 11:57 ` Richard Sandiford
2019-09-24 12:18 ` Richard Biener
2019-09-24 14:51 ` Richard Sandiford
2020-04-01 10:19 ` [stage1][PATCH] Lower VEC_COND_EXPR into internal functions Martin Liška
2020-04-06 9:17 ` Richard Sandiford
2020-04-06 12:30 ` Richard Biener
2020-05-21 12:51 ` Martin Liška
2020-05-21 13:29 ` Martin Liška
2020-05-21 20:16 ` Segher Boessenkool
2020-05-22 11:14 ` Richard Biener
2020-05-26 10:15 ` Richard Sandiford
2020-05-27 14:04 ` Martin Liška
2020-05-27 16:13 ` Richard Sandiford
2020-05-27 16:32 ` Richard Biener
2020-05-28 14:46 ` Martin Liška
2020-05-28 15:28 ` Richard Sandiford
2020-05-29 12:17 ` Richard Biener
2020-05-29 12:43 ` Richard Biener
2020-05-29 16:47 ` Segher Boessenkool
2020-05-29 17:05 ` Richard Sandiford
2020-05-29 17:30 ` Segher Boessenkool
2020-05-29 15:39 ` Segher Boessenkool
2020-05-29 16:57 ` Richard Sandiford
2020-05-29 17:09 ` Segher Boessenkool
2020-05-29 17:26 ` Richard Sandiford
2020-05-29 17:37 ` Segher Boessenkool
2020-05-30 7:15 ` Richard Sandiford
2020-05-30 13:08 ` Segher Boessenkool
2020-06-02 11:09 ` Richard Biener
2020-06-02 15:00 ` Martin Liška [this message]
2020-06-03 7:38 ` Richard Biener
2020-06-03 13:41 ` Richard Sandiford
2020-06-03 14:17 ` David Edelsohn
2020-06-03 14:46 ` Richard Biener
2020-06-03 17:01 ` Segher Boessenkool
2020-06-03 17:23 ` Richard Biener
2020-06-03 18:23 ` Segher Boessenkool
2020-06-03 18:38 ` Richard Biener
2020-06-03 18:46 ` David Edelsohn
2020-06-03 19:09 ` Segher Boessenkool
2020-06-03 19:13 ` Jakub Jelinek
2020-06-03 18:27 ` Segher Boessenkool
2020-06-08 11:04 ` Martin Liška
2020-06-09 13:42 ` Richard Biener
2020-06-10 8:51 ` Martin Liška
2020-06-10 10:50 ` Richard Biener
2020-06-10 12:27 ` Martin Liška
2020-06-10 13:01 ` Martin Liška
2020-06-11 8:52 ` Martin Liška
2020-06-12 9:43 ` Richard Biener
2020-06-12 13:24 ` Martin Liška
2020-06-15 7:14 ` Richard Biener
2020-06-15 11:19 ` Martin Liška
2020-06-15 11:59 ` Richard Biener
2020-06-15 12:20 ` Martin Liška
2020-06-17 8:50 ` Richard Biener
2020-06-17 13:15 ` Richard Biener
2020-06-18 8:10 ` Martin Liška
2020-06-18 8:52 ` Richard Biener
2020-06-18 9:02 ` Martin Liška
2020-06-18 9:29 ` Martin Liška
2020-04-06 12:33 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=16e3957c-e390-5984-b14e-dd3c70c3bd1c@suse.cz \
--to=mliska@suse.cz \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=richard.sandiford@arm.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).