From: Iain Buclaw <ibuclaw@gdcproject.org>
To: gcc-patches@gcc.gnu.org, Yang Yujie <yangyujie@loongson.cn>
Cc: chenglulu@loongson.cn, xuchenghua@loongson.cn
Subject: Re: [PATCH v3 2/3] libphobos: Update build scripts for LoongArch64.
Date: Thu, 07 Dec 2023 11:34:28 +0100 [thread overview]
Message-ID: <1701945040.awjsuc9b2c.astroid@pulse.none> (raw)
In-Reply-To: <20231201100827.227376-3-yangyujie@loongson.cn>
Excerpts from Yang Yujie's message of Dezember 1, 2023 11:08 am:
> libphobos/ChangeLog:
>
> * m4/druntime/cpu.m4: Support loongarch* targets.
> * libdruntime/Makefile.am: Same.
> * libdruntime/Makefile.in: Regenerate.
> * configure: Regenerate.
> ---
> libphobos/configure | 21 ++++++-
> libphobos/libdruntime/Makefile.am | 3 +
> libphobos/libdruntime/Makefile.in | 98 +++++++++++++++++++------------
> libphobos/m4/druntime/cpu.m4 | 5 ++
> 4 files changed, 87 insertions(+), 40 deletions(-)
>
> diff --git a/libphobos/libdruntime/Makefile.am b/libphobos/libdruntime/Makefile.am
> index 23205fd3301..ca43a0753c4 100644
> --- a/libphobos/libdruntime/Makefile.am
> +++ b/libphobos/libdruntime/Makefile.am
> @@ -83,6 +83,9 @@ endif
> if DRUNTIME_CPU_ARM
> DRUNTIME_SOURCES_CONFIGURED += config/arm/switchcontext.S
> endif
> +if DRUNTIME_CPU_LOONGARCH
> + DRUNTIME_SOURCES_CONFIGURED += config/loongarch/switchcontext.S
> +endif
> if DRUNTIME_CPU_MIPS
> DRUNTIME_SOURCES_CONFIGURED += config/mips/switchcontext.S
> endif
Just a nitpick, I'd thought the committing of switchcontext.S should
come before this. I have no strong opinion either way.
OK to commit.
Iain.
next prev parent reply other threads:[~2023-12-07 10:34 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-01 10:08 [PATCH v3 0/3] LoongArch D support Yang Yujie
2023-12-01 10:08 ` [PATCH v3 1/3] LoongArch: Adjust D version strings Yang Yujie
2023-12-07 10:30 ` Iain Buclaw
2023-12-08 1:50 ` Yang Yujie
2023-12-01 10:08 ` [PATCH v3 2/3] libphobos: Update build scripts for LoongArch64 Yang Yujie
2023-12-07 10:34 ` Iain Buclaw [this message]
2023-12-08 1:53 ` Yang Yujie
2023-12-01 10:08 ` [PATCH v3 3/3] libruntime: Add fiber context switch code for LoongArch Yang Yujie
2023-12-07 10:36 ` Iain Buclaw
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1701945040.awjsuc9b2c.astroid@pulse.none \
--to=ibuclaw@gdcproject.org \
--cc=chenglulu@loongson.cn \
--cc=gcc-patches@gcc.gnu.org \
--cc=xuchenghua@loongson.cn \
--cc=yangyujie@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).