From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5105 invoked by alias); 3 Aug 2016 16:06:20 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 5095 invoked by uid 89); 3 Aug 2016 16:06:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.1 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with (AES256-GCM-SHA384 encrypted) ESMTPS; Wed, 03 Aug 2016 16:06:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2600C3D9; Wed, 3 Aug 2016 16:06:17 +0000 (UTC) Received: from localhost.localdomain (ovpn-116-194.phx2.redhat.com [10.3.116.194]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u73G6Ghf016213; Wed, 3 Aug 2016 12:06:16 -0400 Subject: Re: [PATCH 1/4] selftest.h: Add ASSERT_TRUE_AT and ASSERT_FALSE_AT To: David Malcolm , gcc-patches@gcc.gnu.org References: <1469841382.17384.65.camel@redhat.com> <1470239113-42666-1-git-send-email-dmalcolm@redhat.com> Cc: Joseph Myers From: Jeff Law Message-ID: <17027244-d43e-ba27-9443-fd6451f8dc68@redhat.com> Date: Wed, 03 Aug 2016 16:06:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1470239113-42666-1-git-send-email-dmalcolm@redhat.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-IsSubscribed: yes X-SW-Source: 2016-08/txt/msg00215.txt.bz2 On 08/03/2016 09:45 AM, David Malcolm wrote: > I split out the selftest.h changes from v2 of the kit for ease of review; > here they are. > > Successfully bootstrapped®rtested in conjunction with the rest of the > patch kit on x86_64-pc-linux-gnu. > > OK for trunk? > > gcc/ChangeLog: > * selftest.h (ASSERT_TRUE): Reimplement in terms of... > (ASSERT_TRUE_AT): New macro. > (ASSERT_FALSE): Reimplement in terms of... > (ASSERT_FALSE_AT): New macro. > (ASSERT_STREQ_AT): Fix typo in comment. OK. Though I do wonder if these should just be normal functions... I assume there's a good reason for the macro pain :) jeff