From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wm1-f48.google.com (mail-wm1-f48.google.com [209.85.128.48]) by sourceware.org (Postfix) with ESMTPS id 4EC2C3857BA1 for ; Tue, 12 Jul 2022 18:56:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 4EC2C3857BA1 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com Received: by mail-wm1-f48.google.com with SMTP id be14-20020a05600c1e8e00b003a04a458c54so5355061wmb.3 for ; Tue, 12 Jul 2022 11:56:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=eD7WCEV+lk2H6jJVb0S0blUfEoZqGDnQQ8pMy0chDHE=; b=694fV/j62zijHrL/yWFLc63Q3t1LMO+Z4CU+vyyGNB/kr4PymnvBu3TfGz5QO3GuEU JZbOsFz4SJG9agj7YiAenUe8Q2vAxvAYJwbgKmXVBjEro4g94F5D5FQnkL+dvZVYRe83 Zyfgv2RQNQ3W5EsO6OFDN3G7Y6siUOWsuFpGpEcOKuzzrEfYtMPhZ6IYOP7qcQSdl4HR 4yBeRxJ1Lij2Dj3autGNbWpKBKDhqdbgJu97Odp54utcq71/3380G/wh7SlNyZkIMgXb 73ZykYXLoiOP5qj6lzcEVMLhb2+AKZlSKOFvM1Da7I+gzyDflcmJ0omvBYvB7Gs7P8yy rNQA== X-Gm-Message-State: AJIora9VPsRrs+RYrH9pKi+pByAJBDB0aF6WB5ncrRAvydV+nrdY7Unl NRbnFTrORZ272WVue3hXAIxVlW9vpBc= X-Google-Smtp-Source: AGRyM1uWQorZeZP2X9dPOMXUJbjk8WQEMM7Hl2SpP0iDqjwRfEXI5aqjkpy2qbPR1vkS6PIhP54T3A== X-Received: by 2002:a05:600c:a42:b0:39c:9166:5a55 with SMTP id c2-20020a05600c0a4200b0039c91665a55mr5360525wmq.141.1657652163543; Tue, 12 Jul 2022 11:56:03 -0700 (PDT) Received: from ?IPv6:2001:8a0:f924:2600:209d:85e2:409e:8726? ([2001:8a0:f924:2600:209d:85e2:409e:8726]) by smtp.gmail.com with ESMTPSA id q123-20020a1c4381000000b00397402ae674sm11000722wma.11.2022.07.12.11.56.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 12 Jul 2022 11:56:02 -0700 (PDT) Subject: Re: [PATCH 1/2] Add gcc/make-unique.h To: Jonathan Wakely Cc: David Malcolm , gcc-patches References: <20220712002527.417444-1-dmalcolm@redhat.com> <03b8afc0-b917-e940-4995-9ba5493567c2@palves.net> <7f2ddb2d-da00-6852-339a-86c7d853087f@palves.net> <55f00de5-6c6b-51f3-01d4-5f7710e2c792@palves.net> From: Pedro Alves Message-ID: <17033795-0a8d-f624-0710-64811aaee8d2@palves.net> Date: Tue, 12 Jul 2022 19:56:01 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gcc-patches@gcc.gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gcc-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 12 Jul 2022 18:56:06 -0000 On 2022-07-12 7:50 p.m., Jonathan Wakely wrote: > Yeah, and I don't think optimizing for indentation is the right trade off. Putting something in a namespace with a three-letter name just so you don't have to re-indent some statements in a few years seems odd. > > I see no technical difficulty replacing a custom make_unique (in any namespace) with std::make_unique at a later date. > > If a namespace made sense to avoid name clashes, or to enable finding functions by ADL, or other technical reasons, I'd be all for it. But no such rationale was given, and using a namespace for indentation just seems odd to me. > > But I really don't care. Putting it in the global namespace or a 'gcc' namespace or anything else appropriate to GCC is fine. I'll leave this thread now. I don't think this is very constructive and I'm sorry for objecting to the suggestion. That's fair. Cheers! Hope we'll be able to laugh about it in Prague!