From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by sourceware.org (Postfix) with ESMTPS id 00E48385B52E for ; Wed, 13 Dec 2023 07:52:20 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 00E48385B52E Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 00E48385B52E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.130 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702453942; cv=none; b=mRhl062K0CGYWNoW1FN8K0JS5bibtrgB9EAvGjC/B0gxs9PTKWf2XbdSPWi+F0g1VwCkYP6XiVTfzBWSRUzeotXC1rzSsEXR3FP/zpj3ZPZuQ7s0EbFOzgSVT+gozrAEI8fX8hgWhLmxvxNgC6qlEsI+oH5tpFtyQe6Ia6f/0R0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1702453942; c=relaxed/simple; bh=OyOz0/PQg8uoRkdrGfgLaPm3rly+maucptTqnt6mLbs=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature:Date: From:To:Subject:Message-ID:MIME-Version; b=BiQS3XbD+OPN0xZKOuriFaIm5N6q2qucuMUULWDmGhedzBu5wRGGRSVHF7ciXQPl9t3J99SyOXP688yE4ahKkSUvIKMldAIlTvX0s+rDdsolhlXO+6oqIs6RqFrmmEJs2bYBh/1h/8KuuYO84md3BfrI/K1HkD3ll5REZTAim9E= ARC-Authentication-Results: i=1; server2.sourceware.org Received: from [10.168.4.150] (unknown [10.168.4.150]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id E1BED2255F; Wed, 13 Dec 2023 07:52:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702453939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s1lb2VCJAKJ1WizfP02mpzjrOF+nPNve8L96PDf+KDI=; b=Zv0Tx/3eo9/mnClBwzP/IDe58oiXMAxhTdlYg9ubs4QihC2i2fod8UVfLa2rSnllMJhRGb FVzytAP4hJvT6c1xUn9X4YOBLsnNvwSPnHMVslY+Q9qMGWuesI3dMpyrwgoN6sG1XAJS9h brOVLY+qb4+0IWltLSP/YzJO7tGNowM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702453939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s1lb2VCJAKJ1WizfP02mpzjrOF+nPNve8L96PDf+KDI=; b=djmP5gr7EROzfrIwhU6kfqdJ0KzzcP7dyBLBsO0rs6BKj4TPDVetvOY5P1z6QsJm6K4bev sxBjf4/PxaMY10CA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1702453939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s1lb2VCJAKJ1WizfP02mpzjrOF+nPNve8L96PDf+KDI=; b=Zv0Tx/3eo9/mnClBwzP/IDe58oiXMAxhTdlYg9ubs4QihC2i2fod8UVfLa2rSnllMJhRGb FVzytAP4hJvT6c1xUn9X4YOBLsnNvwSPnHMVslY+Q9qMGWuesI3dMpyrwgoN6sG1XAJS9h brOVLY+qb4+0IWltLSP/YzJO7tGNowM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1702453939; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=s1lb2VCJAKJ1WizfP02mpzjrOF+nPNve8L96PDf+KDI=; b=djmP5gr7EROzfrIwhU6kfqdJ0KzzcP7dyBLBsO0rs6BKj4TPDVetvOY5P1z6QsJm6K4bev sxBjf4/PxaMY10CA== Date: Wed, 13 Dec 2023 08:51:16 +0100 (CET) From: Richard Biener To: Peter Bergner cc: Jason Merrill , Martin Jambor , GCC Patches Subject: Re: [PATCH] SRA: Force gimple operand in an additional corner case (PR 112822) In-Reply-To: <0ea23f53-f51a-4773-afe2-fce0d87e799e@linux.ibm.com> Message-ID: <1703r293-4sr6-4n69-o0p9-93qsn7p043n9@fhfr.qr> References: <2A02E1DE-3400-4702-A588-49FC22A94247@suse.de> <53be4861-2b8f-45d3-a0ad-ff7a68361c72@linux.ibm.com> <73527e3a-e56f-46d3-afef-615ace014cb5@redhat.com> <0ea23f53-f51a-4773-afe2-fce0d87e799e@linux.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII X-Spam-Level: X-Spam-Score: -1.37 X-Spam-Level: X-Spam-Flag: NO Authentication-Results: smtp-out1.suse.de; none X-Spamd-Result: default: False [-2.32 / 50.00]; ARC_NA(0.00)[]; FROM_HAS_DN(0.00)[]; RCPT_COUNT_THREE(0.00)[4]; TO_MATCH_ENVRCPT_ALL(0.00)[]; NEURAL_HAM_LONG(-1.00)[-0.999]; MIME_GOOD(-0.10)[text/plain]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; TO_DN_ALL(0.00)[]; FUZZY_BLOCKED(0.00)[rspamd.com]; RCVD_COUNT_ZERO(0.00)[0]; FROM_EQ_ENVFROM(0.00)[]; MIME_TRACE(0.00)[0:+]; BAYES_HAM(-1.22)[89.33%] X-Spam-Score: -2.32 X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_NONE,SPF_PASS,TXREP,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org List-Id: On Tue, 12 Dec 2023, Peter Bergner wrote: > On 12/12/23 8:36 PM, Jason Merrill wrote: > > This test is failing for me below C++17, I think you need > > > > // { dg-do compile { target c++17 } } > > or > > // { dg-require-effective-target c++17 } > > Sorry about that. Should we do the above or should we just add > -std=c++17 to dg-options? ...or do we need to do both? Just do the above, the C++ testsuite iterates over all standards, adding -std=c++17 would just run that 5 times. But the above properly skips unsupported cases. Richard.