[PATCH] testsuite: gdc: Require ucn in gdc.test/runnable/mangle.d etc. [PR104739]

[PATCH] testsuite: gdc: Require ucn in gdc.test/runnable/mangle.d etc. [PR104739]

[Rainer Orth]

[-- Attachment #1: Type: text/plain, Size: 2054 bytes --]

gdc.test/runnable/mangle.d and two other tests come out UNRESOLVED on
Solaris with the native assembler:

UNRESOLVED: gdc.test/runnable/mangle.d   compilation failed to produce executable
UNRESOLVED: gdc.test/runnable/mangle.d -shared-libphobos   compilation failed to produce executable
UNRESOLVED: gdc.test/runnable/testmodule.d   compilation failed to produce executable 
UNRESOLVED: gdc.test/runnable/testmodule.d -shared-libphobos   compilation failed to produce executable
UNRESOLVED: gdc.test/runnable/ufcs.d   compilation failed to produce executable
UNRESOLVED: gdc.test/runnable/ufcs.d -shared-libphobos   compilation failed to produce executable

Assembler: mangle.d
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
        Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
        Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
        Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
        Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
        "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
[...]

since /bin/as lacks UCN support.

Iain recently added UNICODE_NAMES: annotations to the affected tests and
those recently were imported into trunk.

This patch handles the DejaGnu side of things, adding

	{ dg-require-effective-target ucn }

to those tests on the fly.

Tested on i386-pc-solaris2.11, sparc-sun-solaris2.11 (as and gas each),
and x86_64-pc-linux-gnu.

Ok for trunk.

	Rainer

-- 
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University


2024-02-03  Rainer Orth  <ro@CeBiTec.Uni-Bielefeld.DE>

	gcc/testsuite:
	PR d/104739
	* lib/gdc-utils.exp (gdc-convert-test) <UNICODE_NAMES>: Require
	ucn support.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: testsuite-gdc-mangle-ucn.patch --]
[-- Type: text/x-patch, Size: 959 bytes --]

# HG changeset patch
# Parent  5072a8062cf1eac00205b715f4c1af31c9fc45ca
testsuite: gdc: Require ucn in gdc.test/runnable/mangle.d etc. [PR104739]

diff --git a/gcc/testsuite/lib/gdc-utils.exp b/gcc/testsuite/lib/gdc-utils.exp
--- a/gcc/testsuite/lib/gdc-utils.exp
+++ b/gcc/testsuite/lib/gdc-utils.exp
@@ -244,6 +244,7 @@ proc gdc-copy-file { srcdir filename } {
 #   POST_SCRIPT:	Not handled.
 #   REQUIRED_ARGS:	Arguments to add to the compiler command line.
 #   DISABLED:		Not handled.
+#   UNICODE_NAMES:	Requires ucn support.
 #
 
 proc gdc-convert-test { base test } {
@@ -365,6 +366,10 @@ proc gdc-convert-test { base test } {
 	    # COMPILABLE_MATH_TEST annotates tests that import the std.math
 	    # module.  Which will need skipping if not available on the target.
 	    set needs_phobos 1
+	} elseif [regexp -- {UNICODE_NAMES} $copy_line] {
+	    # Require ucn support.
+	    puts $fdout "// { dg-require-effective-target ucn }"
+
 	}
     }
 

Re: [PATCH] testsuite: gdc: Require ucn in gdc.test/runnable/mangle.d etc. [PR104739]

[Iain Buclaw]

Excerpts from Rainer Orth's message of Februar 14, 2024 11:51 am:
> gdc.test/runnable/mangle.d and two other tests come out UNRESOLVED on
> Solaris with the native assembler:
> 
> UNRESOLVED: gdc.test/runnable/mangle.d   compilation failed to produce executable
> UNRESOLVED: gdc.test/runnable/mangle.d -shared-libphobos   compilation failed to produce executable
> UNRESOLVED: gdc.test/runnable/testmodule.d   compilation failed to produce executable 
> UNRESOLVED: gdc.test/runnable/testmodule.d -shared-libphobos   compilation failed to produce executable
> UNRESOLVED: gdc.test/runnable/ufcs.d   compilation failed to produce executable
> UNRESOLVED: gdc.test/runnable/ufcs.d -shared-libphobos   compilation failed to produce executable
> 
> Assembler: mangle.d
>         "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
>         Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
>         "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
>         Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
>         "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
>         Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
>         "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
>         Near line: "    movzbl  test_эльфийские_письмена_9, %eax"
>         "/var/tmp//cci9q2Sc.s", line 115 : Syntax error
> [...]
> 
> since /bin/as lacks UCN support.
> 
> Iain recently added UNICODE_NAMES: annotations to the affected tests and
> those recently were imported into trunk.
> 
> This patch handles the DejaGnu side of things, adding
> 
> 	{ dg-require-effective-target ucn }
> 
> to those tests on the fly.
> 
> Tested on i386-pc-solaris2.11, sparc-sun-solaris2.11 (as and gas each),
> and x86_64-pc-linux-gnu.
> 
> Ok for trunk.
> 

OK.

Thanks!
Iain.