From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 108359 invoked by alias); 7 Jul 2016 09:00:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 108245 invoked by uid 89); 7 Jul 2016 09:00:06 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.2 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=Hx-languages-length:1965, consistently X-HELO: foss.arm.com Received: from foss.arm.com (HELO foss.arm.com) (217.140.101.70) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 07 Jul 2016 08:59:56 +0000 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id EF43F28; Thu, 7 Jul 2016 02:00:54 -0700 (PDT) Received: from e108577-lin.localnet (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 341883F41F; Thu, 7 Jul 2016 01:59:55 -0700 (PDT) From: Thomas Preudhomme To: Kyrill Tkachov Cc: gcc-patches@gcc.gnu.org, Richard Earnshaw , Ramana Radhakrishnan Subject: Re: [PATCH, ARM 4/7, ping1] Factor out MOVW/MOVT availability and desirability checks Date: Thu, 07 Jul 2016 09:00:00 -0000 Message-ID: <1708772.PVA2fo5dkC@e108577-lin> User-Agent: KMail/4.13.3 (Linux/3.13.0-85-generic; KDE/4.13.3; x86_64; ; ) In-Reply-To: <573F05FA.7030701@foss.arm.com> References: <003401d138a0$d3757c70$7a607550$@foss.arm.com> <4211853.CieZkaLpEh@e108577-lin> <573F05FA.7030701@foss.arm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="utf-8" X-IsSubscribed: yes X-SW-Source: 2016-07/txt/msg00291.txt.bz2 On Friday 20 May 2016 13:41:30 Kyrill Tkachov wrote: > Hi Thomas, > > On 19/05/16 17:10, Thomas Preudhomme wrote: > > On Wednesday 18 May 2016 11:47:47 Kyrill Tkachov wrote: > >> Hi Thomas, > > > > Hi Kyrill, > > > > Please find below the updated patch and associated ChangeLog entry. > > > > *** gcc/ChangeLog *** > > > > 2016-05-18 Thomas Preud'homme > > > > * config/arm/arm.h (TARGET_USE_MOVT): Check MOVT/MOVW > > availability > > with TARGET_HAVE_MOVT. > > (TARGET_HAVE_MOVT): Define. > > * config/arm/arm.c (const_ok_for_op): Check MOVT/MOVW > > availability with TARGET_HAVE_MOVT. > > * config/arm/arm.md (arm_movt): Use TARGET_HAVE_MOVT to check > > movt > > availability. > > (addsi splitter): Use TARGET_THUMB && TARGET_HAVE_MOVT rather > > than > > TARGET_THUMB2. > > (symbol_refs movsi splitter): Remove TARGET_32BIT check. > > (arm_movtas_ze): Use TARGET_HAVE_MOVT to check movt availability. > > * config/arm/constraints.md (define_constraint "j"): Use > > TARGET_HAVE_MOVT to check movt availability. > > Please use capitalised MOVW/MOVT consistently in the ChangeLog. > Ok with a fixed ChangeLog. Committed with the following ChangeLog entry: 2016-05-18 Thomas Preud'homme * config/arm/arm.h (TARGET_USE_MOVT): Check MOVT/MOVW availability with TARGET_HAVE_MOVT. (TARGET_HAVE_MOVT): Define. * config/arm/arm.c (const_ok_for_op): Check MOVT/MOVW availability with TARGET_HAVE_MOVT. * config/arm/arm.md (arm_movt): Use TARGET_HAVE_MOVT to check MOVT availability. (addsi splitter): Use TARGET_THUMB && TARGET_HAVE_MOVT rather than TARGET_THUMB2. (symbol_refs movsi splitter): Remove TARGET_32BIT check. (arm_movtas_ze): Use TARGET_HAVE_MOVT to check MOVT availability. * config/arm/constraints.md (define_constraint "j"): Use TARGET_HAVE_MOVT to check MOVT availability. Thanks. Best regards, Thomas