From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 14383 invoked by alias); 28 Nov 2012 23:19:52 -0000 Received: (qmail 14367 invoked by uid 22791); 28 Nov 2012 23:19:51 -0000 X-SWARE-Spam-Status: No, hits=-2.9 required=5.0 tests=AWL,BAYES_00,KHOP_THREADED,TW_XT X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 28 Nov 2012 23:19:46 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id DA9AACB262A; Thu, 29 Nov 2012 00:19:49 +0100 (CET) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ik8ClEixhNXN; Thu, 29 Nov 2012 00:19:49 +0100 (CET) Received: from polaris.localnet (bon31-6-88-161-99-133.fbx.proxad.net [88.161.99.133]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 56105CB261B; Thu, 29 Nov 2012 00:19:49 +0100 (CET) From: Eric Botcazou To: Richard Sandiford Cc: gcc-patches@gcc.gnu.org, ramrad01@arm.com Subject: Re: [0/8] Add optabs alternatives for insv, extv and extzv Date: Wed, 28 Nov 2012 23:19:00 -0000 Message-ID: <1713924.N0H2Yc8llc@polaris> User-Agent: KMail/4.7.2 (Linux/3.1.10-1.16-desktop; KDE/4.7.2; x86_64; ; ) In-Reply-To: <87lidlvnh1.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> References: <87k3u3eybu.fsf@talisman.home> <87lidlvnh1.fsf@sandifor-thinkpad.stglab.manchester.uk.ibm.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org X-SW-Source: 2012-11/txt/msg02381.txt.bz2 > This is because the structure we are given is: > > (mem/v/j:SI (reg/v/f:SI 110 [ t ]) [3 t_2(D)->a+0 S1 A32]) > > i.e. a 1-byte SImode reference. The strange size comes from the > set_mem_attributes_minus_bitpos code that was mentioned earlier > in the series, where we set the size based on the type even if > it doesn't match the mode. I think that's wrong, we should have S4 and drop the MEM_EXPR as we would do it with adjust_bitfield_address. In other words, if the size computed from the tree is smaller than the mode size, we don't use it and clear MEM_EXPR. -- Eric Botcazou