* libiberty TAGS
@ 2015-06-18 20:35 Mike Stump
2015-06-18 20:55 ` Andreas Schwab
0 siblings, 1 reply; 4+ messages in thread
From: Mike Stump @ 2015-06-18 20:35 UTC (permalink / raw)
To: GCC Patches
I was making tags in libiberty and noticed it just didn’t work. :-(
This is one easy way to fix it.
Ok?
diff --git a/libiberty/Makefile.in b/libiberty/Makefile.in
index f06cc69..876fab2 100644
--- a/libiberty/Makefile.in
+++ b/libiberty/Makefile.in
@@ -409,8 +409,9 @@ stamp-noasandir:
etags tags: TAGS etags-subdir
+VPATH = @srcdir@
TAGS: $(CFILES)
- etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done`
+ cd $(srcdir) && etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done`
# The standalone demangler (c++filt) has been moved to binutils.
# But make this target work anyway for demangler hacking.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: libiberty TAGS
2015-06-18 20:35 libiberty TAGS Mike Stump
@ 2015-06-18 20:55 ` Andreas Schwab
2015-06-18 22:48 ` Mike Stump
0 siblings, 1 reply; 4+ messages in thread
From: Andreas Schwab @ 2015-06-18 20:55 UTC (permalink / raw)
To: Mike Stump; +Cc: GCC Patches
Mike Stump <mikestump@comcast.net> writes:
> + cd $(srcdir) && etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done`
This doesn't work with a relative $(srcdir).
Andreas.
--
Andreas Schwab, schwab@linux-m68k.org
GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5
"And now for something completely different."
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: libiberty TAGS
2015-06-18 20:55 ` Andreas Schwab
@ 2015-06-18 22:48 ` Mike Stump
0 siblings, 0 replies; 4+ messages in thread
From: Mike Stump @ 2015-06-18 22:48 UTC (permalink / raw)
To: Andreas Schwab; +Cc: GCC Patches
On Jun 18, 2015, at 1:35 PM, Andreas Schwab <schwab@linux-m68k.org> wrote:
> Mike Stump <mikestump@comcast.net> writes:
>
>> + cd $(srcdir) && etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done`
>
> This doesn't work with a relative $(srcdir).
Sure it does. I had tested with:
srcdir = ../../gcc/libiberty
which is a pretty typical relative srcdir, is it not?
Anyway, I see your point. How about:
diff --git a/libiberty/Makefile.in b/libiberty/Makefile.in
index f06cc69..11e5ce6 100644
--- a/libiberty/Makefile.in
+++ b/libiberty/Makefile.in
@@ -409,8 +409,9 @@ stamp-noasandir:
etags tags: TAGS etags-subdir
+VPATH = @srcdir@
TAGS: $(CFILES)
- etags `for i in $(CFILES); do echo $(srcdir)/$$i ; done`
+ cd $(srcdir) && etags $(CFILES)
# The standalone demangler (c++filt) has been moved to binutils.
# But make this target work anyway for demangler hacking.
Ok?
^ permalink raw reply [flat|nested] 4+ messages in thread
* libiberty TAGS
@ 2015-11-12 19:25 Mike Stump
0 siblings, 0 replies; 4+ messages in thread
From: Mike Stump @ 2015-11-12 19:25 UTC (permalink / raw)
To: GCC Patches
I applied this one as obvious.
* Makefile.in (etags tags TAGS): Use && instead of ;.
Index: Makefile.in
===================================================================
--- Makefile.in (revision 230269)
+++ Makefile.in (working copy)
@@ -409,7 +409,7 @@ stamp-noasandir:
.PHONY: all etags tags TAGS ls clean stage1 stage2
etags tags TAGS: etags-subdir
- cd $(srcdir); etags $(CFILES)
+ cd $(srcdir) && etags $(CFILES)
# The standalone demangler (c++filt) has been moved to binutils.
# But make this target work anyway for demangler hacking.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-11-12 19:25 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-06-18 20:35 libiberty TAGS Mike Stump
2015-06-18 20:55 ` Andreas Schwab
2015-06-18 22:48 ` Mike Stump
2015-11-12 19:25 Mike Stump
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).